magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Remove support of Service attachment for Eventing Config registrationDestinationConfig field

Open balanaguharsha opened this issue 1 year ago • 4 comments

… field.

Remove support of Service attachment for Eventing Config registrationDestinationConfig field

Release Note Template for Downstream PRs (will be copied)

Eventing Config's registrationDestinationConfig field doens't support Service attachment. 

balanaguharsha avatar Dec 09 '23 14:12 balanaguharsha

Hello! I am a robot. It looks like you are a: ~Community Contributor~ Googler ~Core Contributor~. Tests will run automatically.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician avatar Dec 09 '23 14:12 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field eventing_config.registration_destination_config.destination.service_attachment within resource google_integration_connectors_connection was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 2 insertions(+), 27 deletions(-)) Terraform Beta: Diff ( 2 files changed, 2 insertions(+), 27 deletions(-)) TF Conversion: Diff ( 1 file changed, 11 deletions(-))

modular-magician avatar Dec 09 '23 14:12 modular-magician

Tests analytics

Total tests: 3279 Passed tests 2944 Skipped tests: 334 Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionSaExample

Get to know how VCR tests work

modular-magician avatar Dec 09 '23 15:12 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionSaExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Dec 09 '23 15:12 modular-magician

@balanaguharsha, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

If no action is taken, this PR will be closed in 14 days.

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar May 29 '24 09:05 github-actions[bot]

@balanaguharsha, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

If no action is taken, this PR will be closed in 2 weekdays.

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar Jun 10 '24 09:06 github-actions[bot]

@balanaguharsha, this PR is being closed due to inactivity.

github-actions[bot] avatar Jun 12 '24 09:06 github-actions[bot]