magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Add support for Managed zone resource of Integration Connectors.

Open balanaguharsha opened this issue 1 year ago • 14 comments

Adding support for Managed zone resource of Integration connectors.

Release Note Template for Downstream PRs (will be copied)

`google_integration_connectors_managed_zone`

Fixes https://github.com/hashicorp/terraform-provider-google/issues/16762

balanaguharsha avatar Dec 09 '23 12:12 balanaguharsha

Hello! I am a robot. It looks like you are a: ~Community Contributor~ Googler ~Core Contributor~. Tests will run automatically.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician avatar Dec 09 '23 12:12 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 972 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 5 files changed, 972 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 116 insertions(+)) TF OiCS: Diff ( 4 files changed, 114 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_integration_connectors_managed_zone (0 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_integration_connectors_managed_zone" "primary" {
  description    = # value needed
  dns            = # value needed
  labels         = # value needed
  name           = # value needed
  target_project = # value needed
  target_vpc     = # value needed
}

modular-magician avatar Dec 09 '23 12:12 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 972 insertions(+), 7 deletions(-)) Terraform Beta: Diff ( 6 files changed, 977 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 116 insertions(+)) TF OiCS: Diff ( 4 files changed, 114 insertions(+))

modular-magician avatar Dec 09 '23 12:12 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 1053 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 6 files changed, 1053 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 116 insertions(+)) TF OiCS: Diff ( 4 files changed, 114 insertions(+))

modular-magician avatar Dec 09 '23 13:12 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 1053 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 6 files changed, 1053 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 116 insertions(+)) TF OiCS: Diff ( 4 files changed, 114 insertions(+))

modular-magician avatar Dec 09 '23 13:12 modular-magician

Tests analytics

Total tests: 3281 Passed tests 2944 Skipped tests: 334 Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccIntegrationConnectorsManagedZone_integrationConnectorsManagedZoneExample|TestAccIntegrationConnectorsManagedZone_integrationConnectorsManagedZoneExample_update|TestAccDataSourceGoogleServiceAccountIdToken_impersonation

Get to know how VCR tests work

modular-magician avatar Dec 09 '23 14:12 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccIntegrationConnectorsManagedZone_integrationConnectorsManagedZoneExample[Error message] [Debug log] TestAccIntegrationConnectorsManagedZone_integrationConnectorsManagedZoneExample_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Dec 09 '23 14:12 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 1053 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 6 files changed, 1053 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 116 insertions(+)) TF OiCS: Diff ( 4 files changed, 114 insertions(+))

modular-magician avatar Jan 03 '24 09:01 modular-magician

Tests analytics

Total tests: 12 Passed tests 10 Skipped tests: 0 Affected tests: 2

Click here to see the affected service packages
  • integrationconnectors

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccIntegrationConnectorsManagedZone_integrationConnectorsManagedZoneExample_update|TestAccIntegrationConnectorsManagedZone_integrationConnectorsManagedZoneExample

Get to know how VCR tests work

modular-magician avatar Jan 03 '24 09:01 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccIntegrationConnectorsManagedZone_integrationConnectorsManagedZoneExample_update[Error message] [Debug log] TestAccIntegrationConnectorsManagedZone_integrationConnectorsManagedZoneExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Jan 03 '24 09:01 modular-magician

/gcbrun

rileykarson avatar Mar 12 '24 16:03 rileykarson

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 1401 insertions(+), 6 deletions(-)) Terraform Beta: Diff ( 9 files changed, 1401 insertions(+), 6 deletions(-)) TF Conversion: Diff ( 2 files changed, 242 insertions(+)) TF OiCS: Diff ( 5 files changed, 125 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_integration_connectors_connection (9 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_integration_connectors_connection" "primary" {
  eventing_config {
    proxy_destination_config {
      destination {
        service_attachment = # value needed
      }
    }
  }
}

modular-magician avatar Mar 12 '24 17:03 modular-magician

Tests analytics

Total tests: 12 Passed tests: 9 Skipped tests: 0 Affected tests: 3

Click here to see the affected service packages
  • integrationconnectors

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionAdvancedExample|TestAccIntegrationConnectorsManagedZone_integrationConnectorsManagedZoneExample|TestAccIntegrationConnectorsManagedZone_integrationConnectorsManagedZoneExample_update

Get to know how VCR tests work

modular-magician avatar Mar 12 '24 17:03 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionAdvancedExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccIntegrationConnectorsManagedZone_integrationConnectorsManagedZoneExample[Error message] [Debug log] TestAccIntegrationConnectorsManagedZone_integrationConnectorsManagedZoneExample_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Mar 12 '24 17:03 modular-magician