magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Remove default addition to IAP message in encoder and decoder and add `enabled` field under IAP message for resource google_compute_region_backend_service

Open arnabadg-google opened this issue 1 year ago • 45 comments

Fixes internal issue b/310147789 fixes https://github.com/hashicorp/terraform-provider-google/issues/17494

Release Note Template for Downstream PRs (will be copied)

compute: fixed an issue regarding sending `enabled` field by default for null `iap` message  in `google_compute_region_backend_service`

arnabadg-google avatar Dec 05 '23 00:12 arnabadg-google

Hello! I am a robot. It looks like you are a: ~Community Contributor~ Googler ~Core Contributor~. Tests will run automatically.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician avatar Dec 05 '23 00:12 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-)) TF Conversion: Diff ( 1 file changed, 2 insertions(+), 8 deletions(-)) TF OiCS: Diff ( 4 files changed, 111 insertions(+))

modular-magician avatar Dec 05 '23 00:12 modular-magician

Tests analytics

Total tests: 3261 Passed tests 2852 Skipped tests: 332 Affected tests: 77

Action taken

Found 77 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRegionBackendService_withBackendAndIAP|TestAccComputeRegionUrlMap_ilbRouteUpdate|TestAccComputeRoute_routeIlbExample|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRegionBackendService_basic|TestAccComputeRegionBackendService_regionBackendServiceConnectionTrackingExample|TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample|TestAccComputeRegionBackendService_regionBackendServiceExternalIapExample|TestAccComputeRegionBackendService_regionBackendServiceExternalExample|TestAccComputeRegionBackendService_regionBackendServiceExternalWeightedExample|TestAccComputeRegionBackendService_regionBackendServiceIlbRoundRobinExample|TestAccComputeRegionBackendService_regionBackendServiceCacheExample|TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample|TestAccComputeRegionBackendService_regionBackendServiceBasicExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample|TestAccComputeRegionUrlMap_ilbPathUpdate|TestAccComputeRegionUrlMap_noPathRulesWithUpdate|TestAccComputeRegionUrlMap_advanced|TestAccComputeRegionUrlMap_update_path_matcher|TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample|TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample|TestAccComputeRegionUrlMap_regionUrlMapBasicExample|TestAccComputeRegionTargetTcpProxy_update|TestAccComputeRegionTargetTcpProxy_regionTargetTcpProxyBasicExample|TestAccComputeRegionTargetHttpsProxy_update|TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample|TestAccComputeRegionTargetHttpProxy_update|TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition|TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition|TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition|TestAccComputeRegionBackendServiceIamPolicyGenerated|TestAccComputeRegionBackendServiceIamMemberGenerated|TestAccComputeRegionBackendServiceIamBindingGenerated|TestAccComputeForwardingRule_forwardingRulePscRecreate|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6|TestAccComputeForwardingRule_forwardingRuleVpcPscExample|TestAccComputeRegionBackendService_ilbUpdateBasic|TestAccComputeRegionBackendService_withSecurityPolicy|TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate|TestAccComputeRegionBackendService_subsettingUpdate|TestAccComputeRegionBackendService_ilbUpdateFull|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeRegionUrlMap_defaultRouteAction_full_update|TestAccComputeRegionBackendService_withBackendInternalManaged|TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccDNSRecordSet_routingPolicy|TestAccIapWebRegionBackendServiceIamPolicyGenerated_withCondition|TestAccIapWebRegionBackendServiceIamMemberGenerated_withCondition|TestAccIapWebRegionBackendServiceIamPolicyGenerated|TestAccIapWebRegionBackendServiceIamBindingGenerated_withCondition|TestAccIapWebRegionBackendServiceIamMemberGenerated|TestAccIapWebRegionBackendServiceIamBindingGenerated

Get to know how VCR tests work

modular-magician avatar Dec 05 '23 01:12 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccComputeRegionUrlMap_ilbRouteUpdate[Debug log] TestAccComputeRegionBackendService_regionBackendServiceConnectionTrackingExample[Debug log] TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample[Debug log] TestAccComputeRegionBackendService_regionBackendServiceExternalIapExample[Debug log] TestAccComputeRegionBackendService_regionBackendServiceExternalExample[Debug log] TestAccComputeRegionBackendService_regionBackendServiceExternalWeightedExample[Debug log] TestAccComputeRegionBackendService_regionBackendServiceIlbRoundRobinExample[Debug log] TestAccComputeRegionBackendService_regionBackendServiceCacheExample[Debug log] TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample[Debug log] TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample[Debug log] TestAccComputeRegionUrlMap_ilbPathUpdate[Debug log] TestAccComputeRegionUrlMap_noPathRulesWithUpdate[Debug log] TestAccComputeRegionUrlMap_advanced[Debug log] TestAccComputeRegionUrlMap_update_path_matcher[Debug log] TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample[Debug log] TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample[Debug log] TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample[Debug log] TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample[Debug log] TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample[Debug log] TestAccComputeRegionUrlMap_regionUrlMapBasicExample[Debug log] TestAccComputeRegionTargetTcpProxy_update[Debug log] TestAccComputeRegionTargetTcpProxy_regionTargetTcpProxyBasicExample[Debug log] TestAccComputeRegionTargetHttpsProxy_update[Debug log] TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample[Debug log] TestAccComputeRegionTargetHttpProxy_update[Debug log] TestAccComputeForwardingRule_forwardingRuleL3DefaultExample[Debug log] TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate[Debug log] TestAccComputeForwardingRule_forwardingRuleExternallbExample[Debug log] TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log] TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log] TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log] TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample[Debug log] TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6[Debug log] TestAccComputeRegionBackendService_ilbUpdateBasic[Debug log] TestAccComputeRegionBackendService_withSecurityPolicy[Debug log] TestAccComputeRegionBackendService_ilbUpdateFull[Debug log] TestAccComputeRegionUrlMap_defaultRouteAction_full_update[Debug log] TestAccComputeRegionBackendService_withBackendInternalManaged[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccComputeRegionBackendService_withBackendAndIAP[Error message] [Debug log] TestAccComputeRoute_routeIlbExample[Error message] [Debug log] TestAccComputeRoute_routeIlbVipExample[Error message] [Debug log] TestAccComputeRegionBackendService_basic[Error message] [Debug log] TestAccComputeRegionBackendService_regionBackendServiceBasicExample[Error message] [Debug log] TestAccComputePacketMirroring_computePacketMirroringFullExample[Error message] [Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Error message] [Debug log] TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition[Error message] [Debug log] TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition[Error message] [Debug log] TestAccComputeRegionBackendServiceIamPolicyGenerated[Error message] [Debug log] TestAccComputeRegionBackendServiceIamMemberGenerated[Error message] [Debug log] TestAccComputeRegionBackendServiceIamBindingGenerated[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRulePscRecreate[Error message] [Debug log] TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleInternallbExample[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example[Error message] [Debug log] TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleVpcPscExample[Error message] [Debug log] TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate[Error message] [Debug log] TestAccComputeRegionBackendService_subsettingUpdate[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Error message] [Debug log] TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol[Error message] [Debug log] TestAccComputeRegionBackendService_withBackendInternal[Error message] [Debug log] TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate[Error message] [Debug log] TestAccComputeRegionBackendService_withBackendMultiNic[Error message] [Debug log] TestAccDNSRecordSet_routingPolicy[Error message] [Debug log] TestAccIapWebRegionBackendServiceIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccIapWebRegionBackendServiceIamMemberGenerated_withCondition[Error message] [Debug log] TestAccIapWebRegionBackendServiceIamPolicyGenerated[Error message] [Debug log] TestAccIapWebRegionBackendServiceIamBindingGenerated_withCondition[Error message] [Debug log] TestAccIapWebRegionBackendServiceIamMemberGenerated[Error message] [Debug log] TestAccIapWebRegionBackendServiceIamBindingGenerated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Dec 05 '23 03:12 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-)) TF Conversion: Diff ( 1 file changed, 2 insertions(+), 8 deletions(-)) TF OiCS: Diff ( 4 files changed, 111 insertions(+))

modular-magician avatar Dec 05 '23 17:12 modular-magician

Tests analytics

Total tests: 3262 Passed tests 2891 Skipped tests: 332 Affected tests: 39

Action taken

Found 39 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRegionBackendService_withBackendAndIAP|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeRegionBackendService_basic|TestAccComputeRegionBackendService_subsettingUpdate|TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate|TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_regionBackendServiceBasicExample|TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRoute_routeIlbExample|TestAccComputeForwardingRule_forwardingRulePscRecreate|TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate|TestAccComputeForwardingRule_forwardingRuleVpcPscExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate|TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample|TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition|TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition|TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition|TestAccComputeRegionBackendServiceIamMemberGenerated|TestAccComputeRegionBackendServiceIamPolicyGenerated|TestAccComputeRegionBackendServiceIamBindingGenerated|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccDNSRecordSet_routingPolicy|TestAccIapWebRegionBackendServiceIamBindingGenerated|TestAccIapWebRegionBackendServiceIamBindingGenerated_withCondition|TestAccIapWebRegionBackendServiceIamMemberGenerated|TestAccIapWebRegionBackendServiceIamMemberGenerated_withCondition|TestAccIapWebRegionBackendServiceIamPolicyGenerated_withCondition|TestAccIapWebRegionBackendServiceIamPolicyGenerated

Get to know how VCR tests work

modular-magician avatar Dec 05 '23 19:12 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccComputeRegionBackendService_withBackendAndIAP[Error message] [Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Error message] [Debug log] TestAccComputeRegionBackendService_basic[Error message] [Debug log] TestAccComputeRegionBackendService_subsettingUpdate[Error message] [Debug log] TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate[Error message] [Debug log] TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate[Error message] [Debug log] TestAccComputeRegionBackendService_withBackendMultiNic[Error message] [Debug log] TestAccComputePacketMirroring_computePacketMirroringFullExample[Error message] [Debug log] TestAccComputeRegionBackendService_withBackendInternal[Error message] [Debug log] TestAccComputeRegionBackendService_regionBackendServiceBasicExample[Error message] [Debug log] TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol[Error message] [Debug log] TestAccComputeRoute_routeIlbVipExample[Error message] [Debug log] TestAccComputeRoute_routeIlbExample[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRulePscRecreate[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleVpcPscExample[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Error message] [Debug log] TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleInternallbExample[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example[Error message] [Debug log] TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample[Error message] [Debug log] TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition[Error message] [Debug log] TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition[Error message] [Debug log] TestAccComputeRegionBackendServiceIamMemberGenerated[Error message] [Debug log] TestAccComputeRegionBackendServiceIamPolicyGenerated[Error message] [Debug log] TestAccComputeRegionBackendServiceIamBindingGenerated[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Error message] [Debug log] TestAccDNSRecordSet_routingPolicy[Error message] [Debug log] TestAccIapWebRegionBackendServiceIamBindingGenerated[Error message] [Debug log] TestAccIapWebRegionBackendServiceIamBindingGenerated_withCondition[Error message] [Debug log] TestAccIapWebRegionBackendServiceIamMemberGenerated[Error message] [Debug log] TestAccIapWebRegionBackendServiceIamMemberGenerated_withCondition[Error message] [Debug log] TestAccIapWebRegionBackendServiceIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccIapWebRegionBackendServiceIamPolicyGenerated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Dec 05 '23 19:12 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-)) TF Conversion: Diff ( 1 file changed, 2 insertions(+), 8 deletions(-)) TF OiCS: Diff ( 4 files changed, 111 insertions(+))

modular-magician avatar Dec 27 '23 05:12 modular-magician

Tests analytics

Total tests: 857 Passed tests 760 Skipped tests: 65 Affected tests: 32

Click here to see the affected service packages
  • compute

Action taken

Found 32 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRegionBackendService_withBackendAndIAP|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol|TestAccComputeRegionBackendService_basic|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_regionBackendServiceBasicExample|TestAccComputeRegionBackendService_subsettingUpdate|TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate|TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeForwardingRule_forwardingRulePscRecreate|TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate|TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example|TestAccComputeForwardingRule_forwardingRuleVpcPscExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition|TestAccComputeRoute_routeIlbExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition|TestAccComputeRegionBackendServiceIamPolicyGenerated|TestAccComputeRegionBackendServiceIamMemberGenerated|TestAccComputeRegionBackendServiceIamBindingGenerated|TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample|TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate

Get to know how VCR tests work

modular-magician avatar Dec 27 '23 05:12 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-)) TF Conversion: Diff ( 1 file changed, 2 insertions(+), 8 deletions(-)) TF OiCS: Diff ( 4 files changed, 111 insertions(+))

modular-magician avatar Dec 27 '23 19:12 modular-magician

Tests analytics

Total tests: 857 Passed tests 760 Skipped tests: 65 Affected tests: 32

Click here to see the affected service packages
  • compute

Action taken

Found 32 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRegionBackendService_withBackendAndIAP|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRoute_routeIlbExample|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_subsettingUpdate|TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol|TestAccComputeRegionBackendService_basic|TestAccComputeRegionBackendService_regionBackendServiceBasicExample|TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate|TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate|TestAccComputeForwardingRule_forwardingRulePscRecreate|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate|TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example|TestAccComputeForwardingRule_forwardingRuleVpcPscExample|TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeRegionBackendServiceIamMemberGenerated|TestAccComputeRegionBackendServiceIamBindingGenerated|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample|TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition|TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition|TestAccComputeRegionBackendServiceIamPolicyGenerated|TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample

Get to know how VCR tests work

modular-magician avatar Dec 27 '23 19:12 modular-magician

VCR issue should be fixed by https://github.com/GoogleCloudPlatform/magic-modules/pull/9722.

/gcbrun

shuyama1 avatar Dec 28 '23 17:12 shuyama1

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-)) TF Conversion: Diff ( 1 file changed, 2 insertions(+), 8 deletions(-)) TF OiCS: Diff ( 4 files changed, 111 insertions(+))

modular-magician avatar Dec 28 '23 17:12 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-)) TF Conversion: Diff ( 1 file changed, 2 insertions(+), 8 deletions(-)) TF OiCS: Diff ( 4 files changed, 111 insertions(+))

modular-magician avatar Dec 28 '23 17:12 modular-magician

/gcbrun

shuyama1 avatar Dec 28 '23 17:12 shuyama1

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-)) TF Conversion: Diff ( 1 file changed, 2 insertions(+), 8 deletions(-)) TF OiCS: Diff ( 4 files changed, 111 insertions(+))

modular-magician avatar Dec 28 '23 17:12 modular-magician

Tests analytics

Total tests: 858 Passed tests 761 Skipped tests: 65 Affected tests: 32

Click here to see the affected service packages
  • compute

Action taken

Found 32 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRegionBackendService_withBackendAndIAP|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeRoute_routeIlbExample|TestAccComputeRoute_routeIlbVipExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeRegionBackendService_regionBackendServiceBasicExample|TestAccComputeRegionBackendService_subsettingUpdate|TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate|TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol|TestAccComputeRegionBackendService_basic|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate|TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample|TestAccComputeForwardingRule_forwardingRulePscRecreate|TestAccComputeForwardingRule_forwardingRuleVpcPscExample|TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeRegionBackendServiceIamMemberGenerated|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeRegionBackendServiceIamBindingGenerated|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample|TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition|TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition|TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition|TestAccComputeRegionBackendServiceIamPolicyGenerated

Get to know how VCR tests work

modular-magician avatar Dec 28 '23 17:12 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccComputeRegionBackendService_withBackendAndIAP[Error message] [Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Error message] [Debug log] TestAccComputeRoute_routeIlbExample[Error message] [Debug log] TestAccComputeRoute_routeIlbVipExample[Error message] [Debug log] TestAccComputePacketMirroring_computePacketMirroringFullExample[Error message] [Debug log] TestAccComputeRegionBackendService_regionBackendServiceBasicExample[Error message] [Debug log] TestAccComputeRegionBackendService_subsettingUpdate[Error message] [Debug log] TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate[Error message] [Debug log] TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate[Error message] [Debug log] TestAccComputeRegionBackendService_withBackendMultiNic[Error message] [Debug log] TestAccComputeRegionBackendService_withBackendInternal[Error message] [Debug log] TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol[Error message] [Debug log] TestAccComputeRegionBackendService_basic[Error message] [Debug log] TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRulePscRecreate[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleVpcPscExample[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleInternallbExample[Error message] [Debug log] TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Error message] [Debug log] TestAccComputeRegionBackendServiceIamMemberGenerated[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Error message] [Debug log] TestAccComputeRegionBackendServiceIamBindingGenerated[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample[Error message] [Debug log] TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition[Error message] [Debug log] TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition[Error message] [Debug log] TestAccComputeRegionBackendServiceIamPolicyGenerated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Dec 28 '23 17:12 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-)) TF Conversion: Diff ( 1 file changed, 2 insertions(+), 8 deletions(-)) TF OiCS: Diff ( 4 files changed, 111 insertions(+))

modular-magician avatar Dec 29 '23 06:12 modular-magician

Tests analytics

Total tests: 858 Passed tests 761 Skipped tests: 65 Affected tests: 32

Click here to see the affected service packages
  • compute

Action taken

Found 32 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRegionBackendService_withBackendAndIAP|TestAccComputeRegionBackendService_subsettingUpdate|TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate|TestAccComputeRegionBackendService_regionBackendServiceBasicExample|TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeRegionBackendService_basic|TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample|TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition|TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition|TestAccComputeRegionBackendServiceIamPolicyGenerated|TestAccComputeRegionBackendServiceIamMemberGenerated|TestAccComputeRegionBackendServiceIamBindingGenerated|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate|TestAccComputeForwardingRule_forwardingRulePscRecreate|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample|TestAccComputeForwardingRule_forwardingRuleVpcPscExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate|TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeRoute_routeIlbExample|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample

Get to know how VCR tests work

modular-magician avatar Dec 29 '23 06:12 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccComputeRegionBackendService_withBackendAndIAP[Error message] [Debug log] TestAccComputeRegionBackendService_subsettingUpdate[Error message] [Debug log] TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate[Error message] [Debug log] TestAccComputeRegionBackendService_regionBackendServiceBasicExample[Error message] [Debug log] TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate[Error message] [Debug log] TestAccComputeRegionBackendService_withBackendMultiNic[Error message] [Debug log] TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol[Error message] [Debug log] TestAccComputeRegionBackendService_withBackendInternal[Error message] [Debug log] TestAccComputePacketMirroring_computePacketMirroringFullExample[Error message] [Debug log] TestAccComputeRegionBackendService_basic[Error message] [Debug log] TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample[Error message] [Debug log] TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition[Error message] [Debug log] TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition[Error message] [Debug log] TestAccComputeRegionBackendServiceIamPolicyGenerated[Error message] [Debug log] TestAccComputeRegionBackendServiceIamMemberGenerated[Error message] [Debug log] TestAccComputeRegionBackendServiceIamBindingGenerated[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRulePscRecreate[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleInternallbExample[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleVpcPscExample[Error message] [Debug log] TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Error message] [Debug log] TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Error message] [Debug log] TestAccComputeRoute_routeIlbExample[Error message] [Debug log] TestAccComputeRoute_routeIlbVipExample[Error message] [Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Dec 29 '23 06:12 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 3 files changed, 63 insertions(+), 9 deletions(-)) TF Conversion: Diff ( 1 file changed, 2 insertions(+), 8 deletions(-)) TF OiCS: Diff ( 4 files changed, 111 insertions(+))

modular-magician avatar Jan 16 '24 17:01 modular-magician

Tests analytics

Total tests: 865 Passed tests 769 Skipped tests: 64 Affected tests: 32

Click here to see the affected service packages
  • compute

Action taken

Found 32 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRegionBackendService_withBackendAndIAP|TestAccComputeRoute_routeIlbExample|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeRegionBackendService_subsettingUpdate|TestAccComputeRegionBackendService_regionBackendServiceBasicExample|TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate|TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate|TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionBackendService_basic|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeForwardingRule_forwardingRulePscRecreate|TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate|TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate|TestAccComputeForwardingRule_forwardingRuleVpcPscExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition|TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition|TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition|TestAccComputeRegionBackendServiceIamPolicyGenerated|TestAccComputeRegionBackendServiceIamMemberGenerated|TestAccComputeRegionBackendServiceIamBindingGenerated

Get to know how VCR tests work

modular-magician avatar Jan 16 '24 17:01 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccComputeRegionBackendService_withBackendAndIAP[Error message] [Debug log] TestAccComputeRoute_routeIlbExample[Error message] [Debug log] TestAccComputeRoute_routeIlbVipExample[Error message] [Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Error message] [Debug log] TestAccComputeRegionBackendService_subsettingUpdate[Error message] [Debug log] TestAccComputeRegionBackendService_regionBackendServiceBasicExample[Error message] [Debug log] TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate[Error message] [Debug log] TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate[Error message] [Debug log] TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol[Error message] [Debug log] TestAccComputeRegionBackendService_withBackendMultiNic[Error message] [Debug log] TestAccComputeRegionBackendService_basic[Error message] [Debug log] TestAccComputeRegionBackendService_withBackendInternal[Error message] [Debug log] TestAccComputePacketMirroring_computePacketMirroringFullExample[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRulePscRecreate[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample[Error message] [Debug log] TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleVpcPscExample[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleInternallbExample[Error message] [Debug log] TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Error message] [Debug log] TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition[Error message] [Debug log] TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition[Error message] [Debug log] TestAccComputeRegionBackendServiceIamPolicyGenerated[Error message] [Debug log] TestAccComputeRegionBackendServiceIamMemberGenerated[Error message] [Debug log] TestAccComputeRegionBackendServiceIamBindingGenerated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Jan 16 '24 18:01 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 1 insertion(+), 10 deletions(-)) Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 5 deletions(-)) TF Conversion: Diff ( 1 file changed, 1 insertion(+), 5 deletions(-))

modular-magician avatar Jan 23 '24 02:01 modular-magician

Tests analytics

Total tests: 866 Passed tests 733 Skipped tests: 64 Affected tests: 69

Click here to see the affected service packages
  • compute

Action taken

Found 69 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRegionBackendService_withBackendAndIAP|TestAccComputeRegionUrlMap_defaultRouteAction_full_update|TestAccComputeRegionTargetHttpProxy_update|TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample|TestAccComputeRegionTargetTcpProxy_regionTargetTcpProxyBasicExample|TestAccComputeRegionTargetTcpProxy_update|TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample|TestAccComputeRegionTargetHttpsProxy_update|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRoute_routeIlbExample|TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol|TestAccComputeRegionBackendService_withSecurityPolicy|TestAccComputeRegionBackendService_subsettingUpdate|TestAccComputeRegionBackendService_basic|TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate|TestAccComputeRegionBackendService_ilbUpdateBasic|TestAccComputeRegionBackendService_ilbUpdateFull|TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate|TestAccComputeRegionBackendService_regionBackendServiceConnectionTrackingExample|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionBackendService_withBackendInternalManaged|TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample|TestAccComputeRegionBackendService_regionBackendServiceExternalExample|TestAccComputeRegionBackendService_regionBackendServiceExternalWeightedExample|TestAccComputeRegionBackendService_regionBackendServiceIlbRoundRobinExample|TestAccComputeRegionBackendService_regionBackendServiceCacheExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeRegionBackendService_regionBackendServiceBasicExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition|TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition|TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition|TestAccComputeRegionBackendServiceIamPolicyGenerated|TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate|TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate|TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6|TestAccComputeRegionBackendServiceIamMemberGenerated|TestAccComputeRegionBackendServiceIamBindingGenerated|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate|TestAccComputeForwardingRule_forwardingRulePscRecreate|TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample|TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example|TestAccComputeForwardingRule_forwardingRuleVpcPscExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample|TestAccComputeRegionUrlMap_ilbRouteUpdate|TestAccComputeRegionUrlMap_ilbPathUpdate|TestAccComputeRegionUrlMap_noPathRulesWithUpdate|TestAccComputeRegionUrlMap_advanced|TestAccComputeRegionUrlMap_update_path_matcher|TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeRegionUrlMap_regionUrlMapBasicExample|TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample

Get to know how VCR tests work

modular-magician avatar Jan 23 '24 02:01 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccComputeRegionUrlMap_defaultRouteAction_full_update[Debug log] TestAccComputeRegionTargetHttpProxy_update[Debug log] TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample[Debug log] TestAccComputeRegionTargetTcpProxy_regionTargetTcpProxyBasicExample[Debug log] TestAccComputeRegionTargetTcpProxy_update[Debug log] TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample[Debug log] TestAccComputeRegionTargetHttpsProxy_update[Debug log] TestAccComputeRegionBackendService_withSecurityPolicy[Debug log] TestAccComputeRegionBackendService_ilbUpdateBasic[Debug log] TestAccComputeRegionBackendService_ilbUpdateFull[Debug log] TestAccComputeRegionBackendService_regionBackendServiceConnectionTrackingExample[Debug log] TestAccComputeRegionBackendService_withBackendInternalManaged[Debug log] TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample[Debug log] TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample[Debug log] TestAccComputeRegionBackendService_regionBackendServiceExternalExample[Debug log] TestAccComputeRegionBackendService_regionBackendServiceExternalWeightedExample[Debug log] TestAccComputeRegionBackendService_regionBackendServiceIlbRoundRobinExample[Debug log] TestAccComputeRegionBackendService_regionBackendServiceCacheExample[Debug log] TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate[Debug log] TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6[Debug log] TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample[Debug log] TestAccComputeForwardingRule_forwardingRuleL3DefaultExample[Debug log] TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log] TestAccComputeForwardingRule_forwardingRuleExternallbExample[Debug log] TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log] TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log] TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample[Debug log] TestAccComputeRegionUrlMap_ilbRouteUpdate[Debug log] TestAccComputeRegionUrlMap_ilbPathUpdate[Debug log] TestAccComputeRegionUrlMap_noPathRulesWithUpdate[Debug log] TestAccComputeRegionUrlMap_advanced[Debug log] TestAccComputeRegionUrlMap_update_path_matcher[Debug log] TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample[Debug log] TestAccComputeRegionUrlMap_regionUrlMapBasicExample[Debug log] TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample[Debug log] TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample[Debug log] TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccComputeRegionBackendService_withBackendAndIAP[Error message] [Debug log] TestAccComputeRoute_routeIlbVipExample[Error message] [Debug log] TestAccComputeRoute_routeIlbExample[Error message] [Debug log] TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol[Error message] [Debug log] TestAccComputeRegionBackendService_subsettingUpdate[Error message] [Debug log] TestAccComputeRegionBackendService_basic[Error message] [Debug log] TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate[Error message] [Debug log] TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate[Error message] [Debug log] TestAccComputeRegionBackendService_withBackendMultiNic[Error message] [Debug log] TestAccComputeRegionBackendService_withBackendInternal[Error message] [Debug log] TestAccComputePacketMirroring_computePacketMirroringFullExample[Error message] [Debug log] TestAccComputeRegionBackendService_regionBackendServiceBasicExample[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Error message] [Debug log] TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition[Error message] [Debug log] TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition[Error message] [Debug log] TestAccComputeRegionBackendServiceIamPolicyGenerated[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate[Error message] [Debug log] TestAccComputeRegionBackendServiceIamMemberGenerated[Error message] [Debug log] TestAccComputeRegionBackendServiceIamBindingGenerated[Error message] [Debug log] TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRulePscRecreate[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleVpcPscExample[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleInternallbExample[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Error message] [Debug log] TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Error message] [Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Jan 23 '24 03:01 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 26 insertions(+), 11 deletions(-)) Terraform Beta: Diff ( 2 files changed, 26 insertions(+), 11 deletions(-)) TF Conversion: Diff ( 1 file changed, 11 insertions(+), 11 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_backend_service (116 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_backend_service" "primary" {
  iap {
    enabled = # value needed
  }
}

modular-magician avatar Jan 23 '24 23:01 modular-magician

Tests analytics

Total tests: 867 Passed tests 770 Skipped tests: 64 Affected tests: 33

Click here to see the affected service packages
  • compute

Action taken

Found 33 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRegionBackendService_withBackendAndIAP|TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeRoute_routeIlbExample|TestAccComputeRoute_routeIlbVipExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol|TestAccComputeRegionBackendService_basic|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_regionBackendServiceExternalIapExample|TestAccComputeRegionBackendService_regionBackendServiceBasicExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeRegionBackendService_subsettingUpdate|TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate|TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition|TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition|TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition|TestAccComputeRegionBackendServiceIamMemberGenerated|TestAccComputeRegionBackendServiceIamBindingGenerated|TestAccComputeRegionBackendServiceIamPolicyGenerated|TestAccComputeForwardingRule_forwardingRulePscRecreate|TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate|TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example|TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample|TestAccComputeForwardingRule_forwardingRuleVpcPscExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample

Get to know how VCR tests work

modular-magician avatar Jan 24 '24 00:01 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccComputeRegionBackendService_withBackendAndIAP[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Error message] [Debug log] TestAccComputeRoute_routeIlbExample[Error message] [Debug log] TestAccComputeRoute_routeIlbVipExample[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Error message] [Debug log] TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Error message] [Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Error message] [Debug log] TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol[Error message] [Debug log] TestAccComputeRegionBackendService_basic[Error message] [Debug log] TestAccComputeRegionBackendService_withBackendInternal[Error message] [Debug log] TestAccComputeRegionBackendService_regionBackendServiceExternalIapExample[Error message] [Debug log] TestAccComputeRegionBackendService_regionBackendServiceBasicExample[Error message] [Debug log] TestAccComputePacketMirroring_computePacketMirroringFullExample[Error message] [Debug log] TestAccComputeRegionBackendService_subsettingUpdate[Error message] [Debug log] TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate[Error message] [Debug log] TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate[Error message] [Debug log] TestAccComputeRegionBackendService_withBackendMultiNic[Error message] [Debug log] TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition[Error message] [Debug log] TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition[Error message] [Debug log] TestAccComputeRegionBackendServiceIamMemberGenerated[Error message] [Debug log] TestAccComputeRegionBackendServiceIamBindingGenerated[Error message] [Debug log] TestAccComputeRegionBackendServiceIamPolicyGenerated[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRulePscRecreate[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate[Error message] [Debug log] TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleVpcPscExample[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleInternallbExample[Error message] [Debug log] TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Jan 24 '24 00:01 modular-magician