magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

feat(vertexai): Support google_vertex_ai_deployment_resource_pool

Open shotarok opened this issue 1 year ago • 13 comments

Fixes https://github.com/hashicorp/terraform-provider-google/issues/16561

Release Note Template for Downstream PRs (will be copied)

`google_vertex_ai_deployment_resource_pool`

I confirmed TestAccVertexAIDeploymentResourcePool_vertexAiDeploymentResourcePoolExample succeeded without errors by running the test on a local machine.

shotarok avatar Nov 24 '23 19:11 shotarok

Hello! I am a robot. It looks like you are a: Community Contributor ~Googler~ ~Core Contributor~. Tests will require approval to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician avatar Nov 24 '23 19:11 modular-magician

@rileykarson Hello 👋 Could you approve the cloud build jobs to run acceptance tests?

shotarok avatar Nov 28 '23 19:11 shotarok

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 1146 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 5 files changed, 1146 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 239 insertions(+)) TF OiCS: Diff ( 4 files changed, 120 insertions(+))

modular-magician avatar Nov 28 '23 19:11 modular-magician

Tests analytics

Total tests: 3238 Passed tests 2905 Skipped tests: 331 Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccHealthcareDatasetIamPolicy|TestAccVertexAIDeploymentResourcePool_vertexAiDeploymentResourcePoolExample

Get to know how VCR tests work

modular-magician avatar Nov 28 '23 20:11 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccHealthcareDatasetIamPolicy[Debug log] TestAccVertexAIDeploymentResourcePool_vertexAiDeploymentResourcePoolExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test

modular-magician avatar Nov 28 '23 20:11 modular-magician

@rileykarson Hello 👋 Sorry for the late response. I updated the code based on your feedback. According to the API doc, all fields are immutable. Therefore, I didn't add a hand-written test for updatable fields. Please let me know if you have a concern. Thanks!

shotarok avatar Dec 12 '23 19:12 shotarok

@rileykarson Happy New Year 👋 When you have time, could you review this PR? Thanks

shotarok avatar Jan 02 '24 16:01 shotarok

@rileykarson Hello 👋 When you have time, could you review this PR? Thanks!

shotarok avatar Jan 17 '24 18:01 shotarok

@rileykarson Hello 👋 If this PR looks good, could you approve the cloud build job? Thanks

shotarok avatar Feb 16 '24 07:02 shotarok

Sorry about the delay! Losing against my email 😅

Running build

rileykarson avatar Feb 16 '24 19:02 rileykarson

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 1106 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 5 files changed, 1106 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 215 insertions(+)) TF OiCS: Diff ( 4 files changed, 120 insertions(+))

modular-magician avatar Feb 16 '24 19:02 modular-magician

Tests analytics

Total tests: 46 Passed tests 45 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages
  • vertexai

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccVertexAIDeploymentResourcePool_vertexAiDeploymentResourcePoolExample

Get to know how VCR tests work

modular-magician avatar Feb 16 '24 19:02 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccVertexAIDeploymentResourcePool_vertexAiDeploymentResourcePoolExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test

modular-magician avatar Feb 16 '24 19:02 modular-magician

@rileykarson Hello 👋 When you have time, could you review the code? Please let me know if merging the latest main branch into this development branch is necessary. Thanks!

shotarok avatar Mar 27 '24 18:03 shotarok