magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Add `cluster_network_performance_config` field to `google_container_cluster` resource

Open SarahFrench opened this issue 1 year ago • 8 comments

Supersedes https://github.com/GoogleCloudPlatform/magic-modules/pull/8841

Release Note Template for Downstream PRs (will be copied)

container: added the `cluster_network_performance_config` field to `google_container_cluster` resource

SarahFrench avatar Nov 20 '23 19:11 SarahFrench

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 122 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 3 files changed, 122 insertions(+), 2 deletions(-))

modular-magician avatar Nov 20 '23 19:11 modular-magician

Tests analytics

Total tests: 3237 Passed tests 2905 Skipped tests: 330 Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerCluster_withClusterNetworkPerformanceConfig|TestAccDataSourceGoogleServiceAccountAccessToken_basic

Get to know how VCR tests work

modular-magician avatar Nov 20 '23 20:11 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccDataSourceGoogleServiceAccountAccessToken_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccContainerCluster_withClusterNetworkPerformanceConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Nov 20 '23 20:11 modular-magician

Test failure:

    Error: googleapi: Error 400: This operation will exceed max secondary ranges per subnetwork (30) for subnet "default", consider reusing existing secondary ranges or use a different subnetwork.

SarahFrench avatar Nov 21 '23 09:11 SarahFrench

/gcbrun

SarahFrench avatar Nov 30 '23 22:11 SarahFrench

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 122 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 3 files changed, 122 insertions(+), 2 deletions(-))

modular-magician avatar Nov 30 '23 22:11 modular-magician

Tests analytics

Total tests: 3255 Passed tests 2922 Skipped tests: 331 Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerCluster_withClusterNetworkPerformanceConfig|TestAccGKEHub2Fleet_gkehubFleetBasicExample_update

Get to know how VCR tests work

modular-magician avatar Nov 30 '23 23:11 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccGKEHub2Fleet_gkehubFleetBasicExample_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$ TestAccGKEHub2Fleet_gkehubFleetBasicExample_update[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccContainerCluster_withClusterNetworkPerformanceConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Nov 30 '23 23:11 modular-magician