magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Testing: Make a breaking change

Open trodge opened this issue 1 year ago • 24 comments

Release Note Template for Downstream PRs (will be copied)

This should never be released

trodge avatar Nov 06 '23 21:11 trodge

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 36 insertions(+)) Terraform Beta: Diff ( 2 files changed, 36 insertions(+)) TF Conversion: Diff ( 1 file changed, 10 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_access_level (17 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_access_level" "primary" {
  breaking_field = # value needed
}

modular-magician avatar Nov 06 '23 21:11 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 36 insertions(+)) Terraform Beta: Diff ( 2 files changed, 36 insertions(+)) TF Conversion: Diff ( 1 file changed, 10 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_access_level (17 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_access_level" "primary" {
  breaking_field = # value needed
}

trodge avatar Nov 06 '23 21:11 trodge

Tests analytics

Total tests: 3204 Passed tests 2878 Skipped tests: 323 Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAccessContextManager|TestAccIAM2AccessBoundaryPolicy|TestAccLoggingProjectSink_updatePreservesCustomWriter

Get to know how VCR tests work

modular-magician avatar Nov 06 '23 22:11 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 36 insertions(+)) Terraform Beta: Diff ( 2 files changed, 36 insertions(+)) TF Conversion: Diff ( 1 file changed, 10 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_access_level (17 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_access_level" "primary" {
  breaking_field = # value needed
}

trodge avatar Nov 06 '23 22:11 trodge

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccAccessContextManager[Error message] [Debug log] TestAccIAM2AccessBoundaryPolicy[Error message] [Debug log] TestAccLoggingProjectSink_updatePreservesCustomWriter[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Nov 06 '23 22:11 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 36 insertions(+)) Terraform Beta: Diff ( 2 files changed, 36 insertions(+)) TF Conversion: Diff ( 1 file changed, 10 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_access_level (17 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_access_level" "primary" {
  breaking_field = # value needed
}

trodge avatar Nov 07 '23 00:11 trodge

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 36 insertions(+)) Terraform Beta: Diff ( 2 files changed, 36 insertions(+)) TF Conversion: Diff ( 1 file changed, 10 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_access_level (17 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_access_level" "primary" {
  breaking_field = # value needed
}

trodge avatar Nov 07 '23 00:11 trodge

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field description changed from optional to required on google_access_context_manager_access_level - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-))

modular-magician avatar Nov 14 '23 00:11 modular-magician

Tests analytics

Total tests: 3225 Passed tests 2894 Skipped tests: 329 Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAccessContextManager|TestAccIAM2AccessBoundaryPolicy

Get to know how VCR tests work

modular-magician avatar Nov 14 '23 01:11 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccAccessContextManager[Error message] [Debug log] TestAccIAM2AccessBoundaryPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Nov 14 '23 02:11 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected The following breaking change(s) were detected within your pull request.

  • Field description changed from optional to required on google_access_context_manager_access_level - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-changelabel can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-))

trodge avatar Dec 01 '23 23:12 trodge

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field description changed from optional to required on google_access_context_manager_access_level - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-changelabel can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-))

trodge avatar Dec 04 '23 23:12 trodge

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field description changed from optional to required on google_access_context_manager_access_level - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-changelabel can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-))

trodge avatar Dec 04 '23 23:12 trodge

/gcbrun

trodge avatar Dec 05 '23 00:12 trodge

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field description changed from optional to required on google_access_context_manager_access_level - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-))

modular-magician avatar Dec 05 '23 00:12 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field description changed from optional to required on google_access_context_manager_access_level - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-changelabel can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-))

trodge avatar Dec 05 '23 00:12 trodge

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field description changed from optional to required on google_access_context_manager_access_level - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-changelabel can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-))

trodge avatar Dec 05 '23 01:12 trodge

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field description changed from optional to required on google_access_context_manager_access_level - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-changelabel can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-))

trodge avatar Dec 05 '23 01:12 trodge

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field description changed from optional to required on google_access_context_manager_access_level - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-changelabel can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-))

trodge avatar Dec 05 '23 01:12 trodge

Tests analytics

Total tests: 3260 Passed tests 2926 Skipped tests: 332 Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAccessContextManager|TestAccIAM2AccessBoundaryPolicy

Get to know how VCR tests work

modular-magician avatar Dec 05 '23 01:12 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccAccessContextManager[Error message] [Debug log] TestAccIAM2AccessBoundaryPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Dec 05 '23 01:12 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field description changed from optional to required on google_access_context_manager_access_level - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-changelabel can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-))

trodge avatar Dec 08 '23 19:12 trodge

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field description changed from optional to required on google_access_context_manager_access_level - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-))

trodge avatar Dec 13 '23 19:12 trodge

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field description changed from optional to required on google_access_context_manager_access_level - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-))

trodge avatar Dec 14 '23 18:12 trodge