magic-modules
magic-modules copied to clipboard
firebaserules_release: Document how to create a release for non-default Firestore databases
Add additional samples to explain how non-default Firestore database can be generated.
Fixes https://github.com/hashicorp/terraform-provider-google/issues/16324
Release Note Template for Downstream PRs (will be copied)
firebaserules_release: Added example for a release to a non-default Firestore database.
Hello! I am a robot. It looks like you are a: Community Contributor ~Googler~ ~Core Contributor~. Tests will require approval to run.
@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 1 file changed, 41 insertions(+)) Terraform Beta: Diff ( 2 files changed, 109 insertions(+))
Tests analytics
Total tests: 3171
Passed tests 2849
Skipped tests: 320
Affected tests: 2
Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataprocJobIamPolicy|TestAccFirebaserulesRelease_FirestoreSecondaryReleaseHandWritten
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocJobIamPolicy
[Debug log]
Rerun these tests in REPLAYING mode to catch issues
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccFirebaserulesRelease_FirestoreSecondaryReleaseHandWritten
[Error message] [Debug log]
$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 1 file changed, 41 insertions(+)) Terraform Beta: Diff ( 2 files changed, 109 insertions(+))
Tests analytics
Total tests: 3173
Passed tests 2852
Skipped tests: 319
Affected tests: 2
Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataprocJobIamPolicy|TestAccFirebaserulesRelease_FirestoreSecondaryReleaseHandWritten
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocJobIamPolicy
[Debug log]
Rerun these tests in REPLAYING mode to catch issues
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccFirebaserulesRelease_FirestoreSecondaryReleaseHandWritten
[Error message] [Debug log]
$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test
Hmm, I don't know how to run those types of tests locally and unfortunately don't have access to the error logs ...
@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders
to disable these notifications.
Closing as stale- if we make the changes in https://github.com/GoogleCloudPlatform/magic-modules/pull/9323#discussion_r1412358929 we should be able to move it forward.