magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Add an IPV6 example-derived test for `google_firestore_instance`

Open SarahFrench opened this issue 1 year ago • 9 comments

Relates to https://github.com/hashicorp/terraform-provider-google/issues/16299

This PR adds a new test to the google_filestore_instance resource that shows how a permadiff occurs when setting modes = ["MODE_IPV6"]

Release Note Template for Downstream PRs (will be copied)


SarahFrench avatar Oct 19 '23 13:10 SarahFrench

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 45 insertions(+)) Terraform Beta: Diff ( 1 file changed, 45 insertions(+)) TF OiCS: Diff ( 4 files changed, 116 insertions(+))

modular-magician avatar Oct 19 '23 13:10 modular-magician

Tests analytics

Total tests: 3163 Passed tests 2844 Skipped tests: 318 Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFilestoreInstance_filestoreInstanceBasicIpv6Example

Get to know how VCR tests work

modular-magician avatar Oct 19 '23 15:10 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccFilestoreInstance_filestoreInstanceBasicIpv6Example[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Oct 19 '23 15:10 modular-magician

Testing if this is still an issue: /gcbrun

SarahFrench avatar Dec 18 '23 17:12 SarahFrench

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 45 insertions(+)) Terraform Beta: Diff ( 1 file changed, 45 insertions(+)) TF OiCS: Diff ( 4 files changed, 116 insertions(+))

modular-magician avatar Dec 18 '23 17:12 modular-magician

Tests analytics

Total tests: 3302 Passed tests 2962 Skipped tests: 337 Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFilestoreInstance_filestoreInstanceBasicIpv6Example|TestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccDataSourceGoogleServiceAccountIdToken_impersonation

Get to know how VCR tests work

modular-magician avatar Dec 18 '23 18:12 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccDataSourceGoogleServiceAccountAccessToken_basic[Debug log] TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccFilestoreInstance_filestoreInstanceBasicIpv6Example[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Dec 18 '23 18:12 modular-magician

/gcbrun

SarahFrench avatar Jan 05 '24 19:01 SarahFrench

Testing if this is still an issue: /gcbrun

SarahFrench avatar Mar 25 '24 12:03 SarahFrench