magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

mark default_from_api for empty_dir.medium in Cloud Run API.

Open bskaplan opened this issue 10 months ago • 8 comments

empty_dir.medium for cloud run currently only supports a value of "memory". If it's unset, we use that as the default.

Like with other fields in Cloud Run, we plan to start explicitly capturing the default value and returning it on subsequent gets. Pre-emptively marking the default so Terraform users don't break when the server starts setting this field.

If this PR is for Terraform, I acknowledge that I have:

  • [x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [x] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [x] Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • [x] Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [x] Read Write release notes before writing my release note below.

bskaplan avatar Aug 29 '23 20:08 bskaplan