magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

ensure google_cloudbuild_bitbucket_server_config tests get sweeped

Open ScottSuarez opened this issue 2 years ago • 10 comments

fixes TestAccCloudBuildBitbucketServerConfig_cloudbuildBitbucketServerConfigExample

Release Note Template for Downstream PRs (will be copied)


ScottSuarez avatar May 24 '23 22:05 ScottSuarez

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 7 insertions(+), 7 deletions(-)) Terraform Beta: Diff ( 2 files changed, 7 insertions(+), 7 deletions(-)) TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar May 24 '23 23:05 modular-magician

Tests analytics

Total tests: 2751 Passed tests 2459 Skipped tests: 283 Affected tests: 9

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccComputeFirewallPolicyRule_multipleRules|TestAccCloudBuildBitbucketServerConfig_cloudbuildBitbucketServerConfigExample|TestAccCloudBuildBitbucketServerConfig_cloudbuildBitbucketServerConfigPeeredNetworkExample|TestAccAlloydbBackup_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceAlloydbLocations_basic

Get to know how VCR tests work

modular-magician avatar May 25 '23 00:05 modular-magician

Tests passed during RECORDING mode: TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log] TestAccCloudBuildBitbucketServerConfig_cloudbuildBitbucketServerConfigExample[Debug log] TestAccCloudBuildBitbucketServerConfig_cloudbuildBitbucketServerConfigPeeredNetworkExample[Debug log] TestAccAlloydbBackup_missingLocation[Debug log] TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log] TestAccAlloydbCluster_missingLocation[Debug log] TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log] TestAccDataSourceAlloydbLocations_basic[Debug log]

Tests failed during RECORDING mode: TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar May 25 '23 00:05 modular-magician

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar May 22 '24 09:05 github-actions[bot]

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar May 29 '24 09:05 github-actions[bot]

Needs rebase to fix conflicts, but looks fine to me

slevenick avatar May 29 '24 18:05 slevenick

This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 05 '24 09:06 github-actions[bot]

This PR is approved and has been waiting for merge for 2 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 12 '24 09:06 github-actions[bot]

This PR is approved and has been waiting for merge for 3 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 19 '24 09:06 github-actions[bot]

This PR is approved and has been waiting for merge for 4 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 26 '24 09:06 github-actions[bot]

This PR is approved and has been waiting for merge for 5 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jul 03 '24 09:07 github-actions[bot]

This PR is approved and has been waiting for merge for 6 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jul 10 '24 09:07 github-actions[bot]

This PR is approved and has been waiting for merge for 7 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jul 17 '24 09:07 github-actions[bot]

This PR is approved and has been waiting for merge for 8 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jul 24 '24 09:07 github-actions[bot]

This PR is approved and has been waiting for merge for 9 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jul 31 '24 09:07 github-actions[bot]

This PR is approved and has been waiting for merge for 10 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Aug 07 '24 09:08 github-actions[bot]