magic-modules
magic-modules copied to clipboard
Update SP certificate documentation
Following the Terraform documentation I think the sp_certificates documentation is wrong. It currently indicates the sp_certificate is used for verifying the signature of the IDP SAML response, Instead the sp_certificate is generated by Identity Platform and should be provided to the IDP so they can validate the signature of SAML requests from the SP.
You can read more about it here: https://cloud.google.com/identity-platform/docs/web/saml#signing_requests
The response is an InboundSamlConfig object, which includes an array of SpCertificate. Configure the value of the X509 certificate with your SAML identity provider so it can validate the signature of your requests.
I acknowledge that I have:
- [ ] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Release Note Template for Downstream PRs (will be copied)
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Oops! It looks like you're using an unknown release-note type in your changelog entries:
- REPLACEME
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.
Hello! I am a robot who works on Magic Modules PRs.
I've detected that you're a community contributor. @scottsuarez, a repository maintainer, has been assigned to assist you and help review your changes.
:question: First time contributing? Click here for more details
Your assigned reviewer will help review your code by:
- Ensuring it's backwards compatible, covers common error cases, etc.
- Summarizing the change into a user-facing changelog note.
- Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.
If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.
Diff report:
Terraform GA: Diff ( 4 files changed, 4 insertions(+), 4 deletions(-)) Terraform Beta: Diff ( 4 files changed, 4 insertions(+), 4 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
Tests analytics
Total tests: 2178
Passed tests 1938
Skipped tests: 238
Failed tests: 2
Action taken
Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities
Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease
[Debug log]
Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities
[Error message] [Debug log]
Please fix these to complete your PR View the build log or the debug log for each test
apologies I never got around to this. If you rebase this PR I an take a look.
@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders
to disable these notifications.
@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders
to disable these notifications.
@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 5 weeks. Please take a look! Use the label disable-review-reminders
to disable these notifications.