magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Add the vertex endpoint resource.

Open trodge opened this issue 2 years ago • 18 comments

Add the google_vertex_ai_endpoint resource.

part of https://github.com/hashicorp/terraform-provider-google/issues/9298

If this PR is for Terraform, I acknowledge that I have:

  • [x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [x] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [x] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [x] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [x] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_vertex_ai_endpoint

trodge avatar Sep 20 '22 22:09 trodge

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @scottsuarez, a repository maintainer, has been assigned to assist you and help review your changes.

:question: First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


modular-magician avatar Sep 20 '22 22:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 1525 insertions(+), 5 deletions(-)) Terraform Beta: Diff ( 9 files changed, 1526 insertions(+), 6 deletions(-)) TF Validator: Diff ( 3 files changed, 132 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 4 files changed, 142 insertions(+))

modular-magician avatar Sep 20 '22 22:09 modular-magician

Tests analytics

Total tests: 2177 Passed tests 1936 Skipped tests: 238 Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccVertexAIEndpoint_vertexAiEndpointNetworkExample

modular-magician avatar Sep 20 '22 23:09 modular-magician

Tests passed during RECORDING mode: TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode: TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log] TestAccVertexAIEndpoint_vertexAiEndpointNetworkExample[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Sep 21 '22 00:09 modular-magician

/gcbrun

trodge avatar Sep 21 '22 18:09 trodge

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 1525 insertions(+), 5 deletions(-)) Terraform Beta: Diff ( 9 files changed, 1526 insertions(+), 6 deletions(-)) TF Validator: Diff ( 3 files changed, 132 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 4 files changed, 142 insertions(+))

modular-magician avatar Sep 21 '22 18:09 modular-magician

Tests analytics

Total tests: 2177 Passed tests 1937 Skipped tests: 238 Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccVertexAIEndpoint_vertexAiEndpointNetworkExample|TestAccComputeInstance_soleTenantNodeAffinities

modular-magician avatar Sep 21 '22 19:09 modular-magician

Tests failed during RECORDING mode: TestAccVertexAIEndpoint_vertexAiEndpointNetworkExample[Error message] [Debug log] TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Sep 21 '22 19:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 1526 insertions(+), 5 deletions(-)) Terraform Beta: Diff ( 9 files changed, 1527 insertions(+), 6 deletions(-)) TF Validator: Diff ( 3 files changed, 132 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 4 files changed, 142 insertions(+))

modular-magician avatar Sep 21 '22 21:09 modular-magician

Tests analytics

Total tests: 2177 Passed tests 1934 Skipped tests: 238 Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeForwardingRule_update|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccVertexAIEndpoint_vertexAiEndpointNetworkExample

modular-magician avatar Sep 21 '22 22:09 modular-magician

Tests passed during RECORDING mode: TestAccFirebaserulesRelease_BasicRelease[Debug log] TestAccComputeForwardingRule_update[Debug log]

Tests failed during RECORDING mode: TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log] TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log] TestAccVertexAIEndpoint_vertexAiEndpointNetworkExample[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Sep 21 '22 22:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 1526 insertions(+), 5 deletions(-)) Terraform Beta: Diff ( 9 files changed, 1527 insertions(+), 6 deletions(-)) TF Validator: Diff ( 3 files changed, 132 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 4 files changed, 142 insertions(+))

modular-magician avatar Sep 21 '22 23:09 modular-magician

Tests analytics

Total tests: 2177 Passed tests 1923 Skipped tests: 238 Failed tests: 16

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeForwardingRule_ip|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_update|TestAccVertexAIEndpoint_vertexAiEndpointNetworkExample

modular-magician avatar Sep 22 '22 00:09 modular-magician

Tests passed during RECORDING mode: TestAccComputeVpnTunnel_defaultTrafficSelectors[Debug log] TestAccComputeVpnTunnel_vpnTunnelBasicExample[Debug log] TestAccComputeVpnGateway_targetVpnGatewayBasicExample[Debug log] TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Debug log] TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Debug log] TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample[Debug log] TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample[Debug log] TestAccComputeForwardingRule_ip[Debug log] TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log] TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample[Debug log] TestAccComputeForwardingRule_forwardingRuleInternallbExample[Debug log] TestAccComputeForwardingRule_forwardingRuleL3DefaultExample[Debug log] TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Debug log] TestAccComputeForwardingRule_update[Debug log]

Tests failed during RECORDING mode: TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log] TestAccVertexAIEndpoint_vertexAiEndpointNetworkExample[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Sep 22 '22 00:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 1526 insertions(+), 5 deletions(-)) Terraform Beta: Diff ( 9 files changed, 1527 insertions(+), 6 deletions(-)) TF Validator: Diff ( 3 files changed, 132 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 4 files changed, 142 insertions(+))

modular-magician avatar Sep 22 '22 01:09 modular-magician

Tests analytics

Total tests: 2177 Passed tests 1883 Skipped tests: 238 Failed tests: 56

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeRouterInterface_withTunnel|TestAccComputeRouterInterface_basic|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeRouterPeer_bfd|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRoute_routeIlbExample|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccComputeVpnTunnel_router|TestAccComputeVpnTunnel_regionFromGateway|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeGlobalForwardingRule_ipv6|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeForwardingRule_forwardingRuleBasicExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeForwardingRule_serviceDirectoryRegistrations|TestAccComputeForwardingRule_networkTier|TestAccComputeForwardingRule_ip|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeGlobalForwardingRule_labels|TestAccComputeForwardingRule_update|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccClouddeployTarget_Target|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccCloudRunService_cloudRunServiceMultipleRegionsExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccDataSourceGoogleGlobalForwardingRule|TestAccDataSourceGoogleForwardingRule|TestAccVertexAIEndpoint_vertexAiEndpointNetworkExample|TestAccComputeFirewallPolicy_update|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeFirewallPolicyRule_update|TestAccComputeFirewallPolicyAssociation_basic

modular-magician avatar Sep 22 '22 02:09 modular-magician

Tests passed during RECORDING mode: TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Debug log] TestAccComputeVpnTunnel_defaultTrafficSelectors[Debug log] TestAccComputeVpnTunnel_vpnTunnelBasicExample[Debug log] TestAccComputePacketMirroring_computePacketMirroringFullExample[Debug log] TestAccComputeGlobalForwardingRule_updateTarget[Debug log] TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample[Debug log] TestAccComputeForwardingRule_forwardingRuleBasicExample[Debug log] TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[Debug log] TestAccComputeForwardingRule_serviceDirectoryRegistrations[Debug log] TestAccComputeForwardingRule_ip[Debug log] TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log] TestAccClouddeployDeliveryPipeline_DeliveryPipeline[Debug log] TestAccCloudRunService_cloudRunServiceMultipleRegionsExample[Debug log] TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log] TestAccDataSourceGoogleGlobalForwardingRule[Debug log] TestAccDataSourceGoogleForwardingRule[Debug log] TestAccComputeFirewallPolicy_update[Debug log] TestAccComputeFirewallPolicyRule_multipleRules[Debug log]

Tests failed during RECORDING mode: TestAccComputeRouterInterface_withTunnel[Error message] [Debug log] TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Error message] [Debug log] TestAccVertexAIEndpoint_vertexAiEndpointNetworkExample[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Sep 22 '22 04:09 modular-magician

Would you like any help with this change. Is it ready for review?

ScottSuarez avatar Sep 23 '22 00:09 ScottSuarez

/gcbrun

trodge avatar Sep 26 '22 18:09 trodge

I would like some help cleaning up the service networking connections in the CI test project. The test is currently failing with:

Error: Error waiting for Create Service Networking Connection: Error code 9, message: You have reached the limit of number of tenant resources in the tenancy unit for service 'servicenetworking.googleapis.com' and consumer '1067888929963'.

trodge avatar Sep 26 '22 18:09 trodge

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 1526 insertions(+), 5 deletions(-)) Terraform Beta: Diff ( 9 files changed, 1527 insertions(+), 6 deletions(-)) TF Validator: Diff ( 3 files changed, 132 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 4 files changed, 142 insertions(+))

modular-magician avatar Sep 26 '22 18:09 modular-magician

Tests analytics

Total tests: 2182 Passed tests 1922 Skipped tests: 238 Failed tests: 22

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccVertexAIEndpoint_vertexAiEndpointNetworkExample|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample|TestAccFirebaserulesRelease_BasicRelease|TestAccCloudRunService_cloudRunServiceMultipleRegionsExample|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccComputeForwardingRule_serviceDirectoryRegistrations|TestAccComputeForwardingRule_forwardingRuleBasicExample|TestAccComputeForwardingRule_ip|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_update|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccDataSourceGoogleForwardingRule|TestAccDataSourceGoogleGlobalForwardingRule|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeFirewallPolicy_update|TestAccComputeFirewallPolicyRule_multipleRules

modular-magician avatar Sep 26 '22 20:09 modular-magician

Tests passed during RECORDING mode: TestAccComputeVpnTunnel_defaultTrafficSelectors[Debug log] TestAccComputeVpnTunnel_vpnTunnelBasicExample[Debug log] TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log] TestAccComputeGlobalForwardingRule_updateTarget[Debug log] TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample[Debug log] TestAccFirebaserulesRelease_BasicRelease[Debug log] TestAccCloudRunService_cloudRunServiceMultipleRegionsExample[Debug log] TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[Debug log] TestAccClouddeployDeliveryPipeline_DeliveryPipeline[Debug log] TestAccComputeForwardingRule_serviceDirectoryRegistrations[Debug log] TestAccComputeForwardingRule_forwardingRuleBasicExample[Debug log] TestAccComputeForwardingRule_ip[Debug log] TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log] TestAccComputeForwardingRule_update[Debug log] TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Debug log] TestAccDataSourceGoogleForwardingRule[Debug log] TestAccDataSourceGoogleGlobalForwardingRule[Debug log] TestAccComputePacketMirroring_computePacketMirroringFullExample[Debug log] TestAccComputeFirewallPolicy_update[Debug log] TestAccComputeFirewallPolicyRule_multipleRules[Debug log]

Tests failed during RECORDING mode: TestAccVertexAIEndpoint_vertexAiEndpointNetworkExample[Error message] [Debug log] TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Sep 26 '22 20:09 modular-magician

I would take a look at the ci project and try and clear up some networking resources there. https://pantheon.corp.google.com/welcome?project=ci-test-project-188019

ScottSuarez avatar Sep 26 '22 21:09 ScottSuarez

I would take a look at the ci project and try and clear up some networking resources there. https://pantheon.corp.google.com/welcome?project=ci-test-project-188019

I don't seem to have access.

trodge avatar Sep 27 '22 18:09 trodge

Good to know ! Let me follow up with Riley ~ !

ScottSuarez avatar Sep 27 '22 22:09 ScottSuarez

/gcbrun

trodge avatar Sep 28 '22 20:09 trodge

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 1526 insertions(+), 5 deletions(-)) Terraform Beta: Diff ( 9 files changed, 1527 insertions(+), 6 deletions(-)) TF Validator: Diff ( 3 files changed, 132 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 4 files changed, 142 insertions(+))

modular-magician avatar Sep 28 '22 20:09 modular-magician

Tests analytics

Total tests: 2193 Passed tests 1943 Skipped tests: 240 Failed tests: 10

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeRouterInterface_basic|TestAccVertexAIEndpoint_vertexAiEndpointNetworkExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeForwardingRule_networkTier|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccComputeFirewallPolicyRule_update

modular-magician avatar Sep 28 '22 21:09 modular-magician

Tests passed during RECORDING mode: TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade[Debug log] TestAccFirebaserulesRelease_BasicRelease[Debug log] TestAccComputeVpnTunnel_vpnTunnelBetaExample[Debug log] TestAccComputeRouterInterface_basic[Debug log] TestAccComputeForwardingRule_forwardingRuleExternallbExample[Debug log] TestAccComputeForwardingRule_networkTier[Debug log] TestAccComputeFirewallPolicyRule_update[Debug log]

Tests failed during RECORDING mode: TestAccVertexAIEndpoint_vertexAiEndpointNetworkExample[Error message] [Debug log] TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log] TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Sep 28 '22 22:09 modular-magician