magic-modules
magic-modules copied to clipboard
bq analytics hub - add listing resource
If this PR is for Terraform, I acknowledge that I have:
- [x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
- [x] Generated Terraform, and ran
make test
andmake lint
to ensure it passes unit and linter tests. - [x] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
- [x] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
- [x] Read the Release Notes Guide before writing my release note below.
Release Note Template for Downstream PRs (will be copied)
`google_bigquery_analytics_hub_listing` (beta)
`google_bigquery_analytics_hub_listing_iam_binding` (beta)
`google_bigquery_analytics_hub_listing_iam_member` (beta)
`google_bigquery_analytics_hub_listing_iam_policy` (beta)
Hello! I am a robot who works on Magic Modules PRs.
I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes.
:question: First time contributing? Click here for more details
Your assigned reviewer will help review your code by:
- Ensuring it's backwards compatible, covers common error cases, etc.
- Summarizing the change into a user-facing changelog note.
- Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.
If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.
Diff report:
Terraform GA: Diff ( 2 files changed, 362 insertions(+)) Terraform Beta: Diff ( 8 files changed, 1931 insertions(+), 3 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 4 files changed, 129 insertions(+))
Tests analytics
Total tests: 2178
Passed tests 1932
Skipped tests: 238
Failed tests: 8
Action taken
Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccBigqueryAnalyticsHubListing_bigqueryAnalyticshubListingBasicExample|TestAccBigqueryAnalyticsHubListingIamPolicyGenerated|TestAccDataSourceGoogleServiceAccountJwt|TestAccBigqueryAnalyticsHubListingIamMemberGenerated|TestAccBigqueryAnalyticsHubListingIamBindingGenerated
Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease
[Debug log]
TestAccBigqueryAnalyticsHubListing_bigqueryAnalyticshubListingBasicExample
[Debug log]
TestAccBigqueryAnalyticsHubListingIamPolicyGenerated
[Debug log]
TestAccDataSourceGoogleServiceAccountJwt
[Debug log]
TestAccBigqueryAnalyticsHubListingIamMemberGenerated
[Debug log]
TestAccBigqueryAnalyticsHubListingIamBindingGenerated
[Debug log]
Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities
[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample
[Error message] [Debug log]
Please fix these to complete your PR View the build log or the debug log for each test
Thanks slevenick addressed comments and all tests are passing locally
Hi there, I'm the Modular magician. I've sorted out the following information about your changes, here it is - !
Diff report
Terraform GA: Diff ( 3 files changed, 428 insertions(+)) Terraform Beta: Diff ( 9 files changed, 1995 insertions(+), 3 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 4 files changed, 129 insertions(+))
Tests analytics
Total tests: 2205
Passed tests 1962
Skipped tests: 240
Failed tests: 3
Action taken
Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccBigqueryAnalyticsHubListing_bigqueryAnalyticshubListingUpdate
Tests passed during RECORDING mode:
TestAccBigqueryAnalyticsHubListing_bigqueryAnalyticshubListingUpdate
[Debug log]
Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities
[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample
[Error message] [Debug log]
Please fix these to complete your PR View the build log or the debug log for each test
This is failing the lint step:
google/resource_bigquery_analytics_hub_listing_test.go:18:17: undefined: testAccProvidersOiCS
google/resource_bigquery_analytics_hub_listing_test.go:19:17: undefined: testAccCheckBigqueryAnalyticsHubListingDestroyProducer
google/resource_bigquery_analytics_hub_listing_test.go:22:13: undefined: testAccBigqueryAnalyticsHubListing_bigqueryAnalyticshubListingBasicExample
slevenick strange, will rebase and try again, was able to gen locally
==> Checking that code complies with gofmt requirements...
go vet
go generate ./...
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google-beta -v -run=TestAccBigqueryAnalyticsHubListing_bigqueryAnalyticshubListingUpdate -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google-beta/version.ProviderVersion=acc"
=== RUN TestAccBigqueryAnalyticsHubListing_bigqueryAnalyticshubListingUpdate
=== PAUSE TestAccBigqueryAnalyticsHubListing_bigqueryAnalyticshubListingUpdate
=== CONT TestAccBigqueryAnalyticsHubListing_bigqueryAnalyticshubListingUpdate
--- PASS: TestAccBigqueryAnalyticsHubListing_bigqueryAnalyticshubListingUpdate (20.79s)
PASS
ok github.com/hashicorp/terraform-provider-google-beta/google-beta 21.557s
Oh, the lint errors are coming from the google
provider only. The test file will need version tags to only generate at beta, or else it ends up in the GA provider without the required resource
slevenick doh! fixing!
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.
Diff report:
Terraform GA: Diff ( 3 files changed, 427 insertions(+)) Terraform Beta: Diff ( 9 files changed, 1994 insertions(+), 3 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 4 files changed, 129 insertions(+))
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.
Diff report:
Terraform GA: Diff ( 3 files changed, 430 insertions(+)) Terraform Beta: Diff ( 9 files changed, 1997 insertions(+), 3 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 4 files changed, 129 insertions(+))
Tests analytics
Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0
Errors occurred during REPLAYING mode. Please fix them to complete your PR View the build log
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.
Diff report:
Terraform GA: Diff ( 3 files changed, 361 insertions(+)) Terraform Beta: Diff ( 9 files changed, 1994 insertions(+), 3 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 4 files changed, 129 insertions(+))
Tests analytics
Total tests: 2213
Passed tests 1969
Skipped tests: 240
Failed tests: 4
Action taken
Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccComputeInstance_soleTenantNodeAffinities
Tests passed during RECORDING mode:
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample
[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample
[Debug log]
Tests failed during RECORDING mode:
TestAccCGCSnippet_eventarcWorkflowsExample
[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities
[Error message] [Debug log]
Please fix these to complete your PR View the build log or the debug log for each test
Thanks!