magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Add support for GitHubEnterpriseConfig

Open prateek2408 opened this issue 2 years ago • 4 comments

Currently CloudBuild does not support GitHubEnterpriseConfig. This PR adds the support of creating GitHubEnterpriseConfig resources.

fixes {https://github.com/hashicorp/terraform-provider-google/issues/9956}

If this PR is for Terraform, I acknowledge that I have:

  • [X] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [X] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [X] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [X] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [X] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudbuild: added support for `"GitHubEnterpriseConfig"` in `google_cloudbuild_trigger`

prateek2408 avatar Sep 17 '22 05:09 prateek2408

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @rileykarson, a repository maintainer, has been assigned to assist you and help review your changes.

:question: First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


modular-magician avatar Sep 17 '22 05:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 799 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 4 files changed, 799 insertions(+), 2 deletions(-)) TF Validator: Diff ( 3 files changed, 188 insertions(+), 3 deletions(-))

modular-magician avatar Sep 17 '22 05:09 modular-magician

Tests analytics

Total tests: 2174 Passed tests 1934 Skipped tests: 238 Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities

modular-magician avatar Sep 17 '22 06:09 modular-magician

Tests passed during RECORDING mode: TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode: TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Sep 17 '22 06:09 modular-magician

I suspect this PR is stale, so closing- we do have trigger-level support as of https://github.com/GoogleCloudPlatform/magic-modules/pull/6963

rileykarson avatar Mar 27 '24 19:03 rileykarson