magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Adding Eventarc Channel Resource support for TPG

Open daveavi opened this issue 2 years ago • 32 comments

I have made changes to the magic-modules repo to support a new resource the Eventarc team has created, called channel.

I have hand written the acceptance test. given that it requires an IAM binding and it uses cloud kms key's, I have bootstrapped the dependencies in order for the test to pass.

Here is the issue I have created in TPG: https://github.com/hashicorp/terraform-provider-google/issues/12517

If this PR is for Terraform, I acknowledge that I have:

  • [X] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [X] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [X] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [x] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [X] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_eventarc_channel

daveavi avatar Sep 09 '22 14:09 daveavi

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 731 insertions(+)) Terraform Beta: Diff ( 5 files changed, 731 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Sep 09 '22 14:09 modular-magician

Tests analytics

Total tests: 0 Passed tests 0 Skipped tests: 0 Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR View the build log

modular-magician avatar Sep 09 '22 14:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 734 insertions(+), 1 deletion(-)) Terraform Beta: Diff ( 7 files changed, 734 insertions(+), 1 deletion(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Sep 09 '22 15:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 735 insertions(+), 1 deletion(-)) Terraform Beta: Diff ( 7 files changed, 735 insertions(+), 1 deletion(-)) TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

modular-magician avatar Sep 09 '22 16:09 modular-magician

Tests analytics

Total tests: 2171 Passed tests 1878 Skipped tests: 236 Failed tests: 57

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccEventarcChannel_BasicHandWritten|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccComputeVpnTunnel_router|TestAccComputeVpnTunnel_regionFromGateway|TestAccComputeRoute_routeIlbVipExample|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeRoute_routeIlbExample|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeRouterInterface_withTunnel|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeRouterInterface_basic|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeGlobalForwardingRule_labels|TestAccComputeGlobalForwardingRule_ipv6|TestAccComputeRouterPeer_bfd|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_serviceDirectoryRegistrations|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeForwardingRule_networkTier|TestAccComputeRouterPeer_enable|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeRouterPeer_advertiseMode|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample|TestAccComputeRouterPeer_basic|TestAccComputeForwardingRule_ip|TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample|TestAccComputeForwardingRule_update|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeForwardingRule_forwardingRuleBasicExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccCloudRunService_cloudRunServiceMultipleRegionsExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccDataSourceGoogleGlobalForwardingRule|TestAccDataSourceGoogleForwardingRule|TestAccComputeFirewallPolicyRule_update|TestAccComputeFirewallPolicyAssociation_basic|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeFirewallPolicy_update

modular-magician avatar Sep 09 '22 17:09 modular-magician

Tests passed during RECORDING mode: TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Debug log] TestAccComputeGlobalForwardingRule_labels[Debug log] TestAccComputeGlobalForwardingRule_ipv6[Debug log] TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log] TestAccComputeForwardingRule_serviceDirectoryRegistrations[Debug log] TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample[Debug log] TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample[Debug log] TestAccComputeForwardingRule_ip[Debug log] TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample[Debug log] TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample[Debug log] TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample[Debug log] TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[Debug log] TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log] TestAccComputeFirewallPolicyRule_update[Debug log]

Tests failed during RECORDING mode: TestAccEventarcChannel_BasicHandWritten[Error message] [Debug log] TestAccComputeVpnTunnel_router[Error message] [Debug log] TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Error message] [Debug log] TestAccComputeRouterPeer_bfd[Error message] [Debug log] TestAccComputeRouterPeer_advertiseMode[Error message] [Debug log] TestAccComputeRouterPeer_basic[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Sep 09 '22 18:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 741 insertions(+), 1 deletion(-)) Terraform Beta: Diff ( 7 files changed, 741 insertions(+), 1 deletion(-)) TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

modular-magician avatar Sep 09 '22 18:09 modular-magician

Tests analytics

Total tests: 2171 Passed tests 1892 Skipped tests: 236 Failed tests: 43

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccDataSourceGoogleGlobalForwardingRule|TestAccFirebaserulesRelease_BasicRelease|TestAccEventarcChannel_BasicHandWritten|TestAccDataSourceGoogleForwardingRule|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccComputeVpnTunnel_router|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeVpnTunnel_regionFromGateway|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeRouterInterface_withTunnel|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeRouterInterface_basic|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRoute_routeIlbExample|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeForwardingRule_networkTier|TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample|TestAccComputeForwardingRule_update|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeForwardingRule_forwardingRuleBasicExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample|TestAccCloudRunService_cloudRunServiceMultipleRegionsExample|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeFirewallPolicyAssociation_basic|TestAccComputeFirewallPolicy_update

modular-magician avatar Sep 09 '22 19:09 modular-magician

Tests passed during RECORDING mode: TestAccComputeVpnTunnel_regionFromGateway[Debug log] TestAccComputeVpnTunnel_vpnTunnelBasicExample[Debug log] TestAccComputeRouterInterface_basic[Debug log] TestAccComputeRoute_routeIlbVipExample[Debug log] TestAccComputeGlobalForwardingRule_internalLoadBalancing[Debug log] TestAccComputeGlobalForwardingRule_updateTarget[Debug log] TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample[Debug log] TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log] TestAccComputeForwardingRule_forwardingRuleInternallbExample[Debug log] TestAccComputeForwardingRule_forwardingRuleExternallbExample[Debug log] TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample[Debug log] TestAccCGCSnippet_eventarcWorkflowsExample[Debug log] TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[Debug log] TestAccComputeFirewallPolicyRule_multipleRules[Debug log] TestAccComputeFirewallPolicyAssociation_basic[Debug log] TestAccComputeFirewallPolicy_update[Debug log]

Tests failed during RECORDING mode: TestAccEventarcChannel_BasicHandWritten[Error message] [Debug log] TestAccComputeVpnTunnel_router[Error message] [Debug log] TestAccComputeRouterInterface_withTunnel[Error message] [Debug log] TestAccComputeRouterPeer_bfd[Error message] [Debug log] TestAccComputeRouterPeer_enable[Error message] [Debug log] TestAccComputeRouterPeer_advertiseMode[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Sep 09 '22 22:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 741 insertions(+), 1 deletion(-)) Terraform Beta: Diff ( 7 files changed, 741 insertions(+), 1 deletion(-)) TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

modular-magician avatar Sep 09 '22 23:09 modular-magician

Tests analytics

Total tests: 2171 Passed tests 1907 Skipped tests: 236 Failed tests: 28

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccEventarcChannel_BasicHandWritten|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccComputeVpnTunnel_router|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeRouterInterface_withTunnel|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeRouterPeer_bfd|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeForwardingRule_forwardingRuleBasicExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeForwardingRule_networkTier|TestAccComputeForwardingRule_update|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeRoute_routeIlbExample|TestAccCloudRunService_cloudRunServiceMultipleRegionsExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccDataSourceGoogleGlobalForwardingRule|TestAccDataSourceGoogleForwardingRule

modular-magician avatar Sep 10 '22 00:09 modular-magician

Tests passed during RECORDING mode: TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[Debug log] TestAccFirebaserulesRelease_BasicRelease[Debug log] TestAccComputeVpnTunnel_defaultTrafficSelectors[Debug log] TestAccComputeVpnTunnel_vpnTunnelBetaExample[Debug log] TestAccComputeVpnGateway_targetVpnGatewayBasicExample[Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Debug log] TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Debug log] TestAccComputeForwardingRule_forwardingRuleBasicExample[Debug log] TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Debug log] TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log] TestAccComputeForwardingRule_networkTier[Debug log] TestAccComputeForwardingRule_forwardingRuleL3DefaultExample[Debug log] TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Debug log] TestAccComputeRoute_routeIlbExample[Debug log] TestAccCloudRunService_cloudRunServiceMultipleRegionsExample[Debug log] TestAccDataSourceGoogleGlobalForwardingRule[Debug log] TestAccDataSourceGoogleForwardingRule[Debug log]

Tests failed during RECORDING mode: TestAccEventarcChannel_BasicHandWritten[Error message] [Debug log] TestAccComputeVpnTunnel_router[Error message] [Debug log] TestAccComputeRouterPeer_bfd[Error message] [Debug log] TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Error message] [Debug log] TestAccComputeRouterPeer_advertiseMode[Error message] [Debug log] TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Sep 10 '22 00:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 736 insertions(+), 1 deletion(-)) Terraform Beta: Diff ( 7 files changed, 736 insertions(+), 1 deletion(-)) TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

modular-magician avatar Sep 12 '22 17:09 modular-magician

Tests analytics

Total tests: 2172 Passed tests 1921 Skipped tests: 237 Failed tests: 14

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeVpnTunnel_router|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccEventarcChannel_BasicHandWritten|TestAccComputeRouterPeer_basic|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeRouterInterface_withTunnel|TestAccComputeForwardingRule_update|TestAccCGCSnippet_eventarcWorkflowsExample

modular-magician avatar Sep 12 '22 17:09 modular-magician

Tests passed during RECORDING mode: TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[Debug log] TestAccFirebaserulesRelease_BasicRelease[Debug log] TestAccEventarcChannel_BasicHandWritten[Debug log] TestAccComputePacketMirroring_computePacketMirroringFullExample[Debug log] TestAccComputeForwardingRule_update[Debug log]

Tests failed during RECORDING mode: TestAccComputeVpnTunnel_router[Error message] [Debug log] TestAccComputeRouterPeer_bfd[Error message] [Debug log] TestAccComputeRouterPeer_enable[Error message] [Debug log] TestAccComputeRouterPeer_advertiseMode[Error message] [Debug log] TestAccComputeRouterPeer_basic[Error message] [Debug log] TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log] TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Error message] [Debug log] TestAccComputeRouterInterface_withTunnel[Error message] [Debug log] TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Sep 12 '22 18:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 735 insertions(+), 1 deletion(-)) Terraform Beta: Diff ( 7 files changed, 735 insertions(+), 1 deletion(-)) TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

modular-magician avatar Sep 13 '22 21:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 777 insertions(+), 1 deletion(-)) Terraform Beta: Diff ( 7 files changed, 777 insertions(+), 1 deletion(-)) TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

modular-magician avatar Sep 14 '22 13:09 modular-magician

Tests analytics

Total tests: 2173 Passed tests 1924 Skipped tests: 238 Failed tests: 11

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccEventarcChannel_cryptoKeyUpdate|TestAccEventarcChannel_basic|TestAccComputeRouterPeer_advertiseMode|TestAccComputeVpnTunnel_router|TestAccComputeRouterInterface_withTunnel|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeRouterPeer_basic|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample

modular-magician avatar Sep 14 '22 14:09 modular-magician

Tests passed during RECORDING mode: TestAccEventarcChannel_cryptoKeyUpdate[Debug log] TestAccEventarcChannel_basic[Debug log] TestAccCGCSnippet_eventarcWorkflowsExample[Debug log]

Tests failed during RECORDING mode: TestAccComputeRouterPeer_advertiseMode[Error message] [Debug log] TestAccComputeVpnTunnel_router[Error message] [Debug log] TestAccComputeRouterInterface_withTunnel[Error message] [Debug log] TestAccComputeRouterPeer_bfd[Error message] [Debug log] TestAccComputeRouterPeer_enable[Error message] [Debug log] TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Error message] [Debug log] TestAccComputeRouterPeer_basic[Error message] [Debug log] TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Sep 14 '22 14:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 777 insertions(+), 1 deletion(-)) Terraform Beta: Diff ( 7 files changed, 777 insertions(+), 1 deletion(-)) TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

modular-magician avatar Sep 14 '22 21:09 modular-magician

Tests analytics

Total tests: 2173 Passed tests 1927 Skipped tests: 238 Failed tests: 8

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeVpnTunnel_router|TestAccComputeRouterInterface_withTunnel|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeInstance_soleTenantNodeAffinities

modular-magician avatar Sep 14 '22 22:09 modular-magician

Tests failed during RECORDING mode: TestAccComputeVpnTunnel_router[Error message] [Debug log] TestAccComputeRouterInterface_withTunnel[Error message] [Debug log] TestAccComputeRouterPeer_bfd[Error message] [Debug log] TestAccComputeRouterPeer_enable[Error message] [Debug log] TestAccComputeRouterPeer_advertiseMode[Error message] [Debug log] TestAccComputeRouterPeer_basic[Error message] [Debug log] TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Error message] [Debug log] TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Sep 14 '22 22:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 14 files changed, 1004 insertions(+), 11 deletions(-)) Terraform Beta: Diff ( 14 files changed, 1004 insertions(+), 11 deletions(-)) TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

modular-magician avatar Sep 15 '22 19:09 modular-magician

Tests analytics

Total tests: 2174 Passed tests 1924 Skipped tests: 238 Failed tests: 12

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccComputeRouterInterface_withTunnel|TestAccDataSourceGoogleServiceAccountJwt|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeRouterPeer_basic|TestAccComputeVpnTunnel_router|TestAccComputeInstance_soleTenantNodeAffinities|TestAccClouddeployTarget_Target|TestAccClouddeployDeliveryPipeline_DeliveryPipeline

modular-magician avatar Sep 15 '22 20:09 modular-magician

Tests passed during RECORDING mode: TestAccFirebaserulesRelease_BasicRelease[Debug log] TestAccDataSourceGoogleServiceAccountJwt[Debug log] TestAccClouddeployDeliveryPipeline_DeliveryPipeline[Debug log]

Tests failed during RECORDING mode: TestAccComputeRouterInterface_withTunnel[Error message] [Debug log] TestAccComputeRouterPeer_bfd[Error message] [Debug log] TestAccComputeRouterPeer_enable[Error message] [Debug log] TestAccComputeRouterPeer_advertiseMode[Error message] [Debug log] TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Error message] [Debug log] TestAccComputeRouterPeer_basic[Error message] [Debug log] TestAccComputeVpnTunnel_router[Error message] [Debug log] TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log] TestAccClouddeployTarget_Target[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Sep 15 '22 20:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 15 files changed, 1177 insertions(+), 11 deletions(-)) Terraform Beta: Diff ( 15 files changed, 1177 insertions(+), 11 deletions(-)) TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

modular-magician avatar Sep 15 '22 22:09 modular-magician

Tests analytics

Total tests: 2176 Passed tests 1926 Skipped tests: 238 Failed tests: 12

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccEventarcTrigger_channel|TestAccComputeVpnTunnel_router|TestAccComputeRouterInterface_withTunnel|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccClouddeployTarget_Target|TestAccStorageTransferJob_transferOptions

modular-magician avatar Sep 15 '22 23:09 modular-magician

Tests passed during RECORDING mode: TestAccFirebaserulesRelease_BasicRelease[Debug log] TestAccEventarcTrigger_channel[Debug log] TestAccStorageTransferJob_transferOptions[Debug log]

Tests failed during RECORDING mode: TestAccComputeVpnTunnel_router[Error message] [Debug log] TestAccComputeRouterInterface_withTunnel[Error message] [Debug log] TestAccComputeRouterPeer_bfd[Error message] [Debug log] TestAccComputeRouterPeer_enable[Error message] [Debug log] TestAccComputeRouterPeer_advertiseMode[Error message] [Debug log] TestAccComputeRouterPeer_basic[Error message] [Debug log] TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Error message] [Debug log] TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log] TestAccClouddeployTarget_Target[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Sep 15 '22 23:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 15 files changed, 1175 insertions(+), 11 deletions(-)) Terraform Beta: Diff ( 15 files changed, 1175 insertions(+), 11 deletions(-)) TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

modular-magician avatar Sep 16 '22 21:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 15 files changed, 1171 insertions(+), 11 deletions(-)) Terraform Beta: Diff ( 15 files changed, 1171 insertions(+), 11 deletions(-)) TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

modular-magician avatar Sep 16 '22 22:09 modular-magician