magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

compute_snapshot datasource added

Open AarshDhokai opened this issue 1 year ago • 23 comments

fixes https://github.com/hashicorp/terraform-provider-google/issues/3382

If this PR is for Terraform, I acknowledge that I have:

  • [x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [x] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [x] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [x] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [x] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_compute_snapshot'

AarshDhokai avatar Sep 09 '22 07:09 AarshDhokai

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @rileykarson, a repository maintainer, has been assigned to assist you and help review your changes.

:question: First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


modular-magician avatar Sep 09 '22 07:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 445 insertions(+)) Terraform Beta: Diff ( 4 files changed, 445 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Sep 09 '22 07:09 modular-magician

Tests analytics

Total tests: 0 Passed tests 0 Skipped tests: 0 Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR View the build log

modular-magician avatar Sep 09 '22 07:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 443 insertions(+)) Terraform Beta: Diff ( 4 files changed, 443 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Sep 09 '22 09:09 modular-magician

Tests analytics

Total tests: 0 Passed tests 0 Skipped tests: 0 Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR View the build log

modular-magician avatar Sep 09 '22 09:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 442 insertions(+)) Terraform Beta: Diff ( 4 files changed, 442 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Sep 09 '22 09:09 modular-magician

Tests analytics

Total tests: 0 Passed tests 0 Skipped tests: 0 Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR View the build log

modular-magician avatar Sep 09 '22 09:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 442 insertions(+)) Terraform Beta: Diff ( 4 files changed, 442 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Sep 14 '22 09:09 modular-magician

Tests analytics

Total tests: 0 Passed tests 0 Skipped tests: 0 Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR View the build log

modular-magician avatar Sep 14 '22 09:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 442 insertions(+)) Terraform Beta: Diff ( 4 files changed, 442 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Sep 14 '22 09:09 modular-magician

Tests analytics

Total tests: 2174 Passed tests 1930 Skipped tests: 238 Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccSnapshotDatasource_filter_mostRecent|TestAccSnapshotDatasource_filter|TestAccSnapshotDatasource_name|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample

modular-magician avatar Sep 14 '22 10:09 modular-magician

Tests passed during RECORDING mode: TestAccFirebaserulesRelease_BasicRelease[Debug log] TestAccSnapshotDatasource_filter_mostRecent[Debug log] TestAccSnapshotDatasource_filter[Debug log] TestAccSnapshotDatasource_name[Debug log]

Tests failed during RECORDING mode: TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log] TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Sep 14 '22 10:09 modular-magician

What issue(s) does this PR address? The filter and most_recent behaviour are not standard for a single-resource datasource, so I want to make sure we're not introducing additional complexity / surface we have to maintain without a justification.

This PR addresses this issue - Disk snapshot data source #3382 .

AarshDhokai avatar Sep 15 '22 05:09 AarshDhokai

Thanks! The issue clarifies why we'd want those behaviours.

rileykarson avatar Sep 15 '22 19:09 rileykarson

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 370 insertions(+)) Terraform Beta: Diff ( 4 files changed, 370 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Sep 17 '22 13:09 modular-magician

Tests analytics

Total tests: 2177 Passed tests 1935 Skipped tests: 238 Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccSnapshotDatasource_filter_mostRecent|TestAccSnapshotDatasource_filter

modular-magician avatar Sep 17 '22 15:09 modular-magician

Tests passed during RECORDING mode: TestAccSnapshotDatasource_filter_mostRecent[Debug log] TestAccSnapshotDatasource_filter[Debug log]

Tests failed during RECORDING mode: TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log] TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Sep 17 '22 15:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 369 insertions(+)) Terraform Beta: Diff ( 4 files changed, 369 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Sep 22 '22 19:09 modular-magician

Tests analytics

Total tests: 2179 Passed tests 1935 Skipped tests: 238 Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccSnapshotDatasource_filterMostRecent

modular-magician avatar Sep 22 '22 20:09 modular-magician

Tests passed during RECORDING mode: TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log] TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log] TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log] TestAccSnapshotDatasource_filterMostRecent[Debug log]

Tests failed during RECORDING mode: TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log] TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Sep 22 '22 20:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 369 insertions(+)) Terraform Beta: Diff ( 4 files changed, 369 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Sep 23 '22 05:09 modular-magician

Tests analytics

Total tests: 2181 Passed tests 1941 Skipped tests: 238 Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities

modular-magician avatar Sep 23 '22 06:09 modular-magician

Tests passed during RECORDING mode: TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode: TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Sep 23 '22 06:09 modular-magician

Hi @rileykarson, Could you please Merge this PR as it's approved?

AarshDhokai avatar Sep 28 '22 05:09 AarshDhokai