magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Added datasource files for cloudfunctions2_function

Open AlfatahB opened this issue 1 year ago • 20 comments

Created Datasource file and corresponding Test as well as Web documentation for google_cloudfunctions2_function.

If this PR is for Terraform, I acknowledge that I have:

  • [x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [x] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [x] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [x] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [x] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_cloudfunctions2_function`

AlfatahB avatar Sep 08 '22 09:09 AlfatahB

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @rileykarson, a repository maintainer, has been assigned to assist you and help review your changes.

:question: First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


modular-magician avatar Sep 08 '22 09:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 328 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 5 files changed, 328 insertions(+), 2 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Sep 08 '22 09:09 modular-magician

Tests analytics

Total tests: 2170 Passed tests 1928 Skipped tests: 235 Failed tests: 7

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeInstance_soleTenantNodeAffinities|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccFirebaserulesRelease_BasicRelease|TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccDataSourceGoogleCloudFunctions2Function_basic|TestAccDataSourceGoogleServiceAccountIdToken_impersonation

modular-magician avatar Sep 08 '22 10:09 modular-magician

Tests passed during RECORDING mode: TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[Debug log] TestAccFirebaserulesRelease_BasicRelease[Debug log] TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade[Debug log] TestAccCGCSnippet_eventarcWorkflowsExample[Debug log] TestAccDataSourceGoogleCloudFunctions2Function_basic[Debug log] TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]

Tests failed during RECORDING mode: TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Sep 08 '22 10:09 modular-magician

@rileykarson Can you please review this PR?

AlfatahB avatar Sep 12 '22 10:09 AlfatahB

Oh, see https://github.com/GoogleCloudPlatform/magic-modules/blob/main/.ci/RELEASE_NOTES_GUIDE.md for details on formatting the release notes for your change as well!

rileykarson avatar Sep 13 '22 00:09 rileykarson

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 163 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 5 files changed, 163 insertions(+), 2 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Sep 13 '22 05:09 modular-magician

Tests analytics

Total tests: 2172 Passed tests 1925 Skipped tests: 238 Failed tests: 9

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccVPCAccessConnector_vpcAccessConnectorSharedVPCExample|TestAccVPCAccessConnector_cloudrunVPCAccessConnectorExample|TestAccVPCAccessConnector_vpcAccessConnectorExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccCloudFunctionsFunction_vpcConnector|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccAppEngineStandardAppVersion_update|TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade

modular-magician avatar Sep 13 '22 06:09 modular-magician

Tests passed during RECORDING mode: TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade[Debug log]

Tests failed during RECORDING mode: TestAccVPCAccessConnector_vpcAccessConnectorSharedVPCExample[Error message] [Debug log] TestAccVPCAccessConnector_cloudrunVPCAccessConnectorExample[Error message] [Debug log] TestAccVPCAccessConnector_vpcAccessConnectorExample[Error message] [Debug log] TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log] TestAccCloudRunService_cloudRunServiceStaticOutboundExample[Error message] [Debug log] TestAccCloudFunctionsFunction_vpcConnector[Error message] [Debug log] TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log] TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Sep 13 '22 06:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 167 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 5 files changed, 167 insertions(+), 2 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Sep 14 '22 06:09 modular-magician

Tests analytics

Total tests: 2172 Passed tests 1929 Skipped tests: 238 Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccDataSourceGoogleServiceAccountJwt

modular-magician avatar Sep 14 '22 07:09 modular-magician

Tests passed during RECORDING mode: TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade[Debug log] TestAccFirebaserulesRelease_BasicRelease[Debug log] TestAccDataSourceGoogleServiceAccountJwt[Debug log]

Tests failed during RECORDING mode: TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log] TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Sep 14 '22 08:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 177 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 5 files changed, 177 insertions(+), 2 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Sep 14 '22 18:09 modular-magician

Tests analytics

Total tests: 2172 Passed tests 1932 Skipped tests: 238 Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeInstance_soleTenantNodeAffinities|TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade

modular-magician avatar Sep 14 '22 19:09 modular-magician

Tests passed during RECORDING mode: TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade[Debug log]

Tests failed during RECORDING mode: TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Sep 14 '22 19:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 183 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 5 files changed, 183 insertions(+), 2 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Sep 15 '22 06:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 183 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 5 files changed, 183 insertions(+), 2 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Sep 15 '22 06:09 modular-magician

Tests analytics

Total tests: 2172 Passed tests 1930 Skipped tests: 238 Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade

modular-magician avatar Sep 15 '22 07:09 modular-magician

Tests passed during RECORDING mode: TestAccFirebaserulesRelease_BasicRelease[Debug log] TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade[Debug log]

Tests failed during RECORDING mode: TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log] TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Sep 15 '22 08:09 modular-magician

@rileykarson I've made the changes as suggested. Can you please review these changes?

AlfatahB avatar Sep 22 '22 05:09 AlfatahB

@rileykarson Could you please merge this PR?

AlfatahB avatar Sep 27 '22 05:09 AlfatahB