magic-modules
magic-modules copied to clipboard
GoogleCloudPlatform
Alloydb cluster
Supercedes #6208 Relates of https://github.com/hashicorp/terraform-provider-google/issues/11754
If this PR is for Terraform, I acknowledge that I have:
- [x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
- [x] Generated Terraform, and ran
make testandmake lintto ensure it passes unit and linter tests. - [x] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
- [x] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
- [x] Read the Release Notes Guide before writing my release note below.
Release Note Template for Downstream PRs (will be copied)
google_alloydb_cluster
Hello! I am a robot who works on Magic Modules PRs.
I've detected that you're a community contributor. @scottsuarez, a repository maintainer, has been assigned to assist you and help review your changes.
:question: First time contributing? Click here for more details
Your assigned reviewer will help review your code by:
- Ensuring it's backwards compatible, covers common error cases, etc.
- Summarizing the change into a user-facing changelog note.
- Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.
If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.
Diff report:
Terraform GA: Diff ( 2 files changed, 309 insertions(+)) Terraform Beta: Diff ( 8 files changed, 2016 insertions(+), 2 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 4 files changed, 120 insertions(+))
Tests analytics
Total tests: 2158
Passed tests 1915
Skipped tests: 234
Failed tests: 9
Action taken
Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccAlloydbCluster_update|TestAccAlloydbCluster_alloydbClusterBasicExample|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange
Tests passed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[Debug log]
TestAccAlloydbCluster_update[Debug log]
TestAccAlloydbCluster_alloydbClusterBasicExample[Debug log]
Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[Error message] [Debug log]
TestAccSqlDatabaseInstance_SqlServerAuditConfig[Error message] [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[Error message] [Debug log]
Please fix these to complete your PR View the build log or the debug log for each test
@DrFaust92 review ownership transitioned to another maintainer. Would be worth reexamining the comments to align with the new reviewers expectations.
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.
Diff report:
Terraform GA: Diff ( 2 files changed, 300 insertions(+)) Terraform Beta: Diff ( 8 files changed, 1971 insertions(+), 2 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 4 files changed, 120 insertions(+))
Tests analytics
Total tests: 2173
Passed tests 1932
Skipped tests: 238
Failed tests: 3
Action taken
Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample
Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]
Please fix these to complete your PR View the build log or the debug log for each test
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.
Diff report:
Terraform GA: Diff ( 2 files changed, 349 insertions(+)) Terraform Beta: Diff ( 8 files changed, 2072 insertions(+), 2 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 8 files changed, 266 insertions(+))
Tests analytics
Total tests: 2174
Passed tests 1933
Skipped tests: 238
Failed tests: 3
Action taken
Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccAlloydbCluster_alloydbClusterFullExample
Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccAlloydbCluster_alloydbClusterFullExample[Debug log]
Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
Please fix these to complete your PR View the build log or the debug log for each test
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.
Diff report:
Terraform GA: Diff ( 2 files changed, 349 insertions(+)) Terraform Beta: Diff ( 8 files changed, 2073 insertions(+), 2 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 8 files changed, 266 insertions(+))
Tests analytics
Total tests: 2174
Passed tests 1934
Skipped tests: 238
Failed tests: 2
Action taken
Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample
Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]
Please fix these to complete your PR View the build log or the debug log for each test
melinath, ive addressed CR comments + some Qs. also ive added encryption_config arg that was newly added to api
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.
Diff report:
Terraform GA: Diff ( 2 files changed, 400 insertions(+)) Terraform Beta: Diff ( 8 files changed, 2303 insertions(+), 2 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 8 files changed, 295 insertions(+))
Tests analytics
Total tests: 2177
Passed tests 1934
Skipped tests: 238
Failed tests: 5
Action taken
Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeInstance_soleTenantNodeAffinities|TestAccAlloydbCluster_alloydbClusterBasicExample|TestAccAlloydbCluster_update|TestAccAlloydbCluster_alloydbClusterFullExample|TestAccFirebaserulesRelease_BasicRelease
Tests passed during RECORDING mode:
TestAccAlloydbCluster_alloydbClusterBasicExample[Debug log]
TestAccAlloydbCluster_update[Debug log]
TestAccAlloydbCluster_alloydbClusterFullExample[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
Please fix these to complete your PR View the build log or the debug log for each test
Hi, I was on vacation, I’ll be looking at this PR in the coming days.
On Thu, 29 Sep 2022 at 23:39 Stephen Lewis (Burrows) < @.***> wrote:
@DrFaust92 https://github.com/DrFaust92 just want to check in that you're still working on this?
— Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/magic-modules/pull/6507#issuecomment-1262789381, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIA2W7VWYAWKODODOFHGB3TWAX46TANCNFSM6AAAAAAQDY2UN4 . You are receiving this because you were mentioned.Message ID: @.***>
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.
Diff report:
Terraform GA: Diff ( 2 files changed, 400 insertions(+)) Terraform Beta: Diff ( 8 files changed, 2303 insertions(+), 2 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 8 files changed, 295 insertions(+))
Tests analytics
Total tests: 2196
Passed tests 1954
Skipped tests: 240
Failed tests: 2
Action taken
Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample
Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]
Please fix these to complete your PR View the build log or the debug log for each test
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.
Diff report:
Terraform GA: Diff ( 2 files changed, 377 insertions(+)) Terraform Beta: Diff ( 8 files changed, 2140 insertions(+), 2 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 8 files changed, 295 insertions(+))
Tests analytics
Total tests: 2196
Passed tests 1953
Skipped tests: 240
Failed tests: 3
Action taken
Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample
Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]
Please fix these to complete your PR View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've sorted out the following information about your changes, here it is - !
Diff report
Terraform GA: Diff ( 2 files changed, 326 insertions(+)) Terraform Beta: Diff ( 10 files changed, 1926 insertions(+), 2 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 8 files changed, 266 insertions(+))
Tests analytics
Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0
Errors occurred during REPLAYING mode. Please fix them to complete your PR View the build log