magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

make role_arn computed in storage transfer job

Open c2thorn opened this issue 1 year ago • 4 comments

fixes https://github.com/hashicorp/terraform-provider-google/issues/11535

The API can return an empty string for role ARN when not specified. Unable to replicate, but setting to computed should resolve

Release Note Template for Downstream PRs (will be copied)

storagetransfer: fixed a bug in `google_storage_transfer_job` that caused a permanent diff on `role_arn`

c2thorn avatar Sep 01 '22 17:09 c2thorn

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+)) Terraform Beta: Diff ( 1 file changed, 1 insertion(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Sep 01 '22 17:09 modular-magician

Tests analytics

Total tests: 2154 Passed tests 1913 Skipped tests: 234 Failed tests: 7

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccFirebaserulesRelease_BasicRelease|TestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccComputeInstance_soleTenantNodeAffinities

modular-magician avatar Sep 01 '22 18:09 modular-magician

Tests passed during RECORDING mode: TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[Debug log] TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode: TestAccSqlDatabaseInstance_SqlServerAuditConfig[Error message] [Debug log] TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[Error message] [Debug log] TestAccComputeGlobalForwardingRule_internalLoadBalancing[Error message] [Debug log] TestAccCloudRunService_cloudRunServiceStaticOutboundExample[Error message] [Debug log] TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Sep 01 '22 19:09 modular-magician

Sorry for the spam @melinath, taking this PR back into draft. feel free to unsubscribe to avoid more messages

c2thorn avatar Sep 01 '22 19:09 c2thorn