magic-modules
magic-modules copied to clipboard
remove forceNew on display_name
Fixes https://github.com/hashicorp/terraform-provider-google/issues/12262
If this PR is for Terraform, I acknowledge that I have:
- [x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
- [x] Generated Terraform, and ran
make test
andmake lint
to ensure it passes unit and linter tests. - [x] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
- [x] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
- [x] Read the Release Notes Guide before writing my release note below.
Release Note Template for Downstream PRs (will be copied)
BigQuery Data Transfer: removed force replacement for `display_name` on `google_bigquery_data_transfer_config`
Hello! I am a robot who works on Magic Modules PRs.
I've detected that you're a community contributor. @c2thorn, a repository maintainer, has been assigned to assist you and help review your changes.
:question: First time contributing? Click here for more details
Your assigned reviewer will help review your code by:
- Ensuring it's backwards compatible, covers common error cases, etc.
- Summarizing the change into a user-facing changelog note.
- Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.
If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.
Diff report:
Terraform GA: Diff ( 2 files changed, 25 insertions(+), 6 deletions(-)) Terraform Beta: Diff ( 2 files changed, 25 insertions(+), 6 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
Tests analytics
Total tests: 2125
Passed tests 1888
Skipped tests: 227
Failed tests: 10
Action taken
Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_networkPerformanceConfig|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccCloudFunctions2Function_fullUpdate|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample
Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease
[view]
TestAccCGCSnippet_eventarcWorkflowsExample
[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample
[view]
TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample
[view]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample
[view]
TestAccCloudFunctions2Function_fullUpdate
[view]
Tests failed during RECORDING mode:
TestAccComputeInstance_networkPerformanceConfig
[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing
[view]
TestAccComputeInstance_soleTenantNodeAffinities
[view]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample
[view]
Please fix these to complete your PR View the build log or the debug log for each test
Looks like this didn't run in VCR, i'm assuming you ran the test successfully in teamcity and/or locally?
Also the release note should say bigquery:
I believe
@c2thorn yes I did run the test successfully locally, but not in teamcity. Updated the release note to lower case on bigquery: