magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Revert "Innocuous change to exercise docker image changes"

Open melinath opened this issue 2 years ago • 19 comments

Reverts GoogleCloudPlatform/magic-modules#6337 to exercise the ci pipeline again

Release note

melinath avatar Jul 29 '22 16:07 melinath

Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:

```release-note:TYPE
Release note
```

modular-magician avatar Jul 29 '22 16:07 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-)) Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-)) TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

modular-magician avatar Jul 29 '22 16:07 modular-magician

Tests analytics

Total tests: 2126 Passed tests 1892 Skipped tests: 226 Failed tests: 8

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withMeshCertificatesConfig|TestAccComputeInstance_soleTenantNodeAffinities|TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample|TestAccActiveDirectoryDomain_update|TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample

modular-magician avatar Jul 29 '22 17:07 modular-magician

/gcbrun now that lint timeout has increased

melinath avatar Jul 29 '22 17:07 melinath

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-)) Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-)) TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

modular-magician avatar Jul 29 '22 18:07 modular-magician

/gcbrun - one lint passed; the other failed. retrying in case it was a timing thing somehow.

melinath avatar Jul 29 '22 18:07 melinath

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-)) Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-)) TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

modular-magician avatar Jul 29 '22 18:07 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-)) Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-)) TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

modular-magician avatar Jul 29 '22 18:07 modular-magician

Tests analytics

Total tests: 2122 Passed tests 1889 Skipped tests: 226 Failed tests: 7

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample|TestAccActiveDirectoryDomain_update

modular-magician avatar Jul 29 '22 18:07 modular-magician

Tests analytics

Total tests: 2122 Passed tests 1891 Skipped tests: 226 Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample|TestAccActiveDirectoryDomain_update|TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample|TestAccComputeInstance_soleTenantNodeAffinities

modular-magician avatar Jul 29 '22 19:07 modular-magician

Tests analytics

Total tests: 2122 Passed tests 1889 Skipped tests: 226 Failed tests: 7

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample|TestAccActiveDirectoryDomain_update|TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample|TestAccCGCSnippet_eventarcWorkflowsExample

modular-magician avatar Jul 29 '22 19:07 modular-magician

Tests passed during RECORDING mode: TestAccContainerCluster_withMeshCertificatesConfig[view] TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode: TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample[view] TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view] TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view] TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample[view] TestAccComputeInstance_soleTenantNodeAffinities[view] TestAccActiveDirectoryDomain_update[view]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Jul 29 '22 19:07 modular-magician

Tests passed during RECORDING mode: TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]

Tests failed during RECORDING mode: TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample[view] TestAccComputeInstance_soleTenantNodeAffinities[view] TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample[view] TestAccActiveDirectoryDomain_update[view]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Jul 29 '22 21:07 modular-magician

Tests passed during RECORDING mode: TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view] TestAccFirebaserulesRelease_BasicRelease[view] TestAccCGCSnippet_eventarcWorkflowsExample[view]

Tests failed during RECORDING mode: TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample[view] TestAccComputeInstance_soleTenantNodeAffinities[view] TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample[view] TestAccActiveDirectoryDomain_update[view]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Jul 29 '22 21:07 modular-magician

Tests passed during RECORDING mode: TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view] TestAccFirebaserulesRelease_BasicRelease[view] TestAccCGCSnippet_eventarcWorkflowsExample[view]

Tests failed during RECORDING mode: TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample[view] TestAccComputeInstance_soleTenantNodeAffinities[view] TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample[view] TestAccActiveDirectoryDomain_update[view]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Jul 29 '22 21:07 modular-magician

/gcbrun

melinath avatar Aug 01 '22 20:08 melinath

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-)) Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-)) TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

modular-magician avatar Aug 01 '22 20:08 modular-magician

Tests analytics

Total tests: 2122 Passed tests 1888 Skipped tests: 226 Failed tests: 8

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccActiveDirectoryDomain_update|TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample

modular-magician avatar Aug 01 '22 20:08 modular-magician

Tests passed during RECORDING mode: TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view] TestAccFirebaserulesRelease_BasicRelease[view] TestAccCGCSnippet_eventarcWorkflowsExample[view]

Tests failed during RECORDING mode: TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample[view] TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view] TestAccComputeInstance_soleTenantNodeAffinities[view] TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample[view] TestAccActiveDirectoryDomain_update[view]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Aug 01 '22 23:08 modular-magician