magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Add support for Password Validation Policy in cloud sql instance.

Open usingh83 opened this issue 2 years ago • 56 comments

If this PR is for Terraform, I acknowledge that I have:

  • [X] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [X] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [X] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [X] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [X] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

sql: added `password_validation_policy` field to `google_cloud_sql` resource

usingh83 avatar Jul 27 '22 11:07 usingh83

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jul 27 '22 11:07 google-cla[bot]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician avatar Jul 27 '22 11:07 modular-magician

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @shuyama1, a repository maintainer, has been assigned to assist you and help review your changes.

:question: First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


modular-magician avatar Jul 27 '22 11:07 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 119 insertions(+), 27 deletions(-)) Terraform Beta: Diff ( 1 file changed, 119 insertions(+), 27 deletions(-)) TF Validator: Diff ( 6 files changed, 129 insertions(+), 25 deletions(-)) TF Cloud Doc Samples: Diff ( 1 file changed, 38 insertions(+))

modular-magician avatar Jul 27 '22 11:07 modular-magician

Tests analytics

Total tests: 2122 Passed tests 1891 Skipped tests: 226 Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample

modular-magician avatar Jul 27 '22 11:07 modular-magician

Tests passed during RECORDING mode: TestAccCGCSnippet_eventarcWorkflowsExample[view] TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode: TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view] TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view] TestAccComputeInstance_soleTenantNodeAffinities[view]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Jul 27 '22 12:07 modular-magician

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician avatar Aug 01 '22 14:08 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 218 insertions(+), 33 deletions(-)) Terraform Beta: Diff ( 3 files changed, 218 insertions(+), 33 deletions(-)) TF Validator: Diff ( 6 files changed, 129 insertions(+), 25 deletions(-)) TF Cloud Doc Samples: Diff ( 2 files changed, 40 insertions(+))

modular-magician avatar Aug 01 '22 14:08 modular-magician

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician avatar Aug 01 '22 15:08 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 218 insertions(+), 33 deletions(-)) Terraform Beta: Diff ( 3 files changed, 218 insertions(+), 33 deletions(-)) TF Validator: Diff ( 6 files changed, 93 insertions(+), 25 deletions(-)) TF Cloud Doc Samples: Diff ( 2 files changed, 40 insertions(+))

modular-magician avatar Aug 01 '22 15:08 modular-magician

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician avatar Aug 01 '22 15:08 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 218 insertions(+), 33 deletions(-)) Terraform Beta: Diff ( 3 files changed, 218 insertions(+), 33 deletions(-)) TF Validator: Diff ( 6 files changed, 105 insertions(+), 25 deletions(-)) TF Cloud Doc Samples: Diff ( 2 files changed, 40 insertions(+))

modular-magician avatar Aug 01 '22 15:08 modular-magician

Tests analytics

Total tests: 2124 Passed tests 1888 Skipped tests: 226 Failed tests: 10

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_sqlPostgresInstancePvpExample|TestAccCGCSnippet_sqlMysqlInstancePvpExample|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample|TestAccActiveDirectoryDomain_update|TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample

modular-magician avatar Aug 01 '22 16:08 modular-magician

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician avatar Aug 01 '22 17:08 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 218 insertions(+), 33 deletions(-)) Terraform Beta: Diff ( 3 files changed, 218 insertions(+), 33 deletions(-)) TF Validator: Diff ( 6 files changed, 105 insertions(+), 25 deletions(-)) TF Cloud Doc Samples: Diff ( 2 files changed, 40 insertions(+))

modular-magician avatar Aug 01 '22 17:08 modular-magician

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician avatar Aug 01 '22 17:08 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 218 insertions(+), 33 deletions(-)) Terraform Beta: Diff ( 3 files changed, 218 insertions(+), 33 deletions(-)) TF Validator: Diff ( 6 files changed, 105 insertions(+), 25 deletions(-)) TF Cloud Doc Samples: Diff ( 2 files changed, 40 insertions(+))

modular-magician avatar Aug 01 '22 17:08 modular-magician

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician avatar Aug 01 '22 17:08 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 218 insertions(+), 33 deletions(-)) Terraform Beta: Diff ( 3 files changed, 218 insertions(+), 33 deletions(-)) TF Validator: Diff ( 3 files changed, 8 insertions(+), 7 deletions(-)) TF Cloud Doc Samples: Diff ( 2 files changed, 40 insertions(+))

modular-magician avatar Aug 01 '22 18:08 modular-magician

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician avatar Aug 01 '22 18:08 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 218 insertions(+), 33 deletions(-)) Terraform Beta: Diff ( 3 files changed, 218 insertions(+), 33 deletions(-)) TF Validator: Diff ( 3 files changed, 7 insertions(+), 7 deletions(-)) TF Cloud Doc Samples: Diff ( 2 files changed, 40 insertions(+))

modular-magician avatar Aug 01 '22 18:08 modular-magician

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician avatar Aug 01 '22 18:08 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 218 insertions(+), 33 deletions(-)) Terraform Beta: Diff ( 3 files changed, 218 insertions(+), 33 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF Cloud Doc Samples: Diff ( 2 files changed, 40 insertions(+))

modular-magician avatar Aug 01 '22 18:08 modular-magician

Tests analytics

Total tests: 2124 Passed tests 1888 Skipped tests: 226 Failed tests: 10

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_sqlPostgresInstancePvpExample|TestAccCGCSnippet_sqlMysqlInstancePvpExample|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample|TestAccActiveDirectoryDomain_update|TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccSqlUser_mysqlDisabled

modular-magician avatar Aug 01 '22 19:08 modular-magician

Tests passed during RECORDING mode: TestAccSqlUser_mysqlDisabled[view] TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view] TestAccCGCSnippet_eventarcWorkflowsExample[view]

Tests failed during RECORDING mode: TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample[view] TestAccCGCSnippet_sqlPostgresInstancePvpExample[view] TestAccComputeInstance_soleTenantNodeAffinities[view] TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view] TestAccCGCSnippet_sqlMysqlInstancePvpExample[view] TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample[view] TestAccActiveDirectoryDomain_update[view]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Aug 01 '22 23:08 modular-magician

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician avatar Aug 02 '22 00:08 modular-magician

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician avatar Aug 02 '22 00:08 modular-magician

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician avatar Aug 02 '22 00:08 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 217 insertions(+), 33 deletions(-)) Terraform Beta: Diff ( 3 files changed, 217 insertions(+), 33 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF Cloud Doc Samples: Diff ( 2 files changed, 39 insertions(+))

modular-magician avatar Aug 02 '22 00:08 modular-magician

Tests analytics

Total tests: 2124 Passed tests 1889 Skipped tests: 226 Failed tests: 9

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_sqlPostgresInstancePvpExample|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample|TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample|TestAccActiveDirectoryDomain_update|TestAccCGCSnippet_sqlMysqlInstancePvpExample

modular-magician avatar Aug 02 '22 01:08 modular-magician