magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Update self-managed Cert Manager fields

Open alekssaul opened this issue 2 years ago • 6 comments

GCP API fields for self-managed certificates are pemCertificate and pemPrivateKey . However the existing terraform code refers to them as certificatePem and privatekeyPem ( https://cloud.google.com/certificate-manager/docs/reference/rest/v1/projects.locations.certificates#SelfManagedCertificate ) .

Terraform Issue: https://github.com/hashicorp/terraform-provider-google/issues/12091 Terraform PR: https://github.com/hashicorp/terraform-provider-google/pull/12092

If this PR is for Terraform, I acknowledge that I have:

  • [x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [x] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [x] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [x] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [x] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

certificatemanager: updated public/private PEM fields `certificatePem` / `privatekeyPem` to `pemCertificate` / `pemPrivateKey` 

alekssaul avatar Jul 14 '22 16:07 alekssaul

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @scottsuarez, a repository maintainer, has been assigned to assist you and help review your changes.

:question: First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


modular-magician avatar Jul 14 '22 16:07 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 19 insertions(+), 19 deletions(-)) Terraform Beta: Diff ( 2 files changed, 19 insertions(+), 19 deletions(-)) TF Validator: Diff ( 3 files changed, 11 insertions(+), 11 deletions(-))

modular-magician avatar Jul 14 '22 17:07 modular-magician

I see, looks like this is due to a pre beta form of the resource still existing

ScottSuarez avatar Jul 14 '22 17:07 ScottSuarez

Would it be possible to add a test for this field?

ScottSuarez avatar Jul 14 '22 17:07 ScottSuarez

Tests analytics

Total tests: 2096 Passed tests 1867 Skipped tests: 226 Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccSqlUser_mysqlDisabled|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation

modular-magician avatar Jul 14 '22 17:07 modular-magician

Tests passed during RECORDING mode: TestAccSqlUser_mysqlDisabled[view]

Tests failed during RECORDING mode: TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view] TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Jul 14 '22 17:07 modular-magician

Updated the fields and added example with them in https://github.com/GoogleCloudPlatform/magic-modules/pull/6447

pawel-grz-krawczyk avatar Aug 23 '22 15:08 pawel-grz-krawczyk

superseded by https://github.com/GoogleCloudPlatform/magic-modules/pull/6447

ScottSuarez avatar Aug 23 '22 18:08 ScottSuarez