magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

add datafusion instance versions in attempt to keep our tests up to date

Open megan07 opened this issue 2 years ago • 6 comments

If this PR is for Terraform, I acknowledge that I have:

  • [ ] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [ ] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [ ] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [ ] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [ ] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_data_fusion_instance_versions`

megan07 avatar Jun 24 '22 19:06 megan07

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 169 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 5 files changed, 169 insertions(+), 2 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 1 file changed, 5 insertions(+), 1 deletion(-))

modular-magician avatar Jun 24 '22 20:06 modular-magician

Tests analytics

Total tests: 2055 Passed tests 1826 Skipped tests: 226 Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccDataFusionInstance_dataFusionInstanceFullExample|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withAddons

modular-magician avatar Jun 24 '22 20:06 modular-magician

Tests failed during RECORDING mode: TestAccContainerCluster_withAddons[view] TestAccDataFusionInstance_dataFusionInstanceFullExample[view] TestAccContainerCluster_withConfidentialNodes[view]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Jun 24 '22 21:06 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 195 insertions(+), 4 deletions(-)) Terraform Beta: Diff ( 5 files changed, 195 insertions(+), 4 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 1 file changed, 18 insertions(+), 2 deletions(-))

modular-magician avatar Jun 27 '22 20:06 modular-magician

Tests analytics

Total tests: 2055 Passed tests 1825 Skipped tests: 226 Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccFirebaserulesRelease_BasicRelease|TestAccDataFusionInstance_dataFusionInstanceFullExample|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withAddons

modular-magician avatar Jun 27 '22 20:06 modular-magician

Tests passed during RECORDING mode: TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode: TestAccContainerCluster_withAddons[view] TestAccDataFusionInstance_dataFusionInstanceFullExample[view] TestAccContainerCluster_withConfidentialNodes[view]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Jun 27 '22 21:06 modular-magician