magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Published 20 hours ago • verified publisher icon GoogleCloudPlatform

Add support for network tags in Autopilot clusters and NAP node pools

Open mikesmitty opened this issue 2 years ago • 70 comments

Hey, I took a stab at adding support for network tags on Autopilot clusters and NAP node pools. The placement and naming of the field were a bit tricky since the same API is used for both Autopilot and NAP, but I'm open to suggestions.

I also added a pair of new acceptance tests to go along with it that I believe should pass, but I haven't been able to run them since they violate my company's org-level GCP constraints. I did however do manual tests provisioning/updating autopilot clusters and they were successful. I expect NAP clusters should work fine given it's the same API call, but I wanted to get the PR submitted for comments and to make sure the acceptance tests run successfully.

fixes hashicorp/terraform-provider-google#11051

If this PR is for Terraform, I acknowledge that I have:

  • [X] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [X] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [X] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [X] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [X] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: added field `auto_provisioning_network_tags` to `google_container_cluster` (beta)

mikesmitty avatar Jun 15 '22 22:06 mikesmitty

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes.

:question: First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

modular-magician avatar Jun 15 '22 22:06 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 18 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 2 files changed, 112 insertions(+), 9 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Jun 15 '22 23:06 modular-magician

Tests analytics

Total tests: 2055 Passed tests 1725 Skipped tests: 226 Failed tests: 104

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccGKEHubMembership_gkehubMembershipIssuerExample|TestAccGKEHubMembership_gkehubMembershipBasicExample|TestAccContainerNodePool_compactPlacement|TestAccContainerCluster_withMonitoringConfig|TestAccContainerNodePool_gvnic|TestAccContainerCluster_withLoggingConfig|TestAccContainerNodePool_gcfsConfig|TestAccContainerCluster_withAutopilotNetworkTags|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerCluster_withIdentityServiceConfig|TestAccContainerNodePool_withNetworkConfig|TestAccContainerNodePool_ephemeralStorageConfig|TestAccContainerNodePool_shieldedInstanceConfig|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerNodePool_withKubeletConfig|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_withSandboxConfig|TestAccContainerNodePool_regionalClusters|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerNodePool_withNodeConfig|TestAccContainerCluster_errorAutopilotLocation|TestAccContainerCluster_nodeAutoprovisioningNetworkTags|TestAccContainerCluster_withAutopilot|TestAccContainerCluster_withShieldedNodes|TestAccContainerNodePool_version|TestAccContainerNodePool_resize|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_basicWithClusterId|TestAccContainerNodePool_nodeLocations|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerNodePool_basic|TestAccContainerCluster_nodeAutoprovisioning|TestAccContainerNodePool_withNodeConfigScopeAlias|TestAccContainerCluster_withTPUConfig|TestAccContainerNodePool_withManagement|TestAccContainerCluster_withDNSConfig|TestAccContainerCluster_withIPAllocationPolicy_specificSizes|TestAccContainerNodePool_withGPU|TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges|TestAccContainerCluster_withEnableKubernetesAlpha|TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges|TestAccContainerCluster_withNodePoolBasic|TestAccContainerCluster_deleteExclusionWindow|TestAccContainerCluster_updateMaintenanceExclusionOptions|TestAccContainerCluster_backend|TestAccContainerCluster_network|TestAccContainerCluster_withMasterAuthorizedNetworksDisabled|TestAccContainerCluster_withSandboxConfig|TestAccContainerCluster_withAdvancedDatapath|TestAccContainerCluster_withWorkloadMetadataConfig|TestAccContainerCluster_withILBSubsetting|TestAccContainerCluster_withResourceUsageExportConfig|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withNodeConfigShieldedInstanceConfig|TestAccContainerCluster_withNodeConfigScopeAlias|TestAccContainerCluster_withNodeConfig|TestAccContainerCluster_withDatabaseEncryption|TestAccContainerCluster_errorNoClusterCreated|TestAccContainerCluster_withNotificationConfig|TestAccContainerCluster_misc|TestAccContainerCluster_networkingModeRoutes|TestAccContainerCluster_withIntraNodeVisibility|TestAccContainerCluster_withAddons|TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType|TestAccContainerCluster_withBinaryAuthorization|TestAccContainerCluster_updateVersion|TestAccContainerCluster_withVersion|TestAccContainerCluster_errorCleanDanglingCluster|TestAccContainerCluster_withFlexiblePodCIDR|TestAccContainerCluster_withAutoscalingProfile|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock_withAutopilot|TestAccContainerCluster_basic|TestAccContainerCluster_regionalWithNodeLocations|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_withPrivateClusterConfig|TestAccContainerCluster_nodeAutoprovisioningDefaultsMinCpuPlatform|TestAccContainerCluster_regional|TestAccContainerCluster_withTpu|TestAccContainerCluster_withSoleTenantGroup|TestAccContainerCluster_withBootDiskKmsKey|TestAccContainerCluster_withMasterAuthorizedNetworksConfig|TestAccContainerCluster_withTelemetryEnabled|TestAccContainerCluster_withReleaseChannelEnabled|TestAccContainerCluster_deleteMaintenanceExclusionOptions|TestAccContainerCluster_withMaintenanceExclusionOptions|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_withNetworkPolicyEnabled|TestAccContainerCluster_withMaintenanceWindow|TestAccContainerCluster_withMaintenanceExclusionWindow|TestAccContainerCluster_withRecurringMaintenanceWindow|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_withMasterAuthConfig_NoCert|TestAccContainerCluster_withNodePoolNodeConfig|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccContainerCluster_withNodePoolMultiple|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerCluster_withNodePoolResize|TestAccContainerCluster_withNodePoolUpdateVersion|TestAccContainerClusterDatasource_regional|TestAccContainerClusterDatasource_zonal

modular-magician avatar Jun 15 '22 23:06 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 18 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 2 files changed, 112 insertions(+), 9 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Jun 16 '22 02:06 modular-magician

Tests analytics

Total tests: 2055 Passed tests 1724 Skipped tests: 226 Failed tests: 105

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccContainerNodePool_withManagement|TestAccContainerCluster_withSoleTenantGroup|TestAccContainerCluster_withMonitoringConfig|TestAccGKEHubMembership_gkehubMembershipIssuerExample|TestAccGKEHubMembership_gkehubMembershipBasicExample|TestAccContainerCluster_withLoggingConfig|TestAccContainerCluster_withAutopilotNetworkTags|TestAccContainerCluster_withIdentityServiceConfig|TestAccContainerNodePool_withGPU|TestAccContainerCluster_withNodePoolUpdateVersion|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerCluster_nodeAutoprovisioningNetworkTags|TestAccContainerCluster_withNodePoolBasic|TestAccContainerCluster_withShieldedNodes|TestAccContainerCluster_errorAutopilotLocation|TestAccContainerCluster_withAutopilot|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerNodePool_withNetworkConfig|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_nodeAutoprovisioning|TestAccContainerNodePool_withKubeletConfig|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerNodePool_withSandboxConfig|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerNodePool_withNodeConfig|TestAccContainerNodePool_compactPlacement|TestAccContainerNodePool_gvnic|TestAccContainerNodePool_nodeLocations|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerNodePool_basicWithClusterId|TestAccContainerNodePool_basic|TestAccContainerCluster_withIPAllocationPolicy_specificSizes|TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges|TestAccContainerNodePool_gcfsConfig|TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges|TestAccContainerCluster_deleteExclusionWindow|TestAccContainerNodePool_ephemeralStorageConfig|TestAccContainerCluster_withTPUConfig|TestAccContainerCluster_updateMaintenanceExclusionOptions|TestAccContainerNodePool_shieldedInstanceConfig|TestAccContainerCluster_deleteMaintenanceExclusionOptions|TestAccContainerCluster_backend|TestAccContainerCluster_withNotificationConfig|TestAccContainerCluster_withDNSConfig|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerCluster_withMaintenanceExclusionOptions|TestAccContainerCluster_withAddons|TestAccContainerCluster_withMaintenanceExclusionWindow|TestAccContainerCluster_misc|TestAccContainerCluster_network|TestAccContainerCluster_withEnableKubernetesAlpha|TestAccContainerCluster_networkingModeRoutes|TestAccContainerCluster_withNodeConfigShieldedInstanceConfig|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerCluster_withSandboxConfig|TestAccContainerCluster_basic|TestAccContainerCluster_withWorkloadMetadataConfig|TestAccContainerCluster_withAdvancedDatapath|TestAccContainerNodePool_regionalClusters|TestAccContainerCluster_withNodeConfigScopeAlias|TestAccContainerCluster_withMasterAuthorizedNetworksDisabled|TestAccContainerCluster_withResourceUsageExportConfig|TestAccContainerCluster_withNodeConfig|TestAccContainerCluster_errorNoClusterCreated|TestAccContainerCluster_withDatabaseEncryption|TestAccContainerCluster_updateVersion|TestAccContainerCluster_withRecurringMaintenanceWindow|TestAccContainerCluster_withVersion|TestAccContainerCluster_withMaintenanceWindow|TestAccContainerCluster_withIntraNodeVisibility|TestAccContainerCluster_errorCleanDanglingCluster|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerNodePool_resize|TestAccContainerNodePool_version|TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock_withAutopilot|TestAccContainerNodePool_autoscaling|TestAccContainerCluster_withBootDiskKmsKey|TestAccContainerCluster_withFlexiblePodCIDR|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerCluster_withNodePoolMultiple|TestAccContainerCluster_withBinaryAuthorization|TestAccContainerCluster_withAutoscalingProfile|TestAccContainerNodePool_withNodeConfigScopeAlias|TestAccContainerCluster_nodeAutoprovisioningDefaultsMinCpuPlatform|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerCluster_withNodePoolResize|TestAccContainerCluster_withPrivateClusterConfig|TestAccContainerCluster_withTpu|TestAccContainerCluster_regionalWithNodeLocations|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_regional|TestAccContainerCluster_withMasterAuthorizedNetworksConfig|TestAccContainerCluster_withTelemetryEnabled|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_withReleaseChannelEnabled|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_withMasterAuthConfig_NoCert|TestAccContainerCluster_withILBSubsetting|TestAccContainerCluster_withNetworkPolicyEnabled|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccSqlUser_mysqlDisabled|TestAccContainerClusterDatasource_regional|TestAccContainerClusterDatasource_zonal

modular-magician avatar Jun 16 '22 03:06 modular-magician

The provider crashed while running the VCR tests in RECORDING mode Please fix it to complete your PR View the build log

modular-magician avatar Jun 16 '22 07:06 modular-magician

It looks like I'm not able to see the crash logs, but I'd be happy to take a look at fixing them. I did run the acceptance tests I added as well as the adjacent tests and they all complete successfully:

==> output-TestAccContainerCluster_errorAutopilotLocation.log <==
--- PASS: TestAccContainerCluster_errorAutopilotLocation (91.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-google-beta/google-beta	92.763s

==> output-TestAccContainerCluster_nodeAutoprovisioning.log <==
--- PASS: TestAccContainerCluster_nodeAutoprovisioning (1085.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-google-beta/google-beta	1086.971s

==> output-TestAccContainerCluster_nodeAutoprovisioningDefaults.log <==
--- PASS: TestAccContainerCluster_nodeAutoprovisioningDefaultsMinCpuPlatform (700.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-google-beta/google-beta	702.052s

==> output-TestAccContainerCluster_nodeAutoprovisioningNetworkTags.log <==
--- PASS: TestAccContainerCluster_nodeAutoprovisioningNetworkTags (664.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-google-beta/google-beta	665.508s

==> output-TestAccContainerCluster_withAutopilot.log <==
--- PASS: TestAccContainerCluster_withAutopilot (833.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-google-beta/google-beta	834.769s

==> output-TestAccContainerCluster_withAutopilotNetworkTags.log <==
--- PASS: TestAccContainerCluster_withAutopilotNetworkTags (838.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-google-beta/google-beta	839.481s

mikesmitty avatar Jun 16 '22 17:06 mikesmitty

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 18 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 2 files changed, 155 insertions(+), 9 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Jun 17 '22 22:06 modular-magician

Tests analytics

Total tests: 2055 Passed tests 1805 Skipped tests: 226 Failed tests: 24

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccContainerNodePool_withGPU|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerCluster_withAutopilotNetworkTags|TestAccContainerCluster_nodeAutoprovisioningNetworkTags|TestAccContainerCluster_withShieldedNodes|TestAccContainerNodePool_compactPlacement|TestAccContainerNodePool_ephemeralStorageConfig|TestAccContainerNodePool_shieldedInstanceConfig|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerCluster_withConfidentialNodes|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_regionalClusters|TestAccContainerCluster_withAddons|TestAccContainerNodePool_version|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_resize|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerNodePool_withNodeConfigScopeAlias|TestAccContainerNodePool_withManagement|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccGKEHubMembership_gkehubMembershipIssuerExample|TestAccGKEHubMembership_gkehubMembershipBasicExample|TestAccContainerClusterDatasource_zonal|TestAccFirebaserulesRelease_BasicRelease

modular-magician avatar Jun 17 '22 23:06 modular-magician

The provider crashed while running the VCR tests in RECORDING mode Please fix it to complete your PR View the build log

modular-magician avatar Jun 18 '22 03:06 modular-magician

It looks like the failure was due to the tests timing out after four hours. That seems odd, since only 24 tests went to Recording mode; I'll initiate a re-run. /gcbrun

melinath avatar Jun 21 '22 15:06 melinath

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 18 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 2 files changed, 155 insertions(+), 9 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Jun 21 '22 15:06 modular-magician

Tests analytics

Total tests: 2055 Passed tests 1825 Skipped tests: 226 Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withShieldedNodes|TestAccContainerCluster_withAddons|TestAccContainerCluster_nodeAutoprovisioningNetworkTags

modular-magician avatar Jun 21 '22 16:06 modular-magician

Tests passed during RECORDING mode: TestAccContainerCluster_withShieldedNodes[view] TestAccContainerCluster_nodeAutoprovisioningNetworkTags[view]

Tests failed during RECORDING mode: TestAccContainerCluster_withAddons[view] TestAccContainerCluster_withConfidentialNodes[view]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Jun 21 '22 16:06 modular-magician

TestAccContainerCluster_withAddons and TestAccContainerCluster_withConfidentialNodes are failing on all PRs right now, so they're probably unrelated.

melinath avatar Jun 21 '22 18:06 melinath

It looks like not all the tests I would expect got run in VCR - doing a manual run at https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/303886

melinath avatar Jun 21 '22 21:06 melinath

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 22 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 2 files changed, 161 insertions(+), 9 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Jun 22 '22 23:06 modular-magician

The provider crashed while running the VCR tests in REPLAYING mode Please fix it to complete your PR View the build log

modular-magician avatar Jun 22 '22 23:06 modular-magician

/gcbrun

melinath avatar Jun 23 '22 15:06 melinath

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 22 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 2 files changed, 161 insertions(+), 9 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Jun 23 '22 15:06 modular-magician

The provider crashed while running the VCR tests in REPLAYING mode Please fix it to complete your PR View the build log

modular-magician avatar Jun 23 '22 15:06 modular-magician

Whoops, I forgot to add the refactored flatten function and my temporary unconstrained project went away so I wasn't able to run the acceptance tests before pushing

mikesmitty avatar Jun 23 '22 16:06 mikesmitty

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 22 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 2 files changed, 165 insertions(+), 9 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Jun 23 '22 16:06 modular-magician

Tests analytics

Total tests: 2055 Passed tests 1728 Skipped tests: 226 Failed tests: 101

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccGKEHubMembership_gkehubMembershipIssuerExample|TestAccGKEHubMembership_gkehubMembershipBasicExample|TestAccFirebaserulesRelease_BasicRelease|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerNodePool_withKubeletConfig|TestAccContainerNodePool_withSandboxConfig|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerNodePool_withNodeConfig|TestAccContainerNodePool_compactPlacement|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerNodePool_gvnic|TestAccContainerNodePool_nodeLocations|TestAccContainerNodePool_gcfsConfig|TestAccContainerNodePool_basicWithClusterId|TestAccContainerNodePool_ephemeralStorageConfig|TestAccContainerCluster_withDNSConfig|TestAccContainerNodePool_basic|TestAccContainerCluster_withTPUConfig|TestAccContainerCluster_withIdentityServiceConfig|TestAccContainerNodePool_shieldedInstanceConfig|TestAccContainerCluster_withEnableKubernetesAlpha|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerCluster_withMasterAuthorizedNetworksDisabled|TestAccContainerCluster_withAdvancedDatapath|TestAccContainerCluster_withDatabaseEncryption|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_resize|TestAccContainerNodePool_regionalClusters|TestAccContainerCluster_errorCleanDanglingCluster|TestAccContainerCluster_withResourceUsageExportConfig|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerNodePool_version|TestAccContainerCluster_withFlexiblePodCIDR|TestAccContainerCluster_withBinaryAuthorization|TestAccContainerCluster_withAddons|TestAccContainerNodePool_withNodeConfigScopeAlias|TestAccContainerCluster_withAutoscalingProfile|TestAccContainerNodePool_withManagement|TestAccContainerCluster_withLoggingConfig|TestAccContainerCluster_withMonitoringConfig|TestAccContainerCluster_withSoleTenantGroup|TestAccContainerNodePool_withGPU|TestAccContainerCluster_nodeAutoprovisioningDefaultsMinCpuPlatform|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerNodePool_withNetworkConfig|TestAccContainerCluster_withSandboxConfig|TestAccContainerCluster_withWorkloadMetadataConfig|TestAccContainerCluster_misc|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerCluster_networkingModeRoutes|TestAccContainerCluster_withNodeConfigShieldedInstanceConfig|TestAccContainerCluster_withNodeConfigScopeAlias|TestAccContainerCluster_basic|TestAccContainerCluster_withNodeConfig|TestAccContainerCluster_updateVersion|TestAccContainerCluster_withVersion|TestAccContainerCluster_withIntraNodeVisibility|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock_withAutopilot|TestAccContainerCluster_withShieldedNodes|TestAccContainerCluster_withAutopilot|TestAccContainerCluster_withPrivateClusterConfig|TestAccContainerCluster_withTpu|TestAccContainerCluster_withBootDiskKmsKey|TestAccContainerCluster_regionalWithNodeLocations|TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_withIPAllocationPolicy_specificSizes|TestAccContainerCluster_regional|TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges|TestAccContainerCluster_withMasterAuthorizedNetworksConfig|TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_withTelemetryEnabled|TestAccContainerCluster_withReleaseChannelEnabled|TestAccContainerCluster_deleteExclusionWindow|TestAccContainerCluster_withNetworkPolicyEnabled|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_updateMaintenanceExclusionOptions|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withMasterAuthConfig_NoCert|TestAccContainerCluster_deleteMaintenanceExclusionOptions|TestAccContainerCluster_withILBSubsetting|TestAccContainerCluster_withMaintenanceExclusionOptions|TestAccContainerCluster_withNotificationConfig|TestAccContainerCluster_withMaintenanceExclusionWindow|TestAccContainerCluster_withMaintenanceWindow|TestAccContainerCluster_withRecurringMaintenanceWindow|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerCluster_nodeAutoprovisioning|TestAccContainerCluster_withNodePoolMultiple|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerCluster_withNodePoolResize|TestAccContainerCluster_withNodePoolBasic|TestAccContainerCluster_withNodePoolUpdateVersion|TestAccContainerCluster_backend|TestAccContainerCluster_network|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccContainerClusterDatasource_zonal|TestAccContainerClusterDatasource_regional

modular-magician avatar Jun 23 '22 17:06 modular-magician

The provider crashed while running the VCR tests in RECORDING mode Please fix it to complete your PR View the build log

modular-magician avatar Jun 23 '22 21:06 modular-magician

/gcbrun

melinath avatar Jun 24 '22 22:06 melinath

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 38 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 2 files changed, 165 insertions(+), 9 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Jun 24 '22 22:06 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 38 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 2 files changed, 165 insertions(+), 9 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Jun 24 '22 22:06 modular-magician

Tests analytics

Total tests: 2056 Passed tests 1728 Skipped tests: 226 Failed tests: 102

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccContainerClusterDatasource_regional|TestAccContainerClusterDatasource_zonal|TestAccGKEHubMembership_gkehubMembershipIssuerExample|TestAccGKEHubMembership_gkehubMembershipBasicExample|TestAccContainerNodePool_resize|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerNodePool_withNodeConfigScopeAlias|TestAccContainerNodePool_withManagement|TestAccContainerNodePool_withGPU|TestAccContainerCluster_withBinaryAuthorization|TestAccContainerCluster_withAutoscalingProfile|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerNodePool_withNetworkConfig|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerCluster_nodeAutoprovisioningDefaultsMinCpuPlatform|TestAccContainerCluster_deleteMaintenanceExclusionOptions|TestAccContainerNodePool_withKubeletConfig|TestAccContainerCluster_withSoleTenantGroup|TestAccContainerCluster_withMonitoringConfig|TestAccContainerCluster_withNodePoolResize|TestAccContainerNodePool_withSandboxConfig|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerNodePool_withNodeConfig|TestAccContainerCluster_withNodePoolUpdateVersion|TestAccContainerCluster_withLoggingConfig|TestAccContainerCluster_withNodePoolBasic|TestAccContainerCluster_withIdentityServiceConfig|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerCluster_backend|TestAccContainerNodePool_nodeLocations|TestAccContainerCluster_withILBSubsetting|TestAccContainerNodePool_basic|TestAccContainerCluster_network|TestAccContainerNodePool_basicWithClusterId|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withSandboxConfig|TestAccContainerCluster_withWorkloadMetadataConfig|TestAccContainerCluster_withTPUConfig|TestAccContainerCluster_withNodeConfigShieldedInstanceConfig|TestAccContainerCluster_withDNSConfig|TestAccContainerNodePool_compactPlacement|TestAccContainerCluster_withAutopilot|TestAccContainerCluster_withNodeConfigScopeAlias|TestAccContainerNodePool_gvnic|TestAccContainerCluster_withEnableKubernetesAlpha|TestAccContainerCluster_withNodeConfig|TestAccContainerCluster_withNotificationConfig|TestAccContainerCluster_updateVersion|TestAccContainerCluster_withMasterAuthorizedNetworksDisabled|TestAccContainerCluster_withAddons|TestAccContainerCluster_withResourceUsageExportConfig|TestAccContainerNodePool_gcfsConfig|TestAccContainerCluster_withAdvancedDatapath|TestAccContainerCluster_withDatabaseEncryption|TestAccContainerCluster_misc|TestAccContainerCluster_errorCleanDanglingCluster|TestAccContainerCluster_networkingModeRoutes|TestAccContainerNodePool_ephemeralStorageConfig|TestAccContainerCluster_withVersion|TestAccContainerNodePool_shieldedInstanceConfig|TestAccContainerCluster_withShieldedNodes|TestAccContainerCluster_withFlexiblePodCIDR|TestAccContainerCluster_withIntraNodeVisibility|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerCluster_basic|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock_withAutopilot|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_regionalClusters|TestAccContainerNodePool_version|TestAccContainerCluster_withPrivateClusterConfig|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_withBootDiskKmsKey|TestAccContainerCluster_withTpu|TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType|TestAccContainerCluster_regionalWithNodeLocations|TestAccContainerCluster_withIPAllocationPolicy_specificSizes|TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges|TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_deleteExclusionWindow|TestAccContainerCluster_updateMaintenanceExclusionOptions|TestAccContainerCluster_regional|TestAccContainerCluster_nodeAutoprovisioning|TestAccContainerCluster_withMaintenanceExclusionOptions|TestAccContainerCluster_withMasterAuthorizedNetworksConfig|TestAccContainerCluster_withTelemetryEnabled|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_withReleaseChannelEnabled|TestAccContainerCluster_withNetworkPolicyEnabled|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_withMasterAuthConfig_NoCert|TestAccContainerCluster_withMaintenanceExclusionWindow|TestAccContainerCluster_withRecurringMaintenanceWindow|TestAccContainerCluster_withMaintenanceWindow|TestAccContainerCluster_withNodePoolNodeConfig|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccContainerCluster_withNodePoolMultiple|TestAccContainerCluster_withNodePoolAutoscaling|TestAccBigQueryDataTable_bigtable|TestAccSqlUser_mysqlDisabled

modular-magician avatar Jun 24 '22 22:06 modular-magician

Tests analytics

Total tests: 2056 Passed tests 1730 Skipped tests: 226 Failed tests: 100

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccGKEHubMembership_gkehubMembershipIssuerExample|TestAccGKEHubMembership_gkehubMembershipBasicExample|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerNodePool_compactPlacement|TestAccContainerNodePool_gvnic|TestAccContainerNodePool_withKubeletConfig|TestAccContainerNodePool_withSandboxConfig|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerNodePool_withNodeConfig|TestAccContainerNodePool_gcfsConfig|TestAccContainerNodePool_ephemeralStorageConfig|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerNodePool_shieldedInstanceConfig|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_regionalClusters|TestAccContainerNodePool_nodeLocations|TestAccContainerNodePool_basicWithClusterId|TestAccContainerNodePool_basic|TestAccContainerCluster_withTPUConfig|TestAccContainerCluster_withDNSConfig|TestAccContainerNodePool_resize|TestAccContainerNodePool_version|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerCluster_withEnableKubernetesAlpha|TestAccContainerNodePool_withNodeConfigScopeAlias|TestAccContainerCluster_withMasterAuthorizedNetworksDisabled|TestAccContainerNodePool_withManagement|TestAccContainerCluster_withResourceUsageExportConfig|TestAccContainerNodePool_withGPU|TestAccContainerCluster_withAdvancedDatapath|TestAccContainerCluster_withShieldedNodes|TestAccContainerCluster_withDatabaseEncryption|TestAccContainerCluster_withAutopilot|TestAccContainerCluster_errorCleanDanglingCluster|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_networkingModeRoutes|TestAccContainerCluster_withWorkloadMetadataConfig|TestAccContainerCluster_withNodeConfigShieldedInstanceConfig|TestAccContainerNodePool_withNetworkConfig|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerCluster_withIPAllocationPolicy_specificSizes|TestAccContainerCluster_withBinaryAuthorization|TestAccContainerCluster_withFlexiblePodCIDR|TestAccContainerCluster_withNodeConfigScopeAlias|TestAccContainerCluster_withNodeConfig|TestAccContainerCluster_withAutoscalingProfile|TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges|TestAccContainerCluster_updateVersion|TestAccContainerCluster_basic|TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges|TestAccContainerCluster_nodeAutoprovisioningDefaultsMinCpuPlatform|TestAccContainerCluster_withVersion|TestAccContainerCluster_withIntraNodeVisibility|TestAccContainerCluster_withSoleTenantGroup|TestAccContainerCluster_deleteExclusionWindow|TestAccContainerCluster_updateMaintenanceExclusionOptions|TestAccContainerCluster_deleteMaintenanceExclusionOptions|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock_withAutopilot|TestAccContainerCluster_withPrivateClusterConfig|TestAccContainerCluster_withMaintenanceExclusionOptions|TestAccContainerCluster_withTpu|TestAccContainerCluster_regionalWithNodeLocations|TestAccContainerCluster_withMaintenanceExclusionWindow|TestAccContainerCluster_withRecurringMaintenanceWindow|TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType|TestAccContainerCluster_withMaintenanceWindow|TestAccContainerCluster_nodeAutoprovisioning|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_withMonitoringConfig|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerCluster_withNodePoolMultiple|TestAccContainerCluster_withNodePoolResize|TestAccContainerCluster_withNodePoolBasic|TestAccContainerCluster_withNodePoolUpdateVersion|TestAccContainerCluster_regional|TestAccContainerCluster_withLoggingConfig|TestAccContainerCluster_backend|TestAccContainerCluster_withMasterAuthorizedNetworksConfig|TestAccContainerCluster_withIdentityServiceConfig|TestAccContainerCluster_network|TestAccContainerCluster_withSandboxConfig|TestAccContainerCluster_withTelemetryEnabled|TestAccContainerCluster_withBootDiskKmsKey|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_withReleaseChannelEnabled|TestAccContainerCluster_withNetworkPolicyEnabled|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_withMasterAuthConfig_NoCert|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withILBSubsetting|TestAccContainerCluster_withNotificationConfig|TestAccContainerCluster_withAddons|TestAccContainerCluster_misc|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccContainerClusterDatasource_regional|TestAccContainerClusterDatasource_zonal

modular-magician avatar Jun 24 '22 22:06 modular-magician