magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Add Enabled as a parameter for authenticator_groups_config

Open derek-burdick opened this issue 2 years ago • 18 comments

This PR adds support to enable and disable authenticator_groups_config for container_cluster resource, AKA GKE.

If this PR is for Terraform, I acknowledge that I have:

  • [x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [x] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [x] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [x] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [x] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_container_cluster now supports enabling and disabling authenticator_groups_config. Changing authenticator_groups_config.0.security_group forces a new resource to be created.

derek-burdick avatar May 18 '22 17:05 derek-burdick

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

google-cla[bot] avatar May 18 '22 17:05 google-cla[bot]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician avatar May 18 '22 17:05 modular-magician

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @c2thorn, a repository maintainer, has been assigned to assist you and help review your changes.

:question: First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


modular-magician avatar May 18 '22 17:05 modular-magician

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician avatar May 18 '22 19:05 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 36 insertions(+), 12 deletions(-)) Terraform Beta: Diff ( 2 files changed, 32 insertions(+), 8 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar May 18 '22 19:05 modular-magician

Tests analytics

Total tests: 2019 Passed tests 1791 Skipped tests: 226 Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample

modular-magician avatar May 18 '22 20:05 modular-magician

Tests failed during RECORDING mode: TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample[view] TestAccContainerCluster_withAuthenticatorGroupsConfig[view]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar May 18 '22 20:05 modular-magician

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician avatar May 18 '22 20:05 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 48 insertions(+), 5 deletions(-)) Terraform Beta: Diff ( 3 files changed, 58 insertions(+), 15 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar May 18 '22 21:05 modular-magician

The provider crashed while running the VCR tests in REPLAYING mode Please fix it to complete your PR View the build log

modular-magician avatar May 18 '22 21:05 modular-magician

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician avatar May 18 '22 22:05 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 58 insertions(+), 13 deletions(-)) Terraform Beta: Diff ( 5 files changed, 64 insertions(+), 19 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar May 18 '22 22:05 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 65 insertions(+), 16 deletions(-)) Terraform Beta: Diff ( 5 files changed, 59 insertions(+), 10 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar May 18 '22 23:05 modular-magician

Tests analytics

Total tests: 2019 Passed tests 1791 Skipped tests: 226 Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFirebaserulesRelease_BasicRelease|TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample

modular-magician avatar May 18 '22 23:05 modular-magician

Tests passed during RECORDING mode: TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode: TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample[view]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar May 18 '22 23:05 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 65 insertions(+), 5 deletions(-)) Terraform Beta: Diff ( 3 files changed, 65 insertions(+), 5 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar May 24 '22 02:05 modular-magician

Tests analytics

Total tests: 2023 Passed tests 1796 Skipped tests: 226 Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccEventarcTrigger_BasicHandWritten

modular-magician avatar May 24 '22 03:05 modular-magician

Tests failed during RECORDING mode: TestAccEventarcTrigger_BasicHandWritten[view]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar May 24 '22 03:05 modular-magician