magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Add datasource for google_compute_instance_group_manager

Open kutysam opened this issue 2 years ago • 6 comments

Google compute instance group manager and region instance group manager datasources seem to be missing in google's terraform provider.

We need datasource to extract things like instance_template from the instance group manager. There are two versions, region and zone. Both are very similar.

The APIs that these 2 PRs are related to are

  1. google_compute_instance_group_manager - https://cloud.google.com/compute/docs/reference/rest/v1/instanceGroupManagers/get
  2. google_compute_region_instance_group_manager - https://cloud.google.com/compute/docs/reference/rest/v1/instanceRegionGroupManagers/get

If this PR is for Terraform, I acknowledge that I have:

  • [X] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [X] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [x] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [X] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [X] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

data_source_google_compute_instance_group_manager: Add datasource for google compute instance group manager
data_source_google_compute_region_instance_group_manager: Add datasource for google compute region instance group manager

kutysam avatar May 02 '22 07:05 kutysam

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

google-cla[bot] avatar May 02 '22 07:05 google-cla[bot]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician avatar May 02 '22 07:05 modular-magician

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @rileykarson, a repository maintainer, has been assigned to assist you and help review your changes.

:question: First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


modular-magician avatar May 02 '22 07:05 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 698 insertions(+)) Terraform Beta: Diff ( 5 files changed, 698 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar May 02 '22 07:05 modular-magician

The provider crashed while running the VCR tests in REPLAYING mode Please fix it to complete your PR View the build log

modular-magician avatar May 02 '22 07:05 modular-magician

Rather than handwriting the datasource, can you use the DS utility functions? That will keep the schema in sync. This an an example: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/data_sources/data_source_google_compute_disk.go

Thanks for this! I'll work on this format in coming days.

kutysam avatar May 06 '22 17:05 kutysam

Closing this PR

kutysam avatar Nov 11 '22 18:11 kutysam