magic-modules
magic-modules copied to clipboard
GoogleCloudPlatform
Add locality_lb_policies field to google_compute_backend_service
This is a new optional field that allows configuring custom load balancer policies in gRPC clients.
The field has been promoted to production, but at the moment requires a GCP project to be allowlisted for it to be used. I have run the test I defined for the field against an allowlisted test project.
part of https://github.com/hashicorp/terraform-provider-google/issues/11519
If this PR is for Terraform, I acknowledge that I have:
- [ X ] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
- [ X ] Generated Terraform, and ran
make testandmake lintto ensure it passes unit and linter tests. - [ X ] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
- [ X ] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
- [ X ] Read the Release Notes Guide before writing my release note below.
Release Note Template for Downstream PRs (will be copied)
compute: added `locality_lb_policies` field to `google_compute_backend_service`
Hello! I am a robot who works on Magic Modules PRs.
I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.
Thanks for your contribution! A human will be with you soon.
@rileykarson, please review this PR or find an appropriate assignee.
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.
Diff report:
Terraform GA: Diff ( 5 files changed, 717 insertions(+)) Terraform Beta: Diff ( 5 files changed, 717 insertions(+)) TF Validator: Diff ( 4 files changed, 187 insertions(+), 3 deletions(-))
Tests analytics
Total tests: 1987
Passed tests 1743
Skipped tests: 240
Failed tests: 4
Action taken
Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFirebaserulesRelease_BasicRelease|TestAccComputeBackendService_trafficDirectorLbPolicies|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic
Tests passed during RECORDING mode:
TestAccServiceNetworkingPeeredDNSDomain_basic[view]
TestAccFirebaserulesRelease_BasicRelease[view]
Tests failed during RECORDING mode:
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[view]
TestAccComputeBackendService_trafficDirectorLbPolicies[view]
Please fix these to complete your PR View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 5 files changed, 708 insertions(+)) Terraform Beta: Diff ( 5 files changed, 708 insertions(+)) TF Validator: Diff ( 4 files changed, 187 insertions(+), 3 deletions(-))
Tests analytics
Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0
Errors occurred during REPLAYING mode. Please fix them to complete your PR View the build log
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 5 files changed, 708 insertions(+)) Terraform Beta: Diff ( 5 files changed, 708 insertions(+)) TF Validator: Diff ( 4 files changed, 187 insertions(+), 3 deletions(-))
Tests analytics
Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0
Errors occurred during REPLAYING mode. Please fix them to complete your PR View the build log
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 5 files changed, 715 insertions(+)) Terraform Beta: Diff ( 5 files changed, 715 insertions(+)) TF Validator: Diff ( 4 files changed, 187 insertions(+), 3 deletions(-))
Tests analytics
Total tests: 2425
Passed tests 2170
Skipped tests: 253
Failed tests: 2
Action taken
Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccComputeBackendService_trafficDirectorLbPolicies
Tests passed during RECORDING mode:
TestAccServiceNetworkingPeeredDNSDomain_basic[Debug log]
Tests failed during RECORDING mode:
TestAccComputeBackendService_trafficDirectorLbPolicies[Error message] [Debug log]
Please fix these to complete your PR View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 5 files changed, 715 insertions(+)) Terraform Beta: Diff ( 5 files changed, 715 insertions(+)) TF Validator: Diff ( 4 files changed, 187 insertions(+), 3 deletions(-))
Tests analytics
Total tests: 2425
Passed tests 2166
Skipped tests: 253
Failed tests: 6
Action taken
Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccRegionInstanceGroupManager_stateful|TestAccComputeBackendService_trafficDirectorLbPolicies|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccVertexAIIndex_updated|TestAccFirebaserulesRelease_BasicRelease|TestAccLoggingBucketConfigProject_cmekSettings
Tests passed during RECORDING mode:
TestAccVertexAIIndex_updated[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
Tests failed during RECORDING mode:
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]
TestAccComputeBackendService_trafficDirectorLbPolicies[Error message] [Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[Error message] [Debug log]
Please fix these to complete your PR View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 5 files changed, 715 insertions(+)) Terraform Beta: Diff ( 5 files changed, 715 insertions(+)) TF Validator: Diff ( 4 files changed, 187 insertions(+), 3 deletions(-))
Tests analytics
Total tests: 2426
Passed tests 2170
Skipped tests: 253
Failed tests: 3
Action taken
Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccRegionInstanceGroupManager_stateful|TestAccComputeBackendService_trafficDirectorLbPolicies|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample
Tests failed during RECORDING mode:
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]
TestAccComputeBackendService_trafficDirectorLbPolicies[Error message] [Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[Error message] [Debug log]
Please fix these to complete your PR View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 5 files changed, 719 insertions(+)) Terraform Beta: Diff ( 5 files changed, 719 insertions(+)) TF Validator: Diff ( 4 files changed, 187 insertions(+), 3 deletions(-))
Tests analytics
Total tests: 2426
Passed tests 2169
Skipped tests: 253
Failed tests: 4
Action taken
Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccRegionInstanceGroupManager_stateful|TestAccComputeBackendService_trafficDirectorLbPolicies|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample
Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccRegionInstanceGroupManager_stateful[Debug log]
Tests failed during RECORDING mode:
TestAccComputeBackendService_trafficDirectorLbPolicies[Error message] [Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[Error message] [Debug log]
Please fix these to complete your PR View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 5 files changed, 715 insertions(+)) Terraform Beta: Diff ( 5 files changed, 715 insertions(+)) TF Validator: Diff ( 4 files changed, 187 insertions(+), 3 deletions(-))
Tests analytics
Total tests: 2426
Passed tests 2170
Skipped tests: 253
Failed tests: 3
Action taken
Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccRegionInstanceGroupManager_stateful|TestAccComputeBackendService_trafficDirectorLbPolicies|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample
Tests failed during RECORDING mode:
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]
TestAccComputeBackendService_trafficDirectorLbPolicies[Error message] [Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[Error message] [Debug log]
Please fix these to complete your PR View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 5 files changed, 719 insertions(+)) Terraform Beta: Diff ( 5 files changed, 719 insertions(+)) TF Validator: Diff ( 4 files changed, 187 insertions(+), 3 deletions(-))
Tests analytics
Total tests: 2424
Passed tests 2167
Skipped tests: 253
Failed tests: 4
Action taken
Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccRegionInstanceGroupManager_stateful|TestAccComputeBackendService_trafficDirectorLbPolicies|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample
Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
Tests failed during RECORDING mode:
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]
TestAccComputeBackendService_trafficDirectorLbPolicies[Error message] [Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[Error message] [Debug log]
Please fix these to complete your PR View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 5 files changed, 719 insertions(+)) Terraform Beta: Diff ( 5 files changed, 719 insertions(+)) TF Validator: Diff ( 4 files changed, 187 insertions(+), 3 deletions(-))
Tests analytics
Total tests: 2424
Passed tests 2169
Skipped tests: 253
Failed tests: 2
Action taken
Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeBackendService_trafficDirectorLbPolicies|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample
Tests failed during RECORDING mode:
TestAccComputeBackendService_trafficDirectorLbPolicies[Error message] [Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[Error message] [Debug log]
Please fix these to complete your PR View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 5 files changed, 719 insertions(+)) Terraform Beta: Diff ( 5 files changed, 719 insertions(+)) TF Validator: Diff ( 4 files changed, 187 insertions(+), 3 deletions(-))