compute: changed default value of `enable_endpoint_independent_mapping` to false in `google_compute_router_nat`

[shijeesh-ns]

fixes https://github.com/hashicorp/terraform-provider-google/issues/10547

If this PR is for Terraform, I acknowledge that I have:

• [X] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• [X] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• [X] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• [X] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• [X] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: changed default value of `enable_endpoint_independent_mapping` to false in `google_compute_router_nat`

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) Terraform Beta: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1982 Passed tests 1735 Skipped tests: 240 Failed tests: 7

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccVPCAccessConnector_cloudrunVPCAccessConnectorExample|TestAccComputeRouterNat_withNatIpsAndDrainNatIps|TestAccComputeRouterNat_withManualIpAndSubnetConfiguration|TestAccComputeRouterNat_removeLogConfig|TestAccComputeRouterNat_update|TestAccComputeRouterNat_basic|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic

[modular-magician]

Tests passed during RECORDING mode: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[view] TestAccComputeRouterNat_withManualIpAndSubnetConfiguration[view] TestAccVPCAccessConnector_cloudrunVPCAccessConnectorExample[view] TestAccComputeRouterNat_withNatIpsAndDrainNatIps[view] TestAccComputeRouterNat_update[view] TestAccComputeRouterNat_removeLogConfig[view] TestAccComputeRouterNat_basic[view]

All tests passed View the build log or the debug log for each test

[rileykarson]

Terraform's default reflects the original behaviour of the API mid-2021, "By default, NAT gateway uses Endpoint-Independent Mapping.". We're unable to make this change at this time, as it's a breaking change requiring a major version increment: https://www.terraform.io/plugin/sdkv2/best-practices/versioning#example-major-number-increments

This PR can be held until 5.0.0, at which point the change will be considered. We'll publish internal guidance prior to that release to ensure that service teams are adequately aware.

[shijeesh-ns]

Thank you for looking into this change. Is there a branch for 5.0 where I can merge this change? What is the expected release date for 5.0?

[rileykarson]

We don't have a strict timeline, but not before Nov 2022, a year after 4.0.0 (https://github.com/hashicorp/terraform-provider-google/releases/tag/v4.0.0). We'll likely create a branch in the future, but don't have one yet.

[shijeesh-ns]

@rileykarson, can we merge this change now?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• field-changing-default-value - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) Terraform Beta: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2355 Passed tests 2100 Skipped tests: 247 Failed tests: 8

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccComputeRouterNat_withNatIpsAndDrainNatIps|TestAccComputeRouterNat_withManualIpAndSubnetConfiguration|TestAccComputeRouterNat_removeLogConfig|TestAccComputeRouterNat_update|TestAccComputeRouterNat_basic|TestAccLoggingBucketConfigProject_cmekSettings|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic

[modular-magician]

Tests passed during RECORDING mode: TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log] TestAccComputeRouterNat_withNatIpsAndDrainNatIps[Debug log] TestAccComputeRouterNat_withManualIpAndSubnetConfiguration[Debug log] TestAccComputeRouterNat_removeLogConfig[Debug log] TestAccComputeRouterNat_update[Debug log] TestAccComputeRouterNat_basic[Debug log] TestAccLoggingBucketConfigProject_cmekSettings[Debug log] TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[Debug log]

All tests passed View the build log or the debug log for each test

[rileykarson]

We have not planned a 5.0.0 release yet, sorry! We don't have a projection of when that will be planned for at the moment.