magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Fix IAM Conditions Import Docs

Open upodroid opened this issue 2 years ago • 3 comments

Fixes: https://github.com/hashicorp/terraform-provider-google/issues/11338

If this PR is for Terraform, I acknowledge that I have:

  • [X] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [X] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [X] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [X] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [X] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


upodroid avatar Mar 29 '22 22:03 upodroid

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@melinath, please review this PR or find an appropriate assignee.

modular-magician avatar Mar 29 '22 22:03 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 15 insertions(+), 15 deletions(-)) Terraform Beta: Diff ( 3 files changed, 15 insertions(+), 15 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Mar 29 '22 22:03 modular-magician

On a second look, it is bit harder that expected.

We can tackle it as part of https://github.com/hashicorp/terraform-provider-google/issues/10751

upodroid avatar Apr 18 '22 23:04 upodroid