magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Allow setting source_location in google_compute_image

Open Yannic opened this issue 2 years ago • 9 comments

Fixes https://github.com/hashicorp/terraform-provider-google/issues/11148

Allow setting source_location in google_compute_image

Yannic avatar Mar 18 '22 17:03 Yannic

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@c2thorn, please review this PR or find an appropriate assignee.

modular-magician avatar Mar 18 '22 17:03 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 3 deletions(-)) Terraform Beta: Diff ( 2 files changed, 16 insertions(+), 4 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Mar 18 '22 17:03 modular-magician

@c2thorn thanks for the review and sorry for the delay! Ported the tests over from the previous PR, PTAL

Yannic avatar Apr 08 '22 10:04 Yannic

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 50 insertions(+), 3 deletions(-)) Terraform Beta: Diff ( 3 files changed, 62 insertions(+), 4 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Apr 08 '22 10:04 modular-magician

Tests analytics

Total tests: 1972 Passed tests 1717 Skipped tests: 237 Failed tests: 18

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAccessContextManager|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccComputeMachineImage_machineImageBasicExample|TestAccComputeMachineImage_computeMachineImageKmsExample|TestAccComputeGlobalForwardingRule_externalCdnLbWithBackendBucketExample|TestAccComputeInstanceFromMachineImage_diffProject|TestAccComputeForwardingRule_update|TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript|TestAccComputeInstanceFromMachineImage_basic|TestAccComputeImage_withStorageLocations|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample|TestAccComputeMachineImageIamPolicyGenerated_withCondition|TestAccComputeMachineImageIamMemberGenerated_withCondition|TestAccComputeMachineImageIamPolicyGenerated|TestAccComputeMachineImageIamBindingGenerated_withCondition|TestAccComputeMachineImageIamMemberGenerated|TestAccComputeMachineImageIamBindingGenerated

modular-magician avatar Apr 08 '22 11:04 modular-magician

Tests passed during RECORDING mode: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[view] TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample[view] TestAccComputeForwardingRule_update[view]

Tests failed during RECORDING mode: TestAccAccessContextManager[view] TestAccComputeImage_withStorageLocations[view] TestAccComputeInstanceFromMachineImage_diffProject[view] TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript[view] TestAccComputeInstanceFromMachineImage_basic[view] TestAccContainerCluster_withAuthenticatorGroupsConfig[view] TestAccComputeMachineImage_computeMachineImageKmsExample[view] TestAccComputeMachineImageIamMemberGenerated_withCondition[view] TestAccComputeGlobalForwardingRule_externalCdnLbWithBackendBucketExample[view] TestAccComputeMachineImageIamPolicyGenerated_withCondition[view] TestAccComputeMachineImage_machineImageBasicExample[view] TestAccComputeMachineImageIamPolicyGenerated[view] TestAccComputeMachineImageIamBindingGenerated_withCondition[view] TestAccComputeMachineImageIamBindingGenerated[view] TestAccComputeMachineImageIamMemberGenerated[view]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Apr 08 '22 11:04 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 50 insertions(+), 3 deletions(-)) Terraform Beta: Diff ( 3 files changed, 62 insertions(+), 3 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Apr 08 '22 17:04 modular-magician

Tests analytics

Total tests: 1973 Passed tests 1730 Skipped tests: 238 Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAccessContextManager|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccComputeGlobalForwardingRule_externalCdnLbWithBackendBucketExample|TestAccComputeImage_withStorageLocations|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic

modular-magician avatar Apr 08 '22 18:04 modular-magician

Tests passed during RECORDING mode: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[view]

Tests failed during RECORDING mode: TestAccAccessContextManager[view] TestAccContainerCluster_withAuthenticatorGroupsConfig[view] TestAccComputeImage_withStorageLocations[view] TestAccComputeGlobalForwardingRule_externalCdnLbWithBackendBucketExample[view]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Apr 08 '22 18:04 modular-magician