magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Add validationConfig attribute to FHIR store (#11201)

Open yinzara opened this issue 3 years ago • 8 comments

If this PR is for Terraform, I acknowledge that I have:

  • [X] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [X] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [X] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [ ] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [X] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

healthcare: Added `validation_config` in `google_healthcare_fhir_store`

Both make lint and make test returned errors unrelated to the changes I made. Integration tests failed with errors related to unused imports unrelated to changes I made.

yinzara avatar Mar 01 '22 18:03 yinzara

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@megan07, please review this PR or find an appropriate assignee.

modular-magician avatar Mar 01 '22 18:03 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 257 insertions(+)) Terraform Beta: Diff ( 3 files changed, 257 insertions(+)) TF Validator: Diff ( 3 files changed, 76 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 1 file changed, 10 insertions(+))

modular-magician avatar Mar 01 '22 19:03 modular-magician

/gcbrun

megan07 avatar Mar 03 '22 17:03 megan07

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 257 insertions(+)) Terraform Beta: Diff ( 3 files changed, 257 insertions(+)) TF Validator: Diff ( 3 files changed, 76 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 1 file changed, 10 insertions(+))

modular-magician avatar Mar 03 '22 17:03 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 257 insertions(+)) Terraform Beta: Diff ( 3 files changed, 257 insertions(+)) TF Validator: Diff ( 3 files changed, 76 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 1 file changed, 10 insertions(+))

modular-magician avatar Mar 03 '22 18:03 modular-magician

/gcbrun

megan07 avatar Mar 03 '22 20:03 megan07

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 257 insertions(+)) Terraform Beta: Diff ( 3 files changed, 257 insertions(+)) TF Validator: Diff ( 3 files changed, 76 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 1 file changed, 10 insertions(+))

modular-magician avatar Mar 03 '22 21:03 modular-magician

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceSqlDatabaseInstance_basic|TestAccCloudBuildTrigger_cloudbuildTriggerFilenameExample|TestAccCloudBuildTrigger_cloudbuildTriggerBuildExample|TestAccCloudBuildTrigger_basic|TestAccCloudBuildTrigger_available_secrets_config|TestAccCloudBuildTrigger_cloudbuildTriggerServiceAccountExample|TestAccCloudBuildTrigger_fullStep|TestAccCloudBuildTrigger_disable|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccHealthcareFhirStore_healthcareFhirStoreBasicExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=264266

modular-magician avatar Mar 03 '22 23:03 modular-magician