magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

fix TestAccComputeHaVpnGateway_haVpnGatewayGcpToGcpExample test collision

Open ScottSuarez opened this issue 3 years ago • 4 comments

ga and beta tests sometimes collide creating the same resource Release Note Template for Downstream PRs (will be copied)


ScottSuarez avatar Feb 25 '22 22:02 ScottSuarez

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 8 insertions(+), 8 deletions(-)) Terraform Beta: Diff ( 2 files changed, 8 insertions(+), 8 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-)) TF Cloud Doc Samples: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))

modular-magician avatar Feb 25 '22 23:02 modular-magician

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudbuildWorkerPool_basic|TestAccContainerCluster_withAuthenticatorGroupsConfig You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=262116

modular-magician avatar Feb 26 '22 01:02 modular-magician

Tests failed during RECORDING mode: TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccCloudbuildWorkerPool_basic Please fix these to complete your PR

modular-magician avatar Feb 26 '22 01:02 modular-magician

@ScottSuarez are you still working on this PR?

melinath avatar Apr 08 '22 21:04 melinath