magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

prevent `google_container_cluster` from crashing if an empty `authenticator_groups_config` is supplied

Open ScottSuarez opened this issue 3 years ago • 9 comments

closes https://github.com/hashicorp/terraform-provider-google/issues/11144

prevent resource container_cluster from attempting to cast nil to map[string]interface{}

Release Note Template for Downstream PRs (will be copied)

container: prevent `google_container_cluster` from crashing if an empty `authenticator_groups_config` block is supplied

ScottSuarez avatar Feb 23 '22 20:02 ScottSuarez

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-)) Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Feb 23 '22 20:02 modular-magician

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccCloudbuildWorkerPool_basic|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccEventarcTrigger_BasicHandWritten You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=261065

modular-magician avatar Feb 23 '22 23:02 modular-magician

Does this also need to be ported to TFV?

melinath avatar Feb 24 '22 16:02 melinath

Doesn't look like this block is defined in the tfv container cluster model https://github.com/GoogleCloudPlatform/magic-modules/blob/master/mmv1/third_party/validator/container.go

ScottSuarez avatar Feb 24 '22 19:02 ScottSuarez

@melinath

ScottSuarez avatar Feb 25 '22 23:02 ScottSuarez

@ScottSuarez are you still working on this PR?

melinath avatar Apr 08 '22 21:04 melinath

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-)) Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Apr 08 '22 21:04 modular-magician

Tests analytics

Total tests: 1971 Passed tests 1732 Skipped tests: 238 Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccServiceNetworkingPeeredDNSDomain_basic

modular-magician avatar Apr 08 '22 22:04 modular-magician

Tests passed during RECORDING mode: TestAccServiceNetworkingPeeredDNSDomain_basic[view]

All tests passed View the build log or the debug log for each test

modular-magician avatar Apr 08 '22 22:04 modular-magician