magic-modules
magic-modules copied to clipboard
prevent `google_container_cluster` from crashing if an empty `authenticator_groups_config` is supplied
closes https://github.com/hashicorp/terraform-provider-google/issues/11144
prevent resource container_cluster
from attempting to cast nil to map[string]interface{}
Release Note Template for Downstream PRs (will be copied)
container: prevent `google_container_cluster` from crashing if an empty `authenticator_groups_config` block is supplied
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.
Diff report:
Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-)) Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccCloudbuildWorkerPool_basic|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccEventarcTrigger_BasicHandWritten You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=261065
Does this also need to be ported to TFV?
Doesn't look like this block is defined in the tfv container cluster model https://github.com/GoogleCloudPlatform/magic-modules/blob/master/mmv1/third_party/validator/container.go
@melinath
@ScottSuarez are you still working on this PR?
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.
Diff report:
Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-)) Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
Tests analytics
Total tests: 1971
Passed tests 1732
Skipped tests: 238
Failed tests: 1
Action taken
Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccServiceNetworkingPeeredDNSDomain_basic