magic-modules
magic-modules copied to clipboard
Add capability to add a project in service perimeter in dry-run mode #7270
WIP PR, need support to fix issue 7270. I need support to implement the 'use_explicit_dry_run_spec' logic needed here.
I will add tests and check them one I implemented the full logic.
If this PR is for Terraform, I acknowledge that I have:
- [ ] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
- [ ] Generated Terraform, and ran
make test
andmake lint
to ensure it passes unit and linter tests. - [ ] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
- [ ] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
- [ ] Read the Release Notes Guide before writing my release note below.
Release Note Template for Downstream PRs (will be copied)
I created a new resource to be consistent with other resources where there are 2 separate variables for spec/status configuration.
I am now stuck at setting the 'use_explicit_dry_run_spec' attribute = true on all calls, not as a configurable resource variable.
Oops! It looks like you're using an unknown release-note type in your changelog entries:
- REPLACEME
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.
Hello! I am a robot who works on Magic Modules PRs.
I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.
Thanks for your contribution! A human will be with you soon.
@melinath, please review this PR or find an appropriate assignee.
Oops! It looks like you're using an unknown release-note type in your changelog entries:
- REPLACEME
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.
Oops! It looks like you're using an unknown release-note type in your changelog entries:
- REPLACEME
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.
Oops! It looks like you're using an unknown release-note type in your changelog entries:
- REPLACEME
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.
Oops! It looks like you're using an unknown release-note type in your changelog entries:
- REPLACEME
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.
Oops! It looks like you're using an unknown release-note type in your changelog entries:
- REPLACEME
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.
Oops! It looks like you're using an unknown release-note type in your changelog entries:
- REPLACEME
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.
Oops! It looks like you're using an unknown release-note type in your changelog entries:
- REPLACEME
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.