magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Remove at_least_one_of on start and end time

Open slevenick opened this issue 3 years ago • 1 comments

Fixes: https://github.com/hashicorp/terraform-provider-google/issues/10745

Validation doesn't seem needed as they have default values. One field in this object is already required, so no empty object is possible

If this PR is for Terraform, I acknowledge that I have:

  • [ ] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [ ] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [ ] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [ ] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [ ] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dlp: removed AtLeastOneOf validation on `inspect_job.storage_config.timespan_config.start_time` and `inspect_job.storage_config.timespan_config.end_time` in `google_data_loss_prevention_job_trigger`

slevenick avatar Dec 13 '21 23:12 slevenick

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 26 insertions(+), 28 deletions(-)) Terraform Beta: Diff ( 2 files changed, 8 insertions(+), 10 deletions(-))

modular-magician avatar Dec 14 '21 00:12 modular-magician