magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

feat(vertexai): Added vertexai endpoints to terraform provider.

Open simonbutt-datatonic opened this issue 3 years ago • 9 comments

Part of: hashicorp/terraform-provider-google#9298

If this PR is for Terraform, I acknowledge that I have:

  • [x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [x] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [x] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [x] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [x] Read the Release Notes Guide before writing my release note below.
`google_vertex_ai_endpoint`

simonbutt-datatonic avatar Nov 19 '21 12:11 simonbutt-datatonic

Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:

```release-note:TYPE
Release note
```

modular-magician avatar Nov 19 '21 12:11 modular-magician

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

modular-magician avatar Nov 19 '21 12:11 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 1616 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 5 files changed, 1616 insertions(+), 2 deletions(-)) TF Validator: Diff ( 1 file changed, 426 insertions(+))

modular-magician avatar Nov 19 '21 12:11 modular-magician

Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:

```release-note:TYPE
Release note
```

modular-magician avatar Nov 25 '21 12:11 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 1601 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 5 files changed, 1601 insertions(+), 2 deletions(-)) TF Validator: Diff ( 1 file changed, 426 insertions(+)) TF OiCS: Diff ( 4 files changed, 109 insertions(+))

modular-magician avatar Nov 25 '21 12:11 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 1601 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 5 files changed, 1601 insertions(+), 2 deletions(-)) TF Validator: Diff ( 1 file changed, 426 insertions(+)) TF OiCS: Diff ( 4 files changed, 109 insertions(+))

modular-magician avatar Nov 25 '21 13:11 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 1569 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 5 files changed, 1569 insertions(+), 2 deletions(-)) TF Validator: Diff ( 3 files changed, 429 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 4 files changed, 109 insertions(+))

modular-magician avatar Jun 29 '22 09:06 modular-magician

Tests analytics

Total tests: 2060 Passed tests 1830 Skipped tests: 226 Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withAddons|TestAccVertexAIEndpoint_vertexAiEndpointExample

modular-magician avatar Jun 29 '22 10:06 modular-magician

Tests passed during RECORDING mode: TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode: TestAccContainerCluster_withAddons[view] TestAccVertexAIEndpoint_vertexAiEndpointExample[view] TestAccContainerCluster_withConfidentialNodes[view]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Jun 29 '22 10:06 modular-magician