magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Ignore volatile state field in Notebooks Instance ISVs

Open rileykarson opened this issue 3 years ago • 6 comments

Caused a test failure last night

If this PR is for Terraform, I acknowledge that I have:

  • [ ] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [ ] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [ ] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [ ] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [ ] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

rileykarson avatar Nov 04 '21 16:11 rileykarson

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-)) Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))

modular-magician avatar Nov 04 '21 17:11 modular-magician

/gcbrun

rileykarson avatar Nov 04 '21 17:11 rileykarson

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-)) Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))

modular-magician avatar Nov 04 '21 17:11 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-)) Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))

modular-magician avatar Nov 04 '21 17:11 modular-magician

No idea what's up with VCR- it's failing on mechanical stuff, and that failure cancels the test/lint steps. I started https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/215445?buildTab=overview instead, as this seems like a random occurrence on this PR.

rileykarson avatar Nov 04 '21 18:11 rileykarson

Heya Riley, is this still relevant ?

ScottSuarez avatar Nov 17 '21 00:11 ScottSuarez