magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Remove warning about `taint`

Open jli opened this issue 2 years ago • 3 comments

The warning seems to say that the taint config is also managed outside of Terraform, so the resource could be recreated if this config is used. However, I didn't experience this in my testing.

I tested this like so:

  • Added taint config on my cluster_node_pool to mark a preemptible node pool with preemptible=true:NoSchedule.
  • Applied terraform config, which recreated the node pool with this taint.
  • Manually modified node taints, including removing the preemptible taint and adding other taints.
  • Reran terraform, which didn't report any diffs or try to recreate the node pool.

I think this is fine because this taint config applies at the node pool level, but dynamic taints occur at the node level. Or, am I misunderstanding the warning?

If this PR is for Terraform, I acknowledge that I have:

  • [x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [ ] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [x] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [ ] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [x] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


(cc @jmcarp )

jli avatar Oct 26 '21 21:10 jli

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

modular-magician avatar Oct 26 '21 21:10 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 6 deletions(-)) Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 6 deletions(-))

modular-magician avatar Oct 26 '21 21:10 modular-magician

I tested with google_container_node_pool only. But iiuc, google_container_cluster also creates a node pool which this config option applies to, so I think it would also apply there? (very low confidence on that though)

Let me know if you'd like me to revert back to the original and just mention that it's okay for the node pool resource?

jli avatar Nov 04 '21 01:11 jli