magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

✨ Add support for Log Views

Open estliberitas opened this issue 3 years ago • 6 comments

google_logging_view resource was added

part of https://github.com/hashicorp/terraform-provider-google/issues/7645

If this PR is for Terraform, I acknowledge that I have:

  • [X] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [X] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [X] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [X] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [X] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

estliberitas avatar Sep 16 '21 22:09 estliberitas

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Sep 16 '21 22:09 google-cla[bot]

@c2thorn what else shall I do in here?

estliberitas avatar Sep 16 '21 22:09 estliberitas

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

modular-magician avatar Sep 16 '21 22:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 548 insertions(+)) Terraform Beta: Diff ( 6 files changed, 549 insertions(+), 1 deletion(-))

modular-magician avatar Sep 16 '21 22:09 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 548 insertions(+)) Terraform Beta: Diff ( 6 files changed, 549 insertions(+))

modular-magician avatar Sep 16 '21 23:09 modular-magician

@rileykarson I wonder if there is any way to generate resource definitions in api Yaml file? Cuz it looks like API spec re-written in a different format?

estliberitas avatar Sep 18 '21 02:09 estliberitas