magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Recreate patch to add trigger_http to cloud function

Open slevenick opened this issue 3 years ago • 5 comments

Upstreams: https://github.com/hashicorp/terraform-provider-google/pull/9583

Upstreaming script didn't work as this refers to some .go.erb files

Need markdown docs on this, will ask contributor for them

If this PR is for Terraform, I acknowledge that I have:

  • [ ] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [ ] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [ ] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [ ] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [ ] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudfunctions: added support for `security_level` for HTTP triggers on `google_cloudfunctions_function`

slevenick avatar Aug 09 '21 20:08 slevenick

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 48 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 3 files changed, 49 insertions(+), 10 deletions(-))

modular-magician avatar Aug 09 '21 21:08 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 50 insertions(+), 9 deletions(-)) Terraform Beta: Diff ( 3 files changed, 50 insertions(+), 9 deletions(-))

modular-magician avatar Aug 16 '21 19:08 modular-magician

Error trying to cancel build ()

modular-magician avatar Aug 16 '21 19:08 modular-magician

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleCloudFunctionsFunction_basic|TestAccCloudFunctionsCloudFunctionIamBindingGenerated|TestAccCloudFunctionsCloudFunctionIamMemberGenerated|TestAccCloudFunctionsCloudFunctionIamPolicyGenerated|TestAccCloudFunctionsFunction_basic|TestAccCloudFunctionsFunction_update|TestAccCloudFunctionsFunction_sourceRepo|TestAccCloudFunctionsFunction_vpcConnector|TestAccCloudFunctionsFunction_serviceAccountEmail|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupFunctionsExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=201376

modular-magician avatar Aug 16 '21 20:08 modular-magician

Tests failed during RECORDING mode: TestAccCloudFunctionsCloudFunctionIamMemberGenerated|TestAccDataSourceGoogleCloudFunctionsFunction_basic|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupFunctionsExample|TestAccCloudFunctionsFunction_vpcConnector|TestAccCloudFunctionsCloudFunctionIamBindingGenerated|TestAccCloudFunctionsCloudFunctionIamPolicyGenerated Please fix these to complete your PR

modular-magician avatar Aug 16 '21 21:08 modular-magician