magic-modules
magic-modules copied to clipboard
Add linkedDatasetSource, type fields to datasets
Adding new fields to BigQuery's dataset resource, both under beta.
If this PR is for Terraform, I acknowledge that I have:
- [X] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
- [X] Generated Terraform, and ran
make test
andmake lint
to ensure it passes unit and linter tests. - [X] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
- [X] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
- [X] Read the Release Notes Guide before writing my release note below.
Release Note Template for Downstream PRs (will be copied)
Hello! I am a robot who works on Magic Modules PRs.
I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.
Thanks for your contribution! A human will be with you soon.
@rileykarson, please review this PR or find an appropriate assignee.
Friendly ping.
This is failing due to Ansible for some reason- it's never supported beta fields, so likely something related to that. I'm going to remove generator support for it (https://github.com/hashicorp/terraform-provider-google/issues/9588) so I'll get back to this after doing that.
Thanks, Riley! Do we have a rough ETA of when this might get merged?
Should this be okay now that https://github.com/GoogleCloudPlatform/magic-modules/pull/5069 has been merged?
Ah, yup, sorry about that- thought I followed up on this already. Can you rebase so we pick up the CI change?
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.
Diff report:
Terraform GA: Diff ( 1 file changed, 30 insertions(+)) Terraform Beta: Diff ( 4 files changed, 183 insertions(+), 3 deletions(-))
/gcbrun
Friendly ping.