magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Add linkedDatasetSource, type fields to datasets

Open NeilDevine opened this issue 3 years ago • 9 comments

Adding new fields to BigQuery's dataset resource, both under beta.

If this PR is for Terraform, I acknowledge that I have:

  • [X] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [X] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [X] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [X] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [X] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


NeilDevine avatar Jul 21 '21 23:07 NeilDevine

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

modular-magician avatar Jul 21 '21 23:07 modular-magician

Friendly ping.

dasch-1 avatar Aug 05 '21 16:08 dasch-1

This is failing due to Ansible for some reason- it's never supported beta fields, so likely something related to that. I'm going to remove generator support for it (https://github.com/hashicorp/terraform-provider-google/issues/9588) so I'll get back to this after doing that.

rileykarson avatar Aug 06 '21 16:08 rileykarson

Thanks, Riley! Do we have a rough ETA of when this might get merged?

dasch-1 avatar Aug 10 '21 17:08 dasch-1

Should this be okay now that https://github.com/GoogleCloudPlatform/magic-modules/pull/5069 has been merged?

NeilDevine avatar Aug 16 '21 22:08 NeilDevine

Ah, yup, sorry about that- thought I followed up on this already. Can you rebase so we pick up the CI change?

rileykarson avatar Aug 17 '21 19:08 rileykarson

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 30 insertions(+)) Terraform Beta: Diff ( 4 files changed, 183 insertions(+), 3 deletions(-))

modular-magician avatar Aug 17 '21 20:08 modular-magician

/gcbrun

NeilDevine avatar Aug 18 '21 16:08 NeilDevine

Friendly ping.

dasch-1 avatar Aug 24 '21 17:08 dasch-1