magic-modules
magic-modules copied to clipboard
Remove project field from IAM documentation
Fix: hashicorp/terraform-provider-google#7170
If this PR is for Terraform, I acknowledge that I have:
- [X] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
- [ ] Generated Terraform, and ran
make test
andmake lint
to ensure it passes unit and linter tests. - [ ] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
- [ ] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
- [ ] Read the Release Notes Guide before writing my release note below.
Release Note Template for Downstream PRs (will be copied)
Hello! I am a robot who works on Magic Modules PRs.
I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.
Thanks for your contribution! A human will be with you soon.
@rileykarson, please review this PR or find an appropriate assignee.
This is related to #4662
My understanding is the resource_iam.html.markdown.erb
file will include the project parameter if object.base_url
contain {{project}}
, which is true in https://github.com/GoogleCloudPlatform/magic-modules/blob/9d0a00f2dd79ed96655a3b3e849b2789b42c8a1d/mmv1/products/storage/api.yaml#L31
Looking at the following iam_policy.base_url
:
-
https://github.com/GoogleCloudPlatform/magic-modules/blob/9d0a00f2dd79ed96655a3b3e849b2789b42c8a1d/mmv1/products/artifactregistry/api.yaml#L66 and compare it to :
-
https://github.com/GoogleCloudPlatform/magic-modules/blob/9d0a00f2dd79ed96655a3b3e849b2789b42c8a1d/mmv1/products/storage/api.yaml#L48
I'm proposing changing the include comparison to use iam_policy.base_url value instead of base_url value
/gcbrun