fixed role-entity issue

[edwardmedia]

Fixes https://github.com/hashicorp/terraform-provider-google/issues/9299

If this PR is for Terraform, I acknowledge that I have:

• [x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• [x] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• [x] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• [ ] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• [x] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

storage: fixed no changes can be added in `role_entity` on `google_storage_bucket_acl` 

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 81 insertions(+), 20 deletions(-)) Terraform Beta: Diff ( 3 files changed, 83 insertions(+), 21 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=190901"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 81 insertions(+), 20 deletions(-)) Terraform Beta: Diff ( 2 files changed, 81 insertions(+), 20 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=190902"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccStorageBucketAcl_basic_add You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=190903"

[jdstone]

@rileykarson Is this going to be reviewed soon? We're waiting on this fix.

[jdstone]

@rileykarson @edwardmedia When will this PR be reviewed and merged? It's passed all the checks. We're really waiting on this fix.

[matthiaswronka]

Any updates on this PR?

[ScottSuarez]

Hey Edward, seems this is quite an old change. Do you have any context?

[edwardmedia]

@ScottSuarez yes it is quite old. Let me review this and let you know

[edwardmedia]

@ScottSuarez the added test TestAccStorageBucketAcl_basic_add could help explain the use case. I have also rebased the PR.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 82 insertions(+), 20 deletions(-)) Terraform Beta: Diff ( 2 files changed, 82 insertions(+), 20 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2319 Passed tests 2072 Skipped tests: 244 Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccLoggingBucketConfigProject_cmekSettings|TestAccFirebaserulesRelease_BasicRelease|TestAccStorageBucketAcl_basic_add

[modular-magician]

Tests passed during RECORDING mode: TestAccLoggingBucketConfigProject_cmekSettings[Debug log] TestAccFirebaserulesRelease_BasicRelease[Debug log] TestAccStorageBucketAcl_basic_add[Debug log]

All tests passed View the build log or the debug log for each test