magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

binauthz: Added failing tests

Open melinath opened this issue 3 years ago • 8 comments

If this PR is for Terraform, I acknowledge that I have:

  • [ ] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [ ] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [ ] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [ ] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [ ] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


melinath avatar Jun 01 '21 22:06 melinath

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 496 insertions(+)) Terraform Beta: Diff ( 1 file changed, 496 insertions(+))

modular-magician avatar Jun 01 '21 22:06 modular-magician

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=190027"

modular-magician avatar Jun 01 '21 22:06 modular-magician

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccBinaryAuthorizationPolicy_updateDefaultAttestors|TestAccBinaryAuthorizationPolicy_updateClusterAttestors You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=190124"

modular-magician avatar Jun 02 '21 00:06 modular-magician

/gcbrun

melinath avatar Jun 02 '21 15:06 melinath

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 496 insertions(+)) Terraform Beta: Diff ( 2 files changed, 498 insertions(+), 1 deletion(-))

modular-magician avatar Jun 02 '21 15:06 modular-magician

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=190183"

modular-magician avatar Jun 02 '21 15:06 modular-magician

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccBinaryAuthorizationPolicy_updateDefaultAttestors|TestAccBinaryAuthorizationPolicy_updateClusterAttestors You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=190193"

modular-magician avatar Jun 02 '21 17:06 modular-magician

Tests failed during RECORDING mode: TestAccBinaryAuthorizationPolicy_updateDefaultAttestors Please fix these to complete your PR

modular-magician avatar Jun 02 '21 18:06 modular-magician