magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Always sort resources by name

Open nicdumz opened this issue 3 weeks ago • 3 comments

Right now this is only happening when there are override resources. This should actually happen for all resources.

This will create minor ordering diffs in output, but is actuall a no-op.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


nicdumz avatar Dec 08 '25 13:12 nicdumz

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Dec 08 '25 13:12 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 12 insertions(+), 12 deletions(-)) google-beta provider: Diff ( 1 file changed, 12 insertions(+), 12 deletions(-))

modular-magician avatar Dec 08 '25 13:12 modular-magician

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Dec 11 '25 09:12 github-actions[bot]

@modular-magician reassign-reviewer @ScottSuarez

since you've made the most changes to this file in the past few months I assume you'd have more context, I'm not sure on the necessity of this or what it is functionally improving.

NickElliot avatar Dec 12 '25 22:12 NickElliot