GoogleCloudPlatform
feat: Add Audit Manager product definition
Adding support for audit manager resource in Terraform provider
`google_audit_manager_framework_audit`
`google_audit_manager_framework_audit_scope_report`
Hello! I am a robot. Tests will require approval from a repository maintainer to run.
Googlers: For automatic test runs see go/terraform-auto-test-runs.
@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
also please create a release note in the primary PR comment following https://googlecloudplatform.github.io/magic-modules/code-review/release-notes/
and please follow go/terraform-contribution-guide#before-you-begin to get automatic build approvals
also please create a release note in the primary PR comment following https://googlecloudplatform.github.io/magic-modules/code-review/release-notes/
and please follow go/terraform-contribution-guide#before-you-begin to get automatic build approvals
added
I've updated the changelog notes, when you make your new PR, you can cut/paste the datasource one.
I'm going to be OOO for over a week, I'll reassign the reviewer here to take over after you've made the appropriate changes.
Generally, we prefer to split out pull requests to be one resource/data source at a time.
Additionally, have you considered the updatability of all fields? I see none are marked
immutable, which means this resource should only have output-only or updatable fields. You'll need to follow https://googlecloudplatform.github.io/magic-modules/test/test/#add-an-update-test if that is the case.
i have updated file and mark as immutable and push in same pull request
Generally, we prefer to split out pull requests to be one resource/data source at a time.
Additionally, have you considered the updatability of all fields? I see none are marked
immutable, which means this resource should only have output-only or updatable fields. You'll need to follow https://googlecloudplatform.github.io/magic-modules/test/test/#add-an-update-test if that is the case.
Hey i have split this PR in two 1 for datasource - https://github.com/GoogleCloudPlatform/magic-modules/pull/15880/files 2 for resource - https://github.com/GoogleCloudPlatform/magic-modules/pull/15879
please review
@ScottSuarez This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.
@GoogleCloudPlatform/terraform-team @ScottSuarez This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.