feat: (storage) update signed_url to virtual style

[gurusai-voleti]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

storage: update `signed_url` to virtual style hosted url

[github-actions[bot]]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 79 insertions(+), 12 deletions(-)) google-beta provider: Diff ( 2 files changed, 79 insertions(+), 12 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 78 insertions(+), 12 deletions(-)) google-beta provider: Diff ( 2 files changed, 78 insertions(+), 12 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 91 insertions(+), 14 deletions(-)) google-beta provider: Diff ( 3 files changed, 91 insertions(+), 14 deletions(-))

[modular-magician]

Tests analytics

Total tests: 127 Passed tests: 115 Skipped tests: 10 Affected tests: 2

Click here to see the affected service packages

• storage

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccStorageSignedUrl_basicPathStyle
• TestAccStorageSignedUrl_basicVirtualStyle

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode: TestAccStorageSignedUrl_basicPathStyle [Error message] [Debug log] TestAccStorageSignedUrl_basicVirtualStyle [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 127 Passed tests: 115 Skipped tests: 10 Affected tests: 2

Click here to see the affected service packages

• storage

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccStorageSignedUrl_basicPathStyle
• TestAccStorageSignedUrl_basicVirtualStyle

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode: TestAccStorageSignedUrl_basicPathStyle [Debug log] TestAccStorageSignedUrl_basicVirtualStyle [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 127 Passed tests: 115 Skipped tests: 10 Affected tests: 2

Click here to see the affected service packages

• storage

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccStorageSignedUrl_basicPathStyle
• TestAccStorageSignedUrl_basicVirtualStyle

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode: TestAccStorageSignedUrl_basicPathStyle [Error message] [Debug log] TestAccStorageSignedUrl_basicVirtualStyle [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 91 insertions(+), 14 deletions(-)) google-beta provider: Diff ( 3 files changed, 91 insertions(+), 14 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 91 insertions(+), 14 deletions(-)) google-beta provider: Diff ( 3 files changed, 91 insertions(+), 14 deletions(-))

[modular-magician]

Tests analytics

Total tests: 127 Passed tests: 117 Skipped tests: 10 Affected tests: 0

Click here to see the affected service packages

• storage

🟢 All tests passed!

View the build log

[modular-magician]

Tests analytics

Total tests: 127 Passed tests: 117 Skipped tests: 10 Affected tests: 0

Click here to see the affected service packages

• storage

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 91 insertions(+), 14 deletions(-)) google-beta provider: Diff ( 3 files changed, 91 insertions(+), 14 deletions(-))

[modular-magician]

Tests analytics

Total tests: 128 Passed tests: 118 Skipped tests: 10 Affected tests: 0

Click here to see the affected service packages

• storage

🟢 All tests passed!

View the build log

[gurusai-voleti]

can you help me visualize the change here? We are modifying the url data's sign path, but how is the resultant signed_url affected? Is this a breaking change?

previously using the path style signed URL now changed to virtual style but for bucket names containing "." it used path style URL, as per signature its always same path we use for signature it doesn't change

this is not a breaking change the signed_url will default to virtual style now @c2thorn

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 95 insertions(+), 17 deletions(-)) google-beta provider: Diff ( 3 files changed, 95 insertions(+), 17 deletions(-))

[modular-magician]

Tests analytics

Total tests: 128 Passed tests: 118 Skipped tests: 10 Affected tests: 0

Click here to see the affected service packages

• storage

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 99 insertions(+), 18 deletions(-)) google-beta provider: Diff ( 3 files changed, 99 insertions(+), 18 deletions(-))

[modular-magician]

Tests analytics

Total tests: 128 Passed tests: 118 Skipped tests: 10 Affected tests: 0

Click here to see the affected service packages

• storage

🟢 All tests passed!

View the build log

[github-actions[bot]]

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions[bot]]

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[c2thorn]

updated the release note, otherwise LGTM