magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

updates docs for hybridReplicationParameters in google_netapp_volume

Open okrause opened this issue 4 months ago • 7 comments

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

netapp: improved documentation for `hybrid_replication_parameters` in `google_netapp_volumes`.

okrause avatar Nov 26 '25 10:11 okrause

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Nov 26 '25 10:11 github-actions[bot]

@Mehul3217 FYI

okrause avatar Nov 26 '25 10:11 okrause

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 33 insertions(+), 21 deletions(-)) google-beta provider: Diff ( 2 files changed, 33 insertions(+), 21 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_netapp_volume (38 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_netapp_volume" "primary" {
  hybrid_replication_parameters {
    cluster_location               = # value needed
    hybrid_replication_type        = # value needed
    large_volume_constituent_count = # value needed
    peer_cluster_name              = # value needed
    peer_ip_addresses              = # value needed
    peer_svm_name                  = # value needed
    peer_volume_name               = # value needed
  }
}


modular-magician avatar Nov 26 '25 16:11 modular-magician

Tests analytics

Total tests: 36 Passed tests: 36 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
  • netapp

🟢 All tests passed!

View the build log

modular-magician avatar Nov 26 '25 17:11 modular-magician

@slevenick This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Dec 03 '25 09:12 github-actions[bot]

@slevenick This PR is approved and has been waiting for merge for 2 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Dec 10 '25 09:12 github-actions[bot]

@slevenick Thanks for the hint. I resolved the comment.

okrause avatar Dec 11 '25 11:12 okrause

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Dec 16 '25 09:12 github-actions[bot]