magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

compute: Add `protection_tier` and `enable_emergent_maintenance` fields to `compute_future_reservation`

Open Asiderr opened this issue 1 month ago • 8 comments

This patch adds protection_tier and enable_emergent_maintenance to the google_compute_future_reservation resource.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `protection_tier` field to `google_compute_future_reservation` resource
compute: added `enable_emergent_maintenance` field to `google_compute_future_reservation` resource

Asiderr avatar Nov 26 '25 02:11 Asiderr

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Nov 26 '25 02:11 github-actions[bot]

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Nov 28 '25 09:11 github-actions[bot]

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Dec 02 '25 09:12 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 9 insertions(+)) google-beta provider: Diff ( 4 files changed, 83 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))

modular-magician avatar Dec 02 '25 16:12 modular-magician

Tests analytics

Total tests: 1309 Passed tests: 1223 Skipped tests: 83 Affected tests: 3

Click here to see the affected service packages
  • compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeFutureReservation_sharedFutureReservationExample
  • TestAccComputeFutureReservation_update
  • TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy

Get to know how VCR tests work

modular-magician avatar Dec 02 '25 17:12 modular-magician

🟢 Tests passed during RECORDING mode: TestAccComputeFutureReservation_update [Debug log] TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy [Debug log]

🔴 Tests failed when rerunning REPLAYING mode: TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode: TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician avatar Dec 02 '25 17:12 modular-magician

I'm going to be out of office for a while, I'm reassigning a new reviewer to take over after addressing my latest review comments.

c2thorn avatar Dec 03 '25 21:12 c2thorn

@modular-magician reassign-reviewer

c2thorn avatar Dec 03 '25 21:12 c2thorn

@Asiderr, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar Dec 18 '25 09:12 github-actions[bot]